From: Sean Paul <seanpaul@chromium.org> To: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: linux-fbdev@vger.kernel.org, Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Steven Rostedt <rostedt@goodmis.org>, DRI Development <dri-devel@lists.freedesktop.org>, Daniel Vetter <daniel.vetter@intel.com>, Alan Cox <alan@lxorguk.ukuu.org.uk> Subject: Re: [PATCH 1/4] fbcon: Make fbcon a built-time depency for fbdev Date: Thu, 13 Jul 2017 14:47:53 +0000 [thread overview] Message-ID: <20170713144753.n344ilasywtsqfxi@art_vandelay> (raw) In-Reply-To: <20170706125735.28299-2-daniel.vetter@ffwll.ch> On Thu, Jul 06, 2017 at 02:57:32PM +0200, Daniel Vetter wrote: <snip> > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Just 2 nits, code looks good. Reviewed-by: Sean Paul <seanpaul@chromium.org> > --- > v2: Switch to building fbcon code into fb.ko right away because the > cheap trick leads to a module depency loop. > --- > drivers/video/console/Kconfig | 2 +- > drivers/video/console/Makefile | 8 -------- > drivers/video/fbdev/core/Makefile | 11 +++++++++++ > drivers/video/{console => fbdev/core}/bitblit.c | 4 ---- > drivers/video/{console => fbdev/core}/fbcon.c | 13 +++---------- > drivers/video/{console => fbdev/core}/fbcon.h | 0 > drivers/video/{console => fbdev/core}/fbcon_ccw.c | 4 ---- > drivers/video/{console => fbdev/core}/fbcon_cw.c | 4 ---- > drivers/video/{console => fbdev/core}/fbcon_rotate.c | 4 ---- > drivers/video/{console => fbdev/core}/fbcon_rotate.h | 0 > drivers/video/{console => fbdev/core}/fbcon_ud.c | 4 ---- > drivers/video/fbdev/core/fbmem.c | 6 ++++++ > drivers/video/{console => fbdev/core}/softcursor.c | 4 ---- > drivers/video/{console => fbdev/core}/tileblit.c | 5 ----- > include/linux/fbcon.h | 12 ++++++++++++ > 15 files changed, 33 insertions(+), 48 deletions(-) > rename drivers/video/{console => fbdev/core}/bitblit.c (98%) > rename drivers/video/{console => fbdev/core}/fbcon.c (99%) > rename drivers/video/{console => fbdev/core}/fbcon.h (100%) > rename drivers/video/{console => fbdev/core}/fbcon_ccw.c (98%) > rename drivers/video/{console => fbdev/core}/fbcon_cw.c (98%) > rename drivers/video/{console => fbdev/core}/fbcon_rotate.c (95%) > rename drivers/video/{console => fbdev/core}/fbcon_rotate.h (100%) > rename drivers/video/{console => fbdev/core}/fbcon_ud.c (98%) > rename drivers/video/{console => fbdev/core}/softcursor.c (93%) > rename drivers/video/{console => fbdev/core}/tileblit.c (96%) > create mode 100644 include/linux/fbcon.h > > diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig > index 2111d06f8c81..7f1f1fbcef9e 100644 > --- a/drivers/video/console/Kconfig > +++ b/drivers/video/console/Kconfig > @@ -117,7 +117,7 @@ config DUMMY_CONSOLE_ROWS > Select 25 if you use a 640x480 resolution by default. > > config FRAMEBUFFER_CONSOLE > - tristate "Framebuffer Console support" > + bool "Framebuffer Console support" > depends on FB && !UML > select VT_HW_CONSOLE_BINDING > select CRC32 > diff --git a/drivers/video/console/Makefile b/drivers/video/console/Makefile > index 43bfa485db96..eb2cbec52643 100644 > --- a/drivers/video/console/Makefile > +++ b/drivers/video/console/Makefile > @@ -7,13 +7,5 @@ obj-$(CONFIG_SGI_NEWPORT_CONSOLE) += newport_con.o > obj-$(CONFIG_STI_CONSOLE) += sticon.o sticore.o > obj-$(CONFIG_VGA_CONSOLE) += vgacon.o > obj-$(CONFIG_MDA_CONSOLE) += mdacon.o > -obj-$(CONFIG_FRAMEBUFFER_CONSOLE) += fbcon.o bitblit.o softcursor.o > -ifeq ($(CONFIG_FB_TILEBLITTING),y) > -obj-$(CONFIG_FRAMEBUFFER_CONSOLE) += tileblit.o > -endif > -ifeq ($(CONFIG_FRAMEBUFFER_CONSOLE_ROTATION),y) > -obj-$(CONFIG_FRAMEBUFFER_CONSOLE) += fbcon_rotate.o fbcon_cw.o fbcon_ud.o \ > - fbcon_ccw.o > -endif > > obj-$(CONFIG_FB_STI) += sticore.o > diff --git a/drivers/video/fbdev/core/Makefile b/drivers/video/fbdev/core/Makefile > index 9e3ddf225393..0214b863ac3f 100644 > --- a/drivers/video/fbdev/core/Makefile > +++ b/drivers/video/fbdev/core/Makefile > @@ -4,6 +4,17 @@ obj-$(CONFIG_FB) += fb.o > fb-y := fbmem.o fbmon.o fbcmap.o fbsysfs.o \ > modedb.o fbcvt.o > fb-$(CONFIG_FB_DEFERRED_IO) += fb_defio.o > + > +ifeq ($(CONFIG_FRAMEBUFFER_CONSOLE),y) > +fb-y += fbcon.o bitblit.o softcursor.o fb-$(CONFIG_FRAMEBUFFER_CONSOLE) ? > +ifeq ($(CONFIG_FB_TILEBLITTING),y) > +fb-y += tileblit.o > +endif > +ifeq ($(CONFIG_FRAMEBUFFER_CONSOLE_ROTATION),y) > +fb-y += fbcon_rotate.o fbcon_cw.o fbcon_ud.o \ > + fbcon_ccw.o > +endif > +endif > fb-objs := $(fb-y) > > obj-$(CONFIG_FB_CFB_FILLRECT) += cfbfillrect.o <snip> > diff --git a/include/linux/fbcon.h b/include/linux/fbcon.h > new file mode 100644 > index 000000000000..0fac6305d51c > --- /dev/null > +++ b/include/linux/fbcon.h IANAL, but it seems like you're missing some GPL legalese here? Sean > @@ -0,0 +1,12 @@ > +#ifndef _LINUX_FBCON_H > +#define _LINUX_FBCON_H > + > +#ifdef CONFIG_FRAMEBUFFER_CONSOLE > +void __init fb_console_init(void); > +void __exit fb_console_exit(void); > +#else > +static void fb_console_init(void) {} > +static void fb_console_exit(void) {} > +#endif > + > +#endif /* _LINUX_FBCON_H */ > -- > 2.13.2 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Sean Paul, Software Engineer, Google / Chromium OS
WARNING: multiple messages have this Message-ID (diff)
From: Sean Paul <seanpaul@chromium.org> To: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: linux-fbdev@vger.kernel.org, Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Steven Rostedt <rostedt@goodmis.org>, DRI Development <dri-devel@lists.freedesktop.org>, Daniel Vetter <daniel.vetter@intel.com>, Alan Cox <alan@lxorguk.ukuu.org.uk> Subject: Re: [PATCH 1/4] fbcon: Make fbcon a built-time depency for fbdev Date: Thu, 13 Jul 2017 10:47:53 -0400 [thread overview] Message-ID: <20170713144753.n344ilasywtsqfxi@art_vandelay> (raw) In-Reply-To: <20170706125735.28299-2-daniel.vetter@ffwll.ch> On Thu, Jul 06, 2017 at 02:57:32PM +0200, Daniel Vetter wrote: <snip> > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Just 2 nits, code looks good. Reviewed-by: Sean Paul <seanpaul@chromium.org> > --- > v2: Switch to building fbcon code into fb.ko right away because the > cheap trick leads to a module depency loop. > --- > drivers/video/console/Kconfig | 2 +- > drivers/video/console/Makefile | 8 -------- > drivers/video/fbdev/core/Makefile | 11 +++++++++++ > drivers/video/{console => fbdev/core}/bitblit.c | 4 ---- > drivers/video/{console => fbdev/core}/fbcon.c | 13 +++---------- > drivers/video/{console => fbdev/core}/fbcon.h | 0 > drivers/video/{console => fbdev/core}/fbcon_ccw.c | 4 ---- > drivers/video/{console => fbdev/core}/fbcon_cw.c | 4 ---- > drivers/video/{console => fbdev/core}/fbcon_rotate.c | 4 ---- > drivers/video/{console => fbdev/core}/fbcon_rotate.h | 0 > drivers/video/{console => fbdev/core}/fbcon_ud.c | 4 ---- > drivers/video/fbdev/core/fbmem.c | 6 ++++++ > drivers/video/{console => fbdev/core}/softcursor.c | 4 ---- > drivers/video/{console => fbdev/core}/tileblit.c | 5 ----- > include/linux/fbcon.h | 12 ++++++++++++ > 15 files changed, 33 insertions(+), 48 deletions(-) > rename drivers/video/{console => fbdev/core}/bitblit.c (98%) > rename drivers/video/{console => fbdev/core}/fbcon.c (99%) > rename drivers/video/{console => fbdev/core}/fbcon.h (100%) > rename drivers/video/{console => fbdev/core}/fbcon_ccw.c (98%) > rename drivers/video/{console => fbdev/core}/fbcon_cw.c (98%) > rename drivers/video/{console => fbdev/core}/fbcon_rotate.c (95%) > rename drivers/video/{console => fbdev/core}/fbcon_rotate.h (100%) > rename drivers/video/{console => fbdev/core}/fbcon_ud.c (98%) > rename drivers/video/{console => fbdev/core}/softcursor.c (93%) > rename drivers/video/{console => fbdev/core}/tileblit.c (96%) > create mode 100644 include/linux/fbcon.h > > diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig > index 2111d06f8c81..7f1f1fbcef9e 100644 > --- a/drivers/video/console/Kconfig > +++ b/drivers/video/console/Kconfig > @@ -117,7 +117,7 @@ config DUMMY_CONSOLE_ROWS > Select 25 if you use a 640x480 resolution by default. > > config FRAMEBUFFER_CONSOLE > - tristate "Framebuffer Console support" > + bool "Framebuffer Console support" > depends on FB && !UML > select VT_HW_CONSOLE_BINDING > select CRC32 > diff --git a/drivers/video/console/Makefile b/drivers/video/console/Makefile > index 43bfa485db96..eb2cbec52643 100644 > --- a/drivers/video/console/Makefile > +++ b/drivers/video/console/Makefile > @@ -7,13 +7,5 @@ obj-$(CONFIG_SGI_NEWPORT_CONSOLE) += newport_con.o > obj-$(CONFIG_STI_CONSOLE) += sticon.o sticore.o > obj-$(CONFIG_VGA_CONSOLE) += vgacon.o > obj-$(CONFIG_MDA_CONSOLE) += mdacon.o > -obj-$(CONFIG_FRAMEBUFFER_CONSOLE) += fbcon.o bitblit.o softcursor.o > -ifeq ($(CONFIG_FB_TILEBLITTING),y) > -obj-$(CONFIG_FRAMEBUFFER_CONSOLE) += tileblit.o > -endif > -ifeq ($(CONFIG_FRAMEBUFFER_CONSOLE_ROTATION),y) > -obj-$(CONFIG_FRAMEBUFFER_CONSOLE) += fbcon_rotate.o fbcon_cw.o fbcon_ud.o \ > - fbcon_ccw.o > -endif > > obj-$(CONFIG_FB_STI) += sticore.o > diff --git a/drivers/video/fbdev/core/Makefile b/drivers/video/fbdev/core/Makefile > index 9e3ddf225393..0214b863ac3f 100644 > --- a/drivers/video/fbdev/core/Makefile > +++ b/drivers/video/fbdev/core/Makefile > @@ -4,6 +4,17 @@ obj-$(CONFIG_FB) += fb.o > fb-y := fbmem.o fbmon.o fbcmap.o fbsysfs.o \ > modedb.o fbcvt.o > fb-$(CONFIG_FB_DEFERRED_IO) += fb_defio.o > + > +ifeq ($(CONFIG_FRAMEBUFFER_CONSOLE),y) > +fb-y += fbcon.o bitblit.o softcursor.o fb-$(CONFIG_FRAMEBUFFER_CONSOLE) ? > +ifeq ($(CONFIG_FB_TILEBLITTING),y) > +fb-y += tileblit.o > +endif > +ifeq ($(CONFIG_FRAMEBUFFER_CONSOLE_ROTATION),y) > +fb-y += fbcon_rotate.o fbcon_cw.o fbcon_ud.o \ > + fbcon_ccw.o > +endif > +endif > fb-objs := $(fb-y) > > obj-$(CONFIG_FB_CFB_FILLRECT) += cfbfillrect.o <snip> > diff --git a/include/linux/fbcon.h b/include/linux/fbcon.h > new file mode 100644 > index 000000000000..0fac6305d51c > --- /dev/null > +++ b/include/linux/fbcon.h IANAL, but it seems like you're missing some GPL legalese here? Sean > @@ -0,0 +1,12 @@ > +#ifndef _LINUX_FBCON_H > +#define _LINUX_FBCON_H > + > +#ifdef CONFIG_FRAMEBUFFER_CONSOLE > +void __init fb_console_init(void); > +void __exit fb_console_exit(void); > +#else > +static void fb_console_init(void) {} > +static void fb_console_exit(void) {} > +#endif > + > +#endif /* _LINUX_FBCON_H */ > -- > 2.13.2 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-07-13 14:47 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-07-06 12:57 [PATCH 0/4] Make fbcon a built-time depency for fbdev, take 2 Daniel Vetter 2017-07-06 12:57 ` Daniel Vetter 2017-07-06 12:57 ` [PATCH 1/4] fbcon: Make fbcon a built-time depency for fbdev Daniel Vetter 2017-07-06 12:57 ` Daniel Vetter 2017-07-12 10:40 ` Bartlomiej Zolnierkiewicz 2017-07-12 10:40 ` Bartlomiej Zolnierkiewicz [not found] ` <CGME20170801154317epcas2p1e0f43ea1e060a6b4c7ab0e77ae1f3bda@epcas2p1.samsung.com> 2017-08-01 15:43 ` Bartlomiej Zolnierkiewicz 2017-08-01 15:43 ` Bartlomiej Zolnierkiewicz 2017-07-13 14:47 ` Sean Paul [this message] 2017-07-13 14:47 ` Sean Paul 2017-07-13 18:49 ` Daniel Vetter 2017-07-13 18:49 ` Daniel Vetter 2017-07-06 12:57 ` [PATCH 2/4] fbdev: Nuke FBINFO_MODULE Daniel Vetter 2017-07-06 12:57 ` Daniel Vetter 2017-07-11 9:26 ` [PATCH] " Daniel Vetter 2017-07-11 9:26 ` Daniel Vetter 2017-07-11 14:52 ` Daniel Vetter 2017-07-11 14:52 ` Daniel Vetter 2017-07-12 10:41 ` Bartlomiej Zolnierkiewicz 2017-07-12 10:41 ` Bartlomiej Zolnierkiewicz 2017-07-12 12:42 ` Daniel Vetter 2017-07-12 12:42 ` Daniel Vetter [not found] ` <CGME20170712125413epcas5p31b162be09cc3f0a27f84ad14b2938921@epcas5p3.samsung.com> 2017-07-12 12:54 ` Bartlomiej Zolnierkiewicz 2017-07-12 12:54 ` Bartlomiej Zolnierkiewicz 2017-07-12 15:07 ` Daniel Vetter 2017-07-12 15:07 ` Daniel Vetter [not found] ` <CGME20170713140159epcas1p4e02936e9873df84d3b56498a09692886@epcas1p4.samsung.com> 2017-07-13 14:01 ` Bartlomiej Zolnierkiewicz 2017-07-13 14:01 ` Bartlomiej Zolnierkiewicz [not found] ` <CGME20170801154325epcas1p2af41ab0f0c9040074622b0627a679ba5@epcas1p2.samsung.com> 2017-08-01 15:43 ` Bartlomiej Zolnierkiewicz 2017-08-01 15:43 ` Bartlomiej Zolnierkiewicz 2017-07-13 14:50 ` Sean Paul 2017-07-13 14:50 ` Sean Paul 2017-07-06 12:57 ` [PATCH 3/4] drm/qxl: Drop fbdev hwaccel flags Daniel Vetter 2017-07-06 12:57 ` Daniel Vetter 2017-07-19 7:39 ` Daniel Vetter 2017-07-19 7:39 ` Daniel Vetter 2017-07-19 7:39 ` Daniel Vetter 2017-07-06 12:57 ` [PATCH 4/4] drm/<drivers>: Drop fbdev info flags Daniel Vetter 2017-07-06 12:57 ` Daniel Vetter 2017-07-13 14:52 ` Sean Paul 2017-07-13 14:52 ` Sean Paul 2017-07-06 15:20 ` ✓ Fi.CI.BAT: success for Make fbcon a built-time depency for fbdev, take 2 Patchwork 2017-07-11 9:31 ` ✗ Fi.CI.BAT: failure for Make fbcon a built-time depency for fbdev, take 2 (rev2) Patchwork 2017-07-11 15:26 ` ✗ Fi.CI.BAT: failure for Make fbcon a built-time depency for fbdev, take 2 (rev3) Patchwork 2017-07-07 23:21 [Intel-gfx] [PATCH 2/4] fbdev: Nuke FBINFO_MODULE kbuild test robot 2017-07-07 23:21 ` kbuild test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170713144753.n344ilasywtsqfxi@art_vandelay \ --to=seanpaul@chromium.org \ --cc=alan@lxorguk.ukuu.org.uk \ --cc=b.zolnierkie@samsung.com \ --cc=daniel.vetter@ffwll.ch \ --cc=daniel.vetter@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=rostedt@goodmis.org \ --cc=sergey.senozhatsky.work@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.