* [xfstests PATCH] common/rc: support jfs in _scratch_mkfs_sized
@ 2017-07-14 22:06 Ernesto A. Fernández
2017-07-19 1:37 ` [xfstests PATCH v2] " Ernesto A. Fernández
0 siblings, 1 reply; 3+ messages in thread
From: Ernesto A. Fernández @ 2017-07-14 22:06 UTC (permalink / raw)
To: fstests; +Cc: Eryu Guan, jfs-discussion, Ernesto A. Fernández
Add support for jfs in _scratch_mkfs_sized. Fix the block size in 4096,
which seems to be the only option in jfs_mkfs.
Signed-off-by: Ernesto A. Fernández <ernesto.mnd.fernandez@gmail.com>
---
This change in common/rc is different from the one sent as part of
generic/447, which was not working as intended. I will soon send a revision
of that patch as well.
common/rc | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/common/rc b/common/rc
index b505365..5cb6b0c 100644
--- a/common/rc
+++ b/common/rc
@@ -1023,6 +1023,8 @@ _scratch_mkfs_sized()
ext2|ext3|ext4|ext4dev|udf|btrfs|reiser4|ocfs2)
def_blksz=`echo $MKFS_OPTIONS| sed -rn 's/.*-b ?+([0-9]+).*/\1/p'`
;;
+ jfs)
+ def_blksz=4096
esac
[ -n "$def_blksz" ] && blocksize=$def_blksz
@@ -1068,6 +1070,9 @@ _scratch_mkfs_sized()
(( fssize <= 100 * 1024 * 1024 )) && mixed_opt='--mixed'
$MKFS_BTRFS_PROG $MKFS_OPTIONS $mixed_opt -b $fssize $SCRATCH_DEV
;;
+ jfs)
+ ${MKFS_PROG}.$FSTYP $MKFS_OPTIONS $SCRATCH_DEV $blocks
+ ;;
reiser4)
# mkfs.resier4 requires size in KB as input for creating filesystem
$MKFS_REISER4_PROG $MKFS_OPTIONS -y -b $blocksize $SCRATCH_DEV \
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [xfstests PATCH v2] common/rc: support jfs in _scratch_mkfs_sized
2017-07-14 22:06 [xfstests PATCH] common/rc: support jfs in _scratch_mkfs_sized Ernesto A. Fernández
@ 2017-07-19 1:37 ` Ernesto A. Fernández
2017-07-19 3:15 ` Eryu Guan
0 siblings, 1 reply; 3+ messages in thread
From: Ernesto A. Fernández @ 2017-07-19 1:37 UTC (permalink / raw)
To: fstests; +Cc: Eryu Guan, jfs-discussion, Ernesto A. Fernández
Add support for jfs in _scratch_mkfs_sized. Fix the block size in 4096,
which seems to be the only option in jfs_mkfs.
Signed-off-by: Ernesto A. Fernández <ernesto.mnd.fernandez@gmail.com>
---
I'm sorry, it seems I dropped a double semicolon. It worked the same of course,
but better to fix it.
common/rc | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/common/rc b/common/rc
index fa1314c..c537ab4 100644
--- a/common/rc
+++ b/common/rc
@@ -1023,6 +1023,9 @@ _scratch_mkfs_sized()
ext2|ext3|ext4|ext4dev|udf|btrfs|reiser4|ocfs2)
def_blksz=`echo $MKFS_OPTIONS| sed -rn 's/.*-b ?+([0-9]+).*/\1/p'`
;;
+ jfs)
+ def_blksz=4096
+ ;;
esac
[ -n "$def_blksz" ] && blocksize=$def_blksz
@@ -1068,6 +1071,9 @@ _scratch_mkfs_sized()
(( fssize <= 100 * 1024 * 1024 )) && mixed_opt='--mixed'
$MKFS_BTRFS_PROG $MKFS_OPTIONS $mixed_opt -b $fssize $SCRATCH_DEV
;;
+ jfs)
+ ${MKFS_PROG}.$FSTYP $MKFS_OPTIONS $SCRATCH_DEV $blocks
+ ;;
reiser4)
# mkfs.resier4 requires size in KB as input for creating filesystem
$MKFS_REISER4_PROG $MKFS_OPTIONS -y -b $blocksize $SCRATCH_DEV \
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [xfstests PATCH v2] common/rc: support jfs in _scratch_mkfs_sized
2017-07-19 1:37 ` [xfstests PATCH v2] " Ernesto A. Fernández
@ 2017-07-19 3:15 ` Eryu Guan
0 siblings, 0 replies; 3+ messages in thread
From: Eryu Guan @ 2017-07-19 3:15 UTC (permalink / raw)
To: Ernesto A. Fernández; +Cc: fstests, jfs-discussion
On Tue, Jul 18, 2017 at 10:37:10PM -0300, Ernesto A. Fernández wrote:
> Add support for jfs in _scratch_mkfs_sized. Fix the block size in 4096,
> which seems to be the only option in jfs_mkfs.
>
> Signed-off-by: Ernesto A. Fernández <ernesto.mnd.fernandez@gmail.com>
> ---
> I'm sorry, it seems I dropped a double semicolon. It worked the same of course,
> but better to fix it.
Thanks for the update! I didn't catch it in my review either..
Eryu
>
> common/rc | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/common/rc b/common/rc
> index fa1314c..c537ab4 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -1023,6 +1023,9 @@ _scratch_mkfs_sized()
> ext2|ext3|ext4|ext4dev|udf|btrfs|reiser4|ocfs2)
> def_blksz=`echo $MKFS_OPTIONS| sed -rn 's/.*-b ?+([0-9]+).*/\1/p'`
> ;;
> + jfs)
> + def_blksz=4096
> + ;;
> esac
>
> [ -n "$def_blksz" ] && blocksize=$def_blksz
> @@ -1068,6 +1071,9 @@ _scratch_mkfs_sized()
> (( fssize <= 100 * 1024 * 1024 )) && mixed_opt='--mixed'
> $MKFS_BTRFS_PROG $MKFS_OPTIONS $mixed_opt -b $fssize $SCRATCH_DEV
> ;;
> + jfs)
> + ${MKFS_PROG}.$FSTYP $MKFS_OPTIONS $SCRATCH_DEV $blocks
> + ;;
> reiser4)
> # mkfs.resier4 requires size in KB as input for creating filesystem
> $MKFS_REISER4_PROG $MKFS_OPTIONS -y -b $blocksize $SCRATCH_DEV \
> --
> 2.1.4
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-19 3:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-14 22:06 [xfstests PATCH] common/rc: support jfs in _scratch_mkfs_sized Ernesto A. Fernández
2017-07-19 1:37 ` [xfstests PATCH v2] " Ernesto A. Fernández
2017-07-19 3:15 ` Eryu Guan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.