* [Buildroot] [PATCH 1/3] package/nodejs: use shared c-ares if available
@ 2017-07-15 17:38 Martin Bark
2017-07-15 17:38 ` [Buildroot] [PATCH 2/3] package/nodejs: use shared libhttpparser " Martin Bark
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Martin Bark @ 2017-07-15 17:38 UTC (permalink / raw)
To: buildroot
Signed-off-by: Martin Bark <martin@barkynet.com>
---
package/nodejs/nodejs.mk | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk
index 43c5ff3..a469153 100644
--- a/package/nodejs/nodejs.mk
+++ b/package/nodejs/nodejs.mk
@@ -34,6 +34,11 @@ else
NODEJS_CONF_OPTS += --with-intl=none
endif
+ifeq ($(BR2_PACKAGE_C_ARES),y)
+NODEJS_DEPENDENCIES += c-ares
+NODEJS_CONF_OPTS += --shared-cares
+endif
+
ifneq ($(BR2_PACKAGE_NODEJS_NPM),y)
NODEJS_CONF_OPTS += --without-npm
endif
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 2/3] package/nodejs: use shared libhttpparser if available
2017-07-15 17:38 [Buildroot] [PATCH 1/3] package/nodejs: use shared c-ares if available Martin Bark
@ 2017-07-15 17:38 ` Martin Bark
2017-07-15 17:38 ` [Buildroot] [PATCH 3/3] package/nodejs: use shared libuv " Martin Bark
2017-07-15 19:44 ` [Buildroot] [PATCH 1/3] package/nodejs: use shared c-ares " Thomas Petazzoni
2 siblings, 0 replies; 7+ messages in thread
From: Martin Bark @ 2017-07-15 17:38 UTC (permalink / raw)
To: buildroot
Signed-off-by: Martin Bark <martin@barkynet.com>
---
package/nodejs/nodejs.mk | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk
index a469153..ba7ad3f 100644
--- a/package/nodejs/nodejs.mk
+++ b/package/nodejs/nodejs.mk
@@ -39,6 +39,11 @@ NODEJS_DEPENDENCIES += c-ares
NODEJS_CONF_OPTS += --shared-cares
endif
+ifeq ($(BR2_PACKAGE_LIBHTTPPARSER),y)
+NODEJS_DEPENDENCIES += libhttpparser
+NODEJS_CONF_OPTS += --shared-http-parser
+endif
+
ifneq ($(BR2_PACKAGE_NODEJS_NPM),y)
NODEJS_CONF_OPTS += --without-npm
endif
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 3/3] package/nodejs: use shared libuv if available
2017-07-15 17:38 [Buildroot] [PATCH 1/3] package/nodejs: use shared c-ares if available Martin Bark
2017-07-15 17:38 ` [Buildroot] [PATCH 2/3] package/nodejs: use shared libhttpparser " Martin Bark
@ 2017-07-15 17:38 ` Martin Bark
2017-07-15 19:44 ` [Buildroot] [PATCH 1/3] package/nodejs: use shared c-ares " Thomas Petazzoni
2 siblings, 0 replies; 7+ messages in thread
From: Martin Bark @ 2017-07-15 17:38 UTC (permalink / raw)
To: buildroot
Signed-off-by: Martin Bark <martin@barkynet.com>
---
package/nodejs/nodejs.mk | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk
index ba7ad3f..d229d75 100644
--- a/package/nodejs/nodejs.mk
+++ b/package/nodejs/nodejs.mk
@@ -44,6 +44,11 @@ NODEJS_DEPENDENCIES += libhttpparser
NODEJS_CONF_OPTS += --shared-http-parser
endif
+ifeq ($(BR2_PACKAGE_LIBUV),y)
+NODEJS_DEPENDENCIES += libuv
+NODEJS_CONF_OPTS += --shared-libuv
+endif
+
ifneq ($(BR2_PACKAGE_NODEJS_NPM),y)
NODEJS_CONF_OPTS += --without-npm
endif
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/3] package/nodejs: use shared c-ares if available
2017-07-15 17:38 [Buildroot] [PATCH 1/3] package/nodejs: use shared c-ares if available Martin Bark
2017-07-15 17:38 ` [Buildroot] [PATCH 2/3] package/nodejs: use shared libhttpparser " Martin Bark
2017-07-15 17:38 ` [Buildroot] [PATCH 3/3] package/nodejs: use shared libuv " Martin Bark
@ 2017-07-15 19:44 ` Thomas Petazzoni
2017-07-15 23:12 ` Martin Bark
2 siblings, 1 reply; 7+ messages in thread
From: Thomas Petazzoni @ 2017-07-15 19:44 UTC (permalink / raw)
To: buildroot
Hello,
On Sat, 15 Jul 2017 18:38:27 +0100, Martin Bark wrote:
> diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk
> index 43c5ff3..a469153 100644
> --- a/package/nodejs/nodejs.mk
> +++ b/package/nodejs/nodejs.mk
> @@ -34,6 +34,11 @@ else
> NODEJS_CONF_OPTS += --with-intl=none
> endif
>
> +ifeq ($(BR2_PACKAGE_C_ARES),y)
> +NODEJS_DEPENDENCIES += c-ares
> +NODEJS_CONF_OPTS += --shared-cares
> +endif
So what happens if BR2_PACKAGE_C_ARES is disabled? It is not
needed/used by nodejs, or some internal/built-in version is used?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/3] package/nodejs: use shared c-ares if available
2017-07-15 19:44 ` [Buildroot] [PATCH 1/3] package/nodejs: use shared c-ares " Thomas Petazzoni
@ 2017-07-15 23:12 ` Martin Bark
2017-07-16 7:16 ` Thomas Petazzoni
0 siblings, 1 reply; 7+ messages in thread
From: Martin Bark @ 2017-07-15 23:12 UTC (permalink / raw)
To: buildroot
Thomas,
On 15 July 2017 at 20:44, Thomas Petazzoni <
thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Sat, 15 Jul 2017 18:38:27 +0100, Martin Bark wrote:
>
> > diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk
> > index 43c5ff3..a469153 100644
> > --- a/package/nodejs/nodejs.mk
> > +++ b/package/nodejs/nodejs.mk
> > @@ -34,6 +34,11 @@ else
> > NODEJS_CONF_OPTS += --with-intl=none
> > endif
> >
> > +ifeq ($(BR2_PACKAGE_C_ARES),y)
> > +NODEJS_DEPENDENCIES += c-ares
> > +NODEJS_CONF_OPTS += --shared-cares
> > +endif
>
> So what happens if BR2_PACKAGE_C_ARES is disabled? It is not
> needed/used by nodejs, or some internal/built-in version is used?
>
nodejs always uses c-ares, libuv and libhttpparser, it just uses it's own
versions by default (see https://github.com/nodejs/node/tree/master/deps).
Not setting any options will continue to use the build in versions.
Thanks
Martin
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170716/3b774bb9/attachment.html>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/3] package/nodejs: use shared c-ares if available
2017-07-15 23:12 ` Martin Bark
@ 2017-07-16 7:16 ` Thomas Petazzoni
2017-07-17 8:43 ` Martin Bark
0 siblings, 1 reply; 7+ messages in thread
From: Thomas Petazzoni @ 2017-07-16 7:16 UTC (permalink / raw)
To: buildroot
Hello,
On Sun, 16 Jul 2017 00:12:33 +0100, Martin Bark wrote:
> nodejs always uses c-ares, libuv and libhttpparser, it just uses it's own
> versions by default (see https://github.com/nodejs/node/tree/master/deps).
> Not setting any options will continue to use the build in versions.
Then in this case, we want nodejs to unconditionally select c-ares,
libuv and libhttpparser. Indeed, like most distributions, we prefer to
use the external libraries rather than the built-in ones.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/3] package/nodejs: use shared c-ares if available
2017-07-16 7:16 ` Thomas Petazzoni
@ 2017-07-17 8:43 ` Martin Bark
0 siblings, 0 replies; 7+ messages in thread
From: Martin Bark @ 2017-07-17 8:43 UTC (permalink / raw)
To: buildroot
Thomas,
On 16 July 2017 at 08:16, Thomas Petazzoni <
thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Sun, 16 Jul 2017 00:12:33 +0100, Martin Bark wrote:
>
> > nodejs always uses c-ares, libuv and libhttpparser, it just uses it's own
> > versions by default (see https://github.com/nodejs/node/tree/master/deps
> ).
> > Not setting any options will continue to use the build in versions.
>
> Then in this case, we want nodejs to unconditionally select c-ares,
> libuv and libhttpparser. Indeed, like most distributions, we prefer to
> use the external libraries rather than the built-in ones.
>
Sounds good, i prefer that approach. I'll resubmit the patches to
unconditionally select the libraries.
Thanks
Martin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170717/1379f39f/attachment.html>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-07-17 8:43 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-15 17:38 [Buildroot] [PATCH 1/3] package/nodejs: use shared c-ares if available Martin Bark
2017-07-15 17:38 ` [Buildroot] [PATCH 2/3] package/nodejs: use shared libhttpparser " Martin Bark
2017-07-15 17:38 ` [Buildroot] [PATCH 3/3] package/nodejs: use shared libuv " Martin Bark
2017-07-15 19:44 ` [Buildroot] [PATCH 1/3] package/nodejs: use shared c-ares " Thomas Petazzoni
2017-07-15 23:12 ` Martin Bark
2017-07-16 7:16 ` Thomas Petazzoni
2017-07-17 8:43 ` Martin Bark
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.