* [PATCH v2] clk: mediatek: fixed static checker warning in clk_cpumux_get_parent call
@ 2017-07-17 6:01 ` sean.wang
0 siblings, 0 replies; 3+ messages in thread
From: sean.wang @ 2017-07-17 6:01 UTC (permalink / raw)
To: sboyd, dan.carpenter, linux-mediatek, linux-clk; +Cc: linux-kernel, Sean Wang
From: Sean Wang <sean.wang@mediatek.com>
Fixed the signedness bug returning '(-22)' on the return type as u8 with
removing the sanity checker in clk_cpumux_get_parent() since
clk_cpumux_set_parent() always ensures validity in clk_cpumux_get_parent()
got called.
Fixes: commit 1e17de9049da ("clk: mediatek: add missing cpu mux causing Mediatek cpufreq can't work")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
---
drivers/clk/mediatek/clk-cpumux.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/clk/mediatek/clk-cpumux.c b/drivers/clk/mediatek/clk-cpumux.c
index edd8e69..347d799 100644
--- a/drivers/clk/mediatek/clk-cpumux.c
+++ b/drivers/clk/mediatek/clk-cpumux.c
@@ -27,7 +27,6 @@ static inline struct mtk_clk_cpumux *to_mtk_clk_cpumux(struct clk_hw *_hw)
static u8 clk_cpumux_get_parent(struct clk_hw *hw)
{
struct mtk_clk_cpumux *mux = to_mtk_clk_cpumux(hw);
- int num_parents = clk_hw_get_num_parents(hw);
unsigned int val;
regmap_read(mux->regmap, mux->reg, &val);
@@ -35,9 +34,6 @@ static u8 clk_cpumux_get_parent(struct clk_hw *hw)
val >>= mux->shift;
val &= mux->mask;
- if (val >= num_parents)
- return -EINVAL;
-
return val;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2] clk: mediatek: fixed static checker warning in clk_cpumux_get_parent call
@ 2017-07-17 6:01 ` sean.wang
0 siblings, 0 replies; 3+ messages in thread
From: sean.wang @ 2017-07-17 6:01 UTC (permalink / raw)
To: sboyd, dan.carpenter, linux-mediatek, linux-clk; +Cc: linux-kernel, Sean Wang
From: Sean Wang <sean.wang@mediatek.com>
Fixed the signedness bug returning '(-22)' on the return type as u8 with
removing the sanity checker in clk_cpumux_get_parent() since
clk_cpumux_set_parent() always ensures validity in clk_cpumux_get_parent()
got called.
Fixes: commit 1e17de9049da ("clk: mediatek: add missing cpu mux causing Mediatek cpufreq can't work")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
---
drivers/clk/mediatek/clk-cpumux.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/clk/mediatek/clk-cpumux.c b/drivers/clk/mediatek/clk-cpumux.c
index edd8e69..347d799 100644
--- a/drivers/clk/mediatek/clk-cpumux.c
+++ b/drivers/clk/mediatek/clk-cpumux.c
@@ -27,7 +27,6 @@ static inline struct mtk_clk_cpumux *to_mtk_clk_cpumux(struct clk_hw *_hw)
static u8 clk_cpumux_get_parent(struct clk_hw *hw)
{
struct mtk_clk_cpumux *mux = to_mtk_clk_cpumux(hw);
- int num_parents = clk_hw_get_num_parents(hw);
unsigned int val;
regmap_read(mux->regmap, mux->reg, &val);
@@ -35,9 +34,6 @@ static u8 clk_cpumux_get_parent(struct clk_hw *hw)
val >>= mux->shift;
val &= mux->mask;
- if (val >= num_parents)
- return -EINVAL;
-
return val;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] clk: mediatek: fixed static checker warning in clk_cpumux_get_parent call
2017-07-17 6:01 ` sean.wang
(?)
@ 2017-07-18 1:17 ` Stephen Boyd
-1 siblings, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2017-07-18 1:17 UTC (permalink / raw)
To: sean.wang; +Cc: dan.carpenter, linux-mediatek, linux-clk, linux-kernel
On 07/17, sean.wang@mediatek.com wrote:
> From: Sean Wang <sean.wang@mediatek.com>
>
> Fixed the signedness bug returning '(-22)' on the return type as u8 with
> removing the sanity checker in clk_cpumux_get_parent() since
> clk_cpumux_set_parent() always ensures validity in clk_cpumux_get_parent()
> got called.
>
> Fixes: commit 1e17de9049da ("clk: mediatek: add missing cpu mux causing Mediatek cpufreq can't work")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-18 1:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-17 6:01 [PATCH v2] clk: mediatek: fixed static checker warning in clk_cpumux_get_parent call sean.wang
2017-07-17 6:01 ` sean.wang
2017-07-18 1:17 ` Stephen Boyd
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.