* [PATCH][next] x86/hyper-v: add missing void return type to hyperv_cleanup declaration
@ 2017-07-19 9:08 Colin King
2017-07-19 15:23 ` Haiyang Zhang
2017-07-20 8:52 ` Ingo Molnar
0 siblings, 2 replies; 8+ messages in thread
From: Colin King @ 2017-07-19 9:08 UTC (permalink / raw)
To: kernel-janitors
From: Colin Ian King <colin.king@canonical.com>
Add in missing void return type, fixes sparse warning:
"warning: 'hyperv_cleanup()' has implicit return type"
Fixes: 2e252fbf777d ("x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
arch/x86/include/asm/mshyperv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h
index 01b9c0fb3aab..41fae263f8fa 100644
--- a/arch/x86/include/asm/mshyperv.h
+++ b/arch/x86/include/asm/mshyperv.h
@@ -178,7 +178,7 @@ void hyperv_cleanup(void);
#else /* CONFIG_HYPERV */
static inline void hyperv_init(void) {}
static inline bool hv_is_hypercall_page_setup(void) { return false; }
-static inline hyperv_cleanup(void) {}
+static inline void hyperv_cleanup(void) {}
#endif /* CONFIG_HYPERV */
#ifdef CONFIG_HYPERV_TSCPAGE
--
2.11.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* RE: [PATCH][next] x86/hyper-v: add missing void return type to hyperv_cleanup declaration
2017-07-19 9:08 [PATCH][next] x86/hyper-v: add missing void return type to hyperv_cleanup declaration Colin King
@ 2017-07-19 15:23 ` Haiyang Zhang
2017-07-20 8:52 ` Ingo Molnar
1 sibling, 0 replies; 8+ messages in thread
From: Haiyang Zhang @ 2017-07-19 15:23 UTC (permalink / raw)
To: kernel-janitors
DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogQ29saW4gS2luZyBbbWFp
bHRvOmNvbGluLmtpbmdAY2Fub25pY2FsLmNvbV0NCj4gU2VudDogV2VkbmVzZGF5LCBKdWx5IDE5
LCAyMDE3IDU6MDkgQU0NCj4gVG86IFZpdGFseSBLdXpuZXRzb3YgPHZrdXpuZXRzQHJlZGhhdC5j
b20+OyBLWSBTcmluaXZhc2FuDQo+IDxreXNAbWljcm9zb2Z0LmNvbT47IEhhaXlhbmcgWmhhbmcg
PGhhaXlhbmd6QG1pY3Jvc29mdC5jb20+OyBTdGVwaGVuDQo+IEhlbW1pbmdlciA8c3RoZW1taW5A
bWljcm9zb2Z0LmNvbT47IFRob21hcyBHbGVpeG5lciA8dGdseEBsaW51dHJvbml4LmRlPjsNCj4g
SW5nbyBNb2xuYXIgPG1pbmdvQHJlZGhhdC5jb20+OyBIIC4gUGV0ZXIgQW52aW4gPGhwYUB6eXRv
ci5jb20+Ow0KPiB4ODZAa2VybmVsLm9yZw0KPiBDYzoga2VybmVsLWphbml0b3JzQHZnZXIua2Vy
bmVsLm9yZw0KPiBTdWJqZWN0OiBbUEFUQ0hdW25leHRdIHg4Ni9oeXBlci12OiBhZGQgbWlzc2lu
ZyB2b2lkIHJldHVybiB0eXBlIHRvDQo+IGh5cGVydl9jbGVhbnVwIGRlY2xhcmF0aW9uDQo+IA0K
PiBGcm9tOiBDb2xpbiBJYW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29tPg0KPiANCj4g
QWRkIGluIG1pc3Npbmcgdm9pZCByZXR1cm4gdHlwZSwgZml4ZXMgc3BhcnNlIHdhcm5pbmc6DQo+
ICJ3YXJuaW5nOiAnaHlwZXJ2X2NsZWFudXAoKScgaGFzIGltcGxpY2l0IHJldHVybiB0eXBlIg0K
PiANCj4gRml4ZXM6IDJlMjUyZmJmNzc3ZCAoIng4Ni9oeXBlci12OiBpbmNsdWRlIGh5cGVydi8g
b25seSB3aGVuDQo+IENPTkZJR19IWVBFUlYgaXMgc2V0IikNCj4gU2lnbmVkLW9mZi1ieTogQ29s
aW4gSWFuIEtpbmcgPGNvbGluLmtpbmdAY2Fub25pY2FsLmNvbT4NCg0KUmV2aWV3ZWQtYnk6IEhh
aXlhbmcgWmhhbmcgPGhhaXlhbmd6QG1pY3Jvc29mdC5jb20+DQoNClRoYW5rcy4NCg0KDQo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH][next] x86/hyper-v: add missing void return type to hyperv_cleanup declaration
2017-07-19 9:08 [PATCH][next] x86/hyper-v: add missing void return type to hyperv_cleanup declaration Colin King
@ 2017-07-20 8:52 ` Ingo Molnar
2017-07-20 8:52 ` Ingo Molnar
1 sibling, 0 replies; 8+ messages in thread
From: Ingo Molnar @ 2017-07-20 8:52 UTC (permalink / raw)
To: Colin King, Greg Kroah-Hartman
Cc: Vitaly Kuznetsov, K . Y . Srinivasan, Haiyang Zhang,
Stephen Hemminger, Thomas Gleixner, Ingo Molnar, H . Peter Anvin,
x86, kernel-janitors, linux-kernel
* Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add in missing void return type, fixes sparse warning:
> "warning: 'hyperv_cleanup()' has implicit return type"
>
> Fixes: 2e252fbf777d ("x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> arch/x86/include/asm/mshyperv.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h
> index 01b9c0fb3aab..41fae263f8fa 100644
> --- a/arch/x86/include/asm/mshyperv.h
> +++ b/arch/x86/include/asm/mshyperv.h
> @@ -178,7 +178,7 @@ void hyperv_cleanup(void);
> #else /* CONFIG_HYPERV */
> static inline void hyperv_init(void) {}
> static inline bool hv_is_hypercall_page_setup(void) { return false; }
> -static inline hyperv_cleanup(void) {}
> +static inline void hyperv_cleanup(void) {}
> #endif /* CONFIG_HYPERV */
Guys, Greg, could we please move this commit from the drivers tree:
2e252fbf777d: x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set
arch/x86/Kbuild | 2 +-
arch/x86/include/asm/mshyperv.h | 7 ++++++-
... to the x86 tree where it belongs?
Thanks,
Ingo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH][next] x86/hyper-v: add missing void return type to hyperv_cleanup declaration
@ 2017-07-20 8:52 ` Ingo Molnar
0 siblings, 0 replies; 8+ messages in thread
From: Ingo Molnar @ 2017-07-20 8:52 UTC (permalink / raw)
To: Colin King, Greg Kroah-Hartman
Cc: Vitaly Kuznetsov, K . Y . Srinivasan, Haiyang Zhang,
Stephen Hemminger, Thomas Gleixner, Ingo Molnar, H . Peter Anvin,
x86, kernel-janitors, linux-kernel
* Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add in missing void return type, fixes sparse warning:
> "warning: 'hyperv_cleanup()' has implicit return type"
>
> Fixes: 2e252fbf777d ("x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> arch/x86/include/asm/mshyperv.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h
> index 01b9c0fb3aab..41fae263f8fa 100644
> --- a/arch/x86/include/asm/mshyperv.h
> +++ b/arch/x86/include/asm/mshyperv.h
> @@ -178,7 +178,7 @@ void hyperv_cleanup(void);
> #else /* CONFIG_HYPERV */
> static inline void hyperv_init(void) {}
> static inline bool hv_is_hypercall_page_setup(void) { return false; }
> -static inline hyperv_cleanup(void) {}
> +static inline void hyperv_cleanup(void) {}
> #endif /* CONFIG_HYPERV */
Guys, Greg, could we please move this commit from the drivers tree:
2e252fbf777d: x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set
arch/x86/Kbuild | 2 +-
arch/x86/include/asm/mshyperv.h | 7 ++++++-
... to the x86 tree where it belongs?
Thanks,
Ingo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH][next] x86/hyper-v: add missing void return type to hyperv_cleanup declaration
2017-07-20 8:52 ` Ingo Molnar
@ 2017-07-20 9:15 ` Greg Kroah-Hartman
-1 siblings, 0 replies; 8+ messages in thread
From: Greg Kroah-Hartman @ 2017-07-20 9:15 UTC (permalink / raw)
To: Ingo Molnar
Cc: Colin King, Vitaly Kuznetsov, K . Y . Srinivasan, Haiyang Zhang,
Stephen Hemminger, Thomas Gleixner, Ingo Molnar, H . Peter Anvin,
x86, kernel-janitors, linux-kernel
On Thu, Jul 20, 2017 at 10:52:36AM +0200, Ingo Molnar wrote:
>
> * Colin King <colin.king@canonical.com> wrote:
>
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Add in missing void return type, fixes sparse warning:
> > "warning: 'hyperv_cleanup()' has implicit return type"
> >
> > Fixes: 2e252fbf777d ("x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > arch/x86/include/asm/mshyperv.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h
> > index 01b9c0fb3aab..41fae263f8fa 100644
> > --- a/arch/x86/include/asm/mshyperv.h
> > +++ b/arch/x86/include/asm/mshyperv.h
> > @@ -178,7 +178,7 @@ void hyperv_cleanup(void);
> > #else /* CONFIG_HYPERV */
> > static inline void hyperv_init(void) {}
> > static inline bool hv_is_hypercall_page_setup(void) { return false; }
> > -static inline hyperv_cleanup(void) {}
> > +static inline void hyperv_cleanup(void) {}
> > #endif /* CONFIG_HYPERV */
>
> Guys, Greg, could we please move this commit from the drivers tree:
>
> 2e252fbf777d: x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set
>
> arch/x86/Kbuild | 2 +-
> arch/x86/include/asm/mshyperv.h | 7 ++++++-
>
> ... to the x86 tree where it belongs?
I've now reverted it from my tree entirely, sorry about that.
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH][next] x86/hyper-v: add missing void return type to hyperv_cleanup declaration
@ 2017-07-20 9:15 ` Greg Kroah-Hartman
0 siblings, 0 replies; 8+ messages in thread
From: Greg Kroah-Hartman @ 2017-07-20 9:15 UTC (permalink / raw)
To: Ingo Molnar
Cc: Colin King, Vitaly Kuznetsov, K . Y . Srinivasan, Haiyang Zhang,
Stephen Hemminger, Thomas Gleixner, Ingo Molnar, H . Peter Anvin,
x86, kernel-janitors, linux-kernel
On Thu, Jul 20, 2017 at 10:52:36AM +0200, Ingo Molnar wrote:
>
> * Colin King <colin.king@canonical.com> wrote:
>
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Add in missing void return type, fixes sparse warning:
> > "warning: 'hyperv_cleanup()' has implicit return type"
> >
> > Fixes: 2e252fbf777d ("x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > arch/x86/include/asm/mshyperv.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h
> > index 01b9c0fb3aab..41fae263f8fa 100644
> > --- a/arch/x86/include/asm/mshyperv.h
> > +++ b/arch/x86/include/asm/mshyperv.h
> > @@ -178,7 +178,7 @@ void hyperv_cleanup(void);
> > #else /* CONFIG_HYPERV */
> > static inline void hyperv_init(void) {}
> > static inline bool hv_is_hypercall_page_setup(void) { return false; }
> > -static inline hyperv_cleanup(void) {}
> > +static inline void hyperv_cleanup(void) {}
> > #endif /* CONFIG_HYPERV */
>
> Guys, Greg, could we please move this commit from the drivers tree:
>
> 2e252fbf777d: x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set
>
> arch/x86/Kbuild | 2 +-
> arch/x86/include/asm/mshyperv.h | 7 ++++++-
>
> ... to the x86 tree where it belongs?
I've now reverted it from my tree entirely, sorry about that.
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH][next] x86/hyper-v: add missing void return type to hyperv_cleanup declaration
2017-07-20 9:15 ` Greg Kroah-Hartman
@ 2017-07-20 9:42 ` Ingo Molnar
-1 siblings, 0 replies; 8+ messages in thread
From: Ingo Molnar @ 2017-07-20 9:42 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Colin King, Vitaly Kuznetsov, K . Y . Srinivasan, Haiyang Zhang,
Stephen Hemminger, Thomas Gleixner, Ingo Molnar, H . Peter Anvin,
x86, kernel-janitors, linux-kernel
* Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> On Thu, Jul 20, 2017 at 10:52:36AM +0200, Ingo Molnar wrote:
> >
> > * Colin King <colin.king@canonical.com> wrote:
> >
> > > From: Colin Ian King <colin.king@canonical.com>
> > >
> > > Add in missing void return type, fixes sparse warning:
> > > "warning: 'hyperv_cleanup()' has implicit return type"
> > >
> > > Fixes: 2e252fbf777d ("x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set")
> > > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > > ---
> > > arch/x86/include/asm/mshyperv.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h
> > > index 01b9c0fb3aab..41fae263f8fa 100644
> > > --- a/arch/x86/include/asm/mshyperv.h
> > > +++ b/arch/x86/include/asm/mshyperv.h
> > > @@ -178,7 +178,7 @@ void hyperv_cleanup(void);
> > > #else /* CONFIG_HYPERV */
> > > static inline void hyperv_init(void) {}
> > > static inline bool hv_is_hypercall_page_setup(void) { return false; }
> > > -static inline hyperv_cleanup(void) {}
> > > +static inline void hyperv_cleanup(void) {}
> > > #endif /* CONFIG_HYPERV */
> >
> > Guys, Greg, could we please move this commit from the drivers tree:
> >
> > 2e252fbf777d: x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set
> >
> > arch/x86/Kbuild | 2 +-
> > arch/x86/include/asm/mshyperv.h | 7 ++++++-
> >
> > ... to the x86 tree where it belongs?
>
> I've now reverted it from my tree entirely, sorry about that.
No problem - I'll pick up the fixed v2 version when it's posted.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH][next] x86/hyper-v: add missing void return type to hyperv_cleanup declaration
@ 2017-07-20 9:42 ` Ingo Molnar
0 siblings, 0 replies; 8+ messages in thread
From: Ingo Molnar @ 2017-07-20 9:42 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Colin King, Vitaly Kuznetsov, K . Y . Srinivasan, Haiyang Zhang,
Stephen Hemminger, Thomas Gleixner, Ingo Molnar, H . Peter Anvin,
x86, kernel-janitors, linux-kernel
* Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> On Thu, Jul 20, 2017 at 10:52:36AM +0200, Ingo Molnar wrote:
> >
> > * Colin King <colin.king@canonical.com> wrote:
> >
> > > From: Colin Ian King <colin.king@canonical.com>
> > >
> > > Add in missing void return type, fixes sparse warning:
> > > "warning: 'hyperv_cleanup()' has implicit return type"
> > >
> > > Fixes: 2e252fbf777d ("x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set")
> > > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > > ---
> > > arch/x86/include/asm/mshyperv.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h
> > > index 01b9c0fb3aab..41fae263f8fa 100644
> > > --- a/arch/x86/include/asm/mshyperv.h
> > > +++ b/arch/x86/include/asm/mshyperv.h
> > > @@ -178,7 +178,7 @@ void hyperv_cleanup(void);
> > > #else /* CONFIG_HYPERV */
> > > static inline void hyperv_init(void) {}
> > > static inline bool hv_is_hypercall_page_setup(void) { return false; }
> > > -static inline hyperv_cleanup(void) {}
> > > +static inline void hyperv_cleanup(void) {}
> > > #endif /* CONFIG_HYPERV */
> >
> > Guys, Greg, could we please move this commit from the drivers tree:
> >
> > 2e252fbf777d: x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set
> >
> > arch/x86/Kbuild | 2 +-
> > arch/x86/include/asm/mshyperv.h | 7 ++++++-
> >
> > ... to the x86 tree where it belongs?
>
> I've now reverted it from my tree entirely, sorry about that.
No problem - I'll pick up the fixed v2 version when it's posted.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-07-20 9:42 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-19 9:08 [PATCH][next] x86/hyper-v: add missing void return type to hyperv_cleanup declaration Colin King
2017-07-19 15:23 ` Haiyang Zhang
2017-07-20 8:52 ` Ingo Molnar
2017-07-20 8:52 ` Ingo Molnar
2017-07-20 9:15 ` Greg Kroah-Hartman
2017-07-20 9:15 ` Greg Kroah-Hartman
2017-07-20 9:42 ` Ingo Molnar
2017-07-20 9:42 ` Ingo Molnar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.