[PATCH] drm/i915: Don't set fence errors on non-guilty requests

[PATCH] drm/i915: Don't set fence errors on non-guilty requests

[Daniel Vetter]

... at least not in that place, because this can also fire for
requests which have completed. Which then hits the assert in
dma_fence_set_error.

Since I'm not really clear what should be done here I pinged Chris,
and he suggested we simply remove this for now.

Found while stress-testing gpu reset using kms_busy, with about 0-3
hits of it per complete run on my snb here.

Testcase: igt/kms_busy.
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 drivers/gpu/drm/i915/i915_gem.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 1a8842f143fc..1c7453e2cc45 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -2955,7 +2955,6 @@ static bool i915_gem_reset_request(struct drm_i915_gem_request *request)
 		skip_request(request);
 	} else {
 		i915_gem_context_mark_innocent(request->ctx);
-		dma_fence_set_error(&request->fence, -EAGAIN);
 	}
 
 	return guilty;
-- 
2.13.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Don't set fence errors on non-guilty requests

[Daniel Vetter]

Oops, sent out the wrong patch, pls disregard.
-Daniel

On Thu, Jul 20, 2017 at 10:14 PM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> ... at least not in that place, because this can also fire for
> requests which have completed. Which then hits the assert in
> dma_fence_set_error.
>
> Since I'm not really clear what should be done here I pinged Chris,
> and he suggested we simply remove this for now.
>
> Found while stress-testing gpu reset using kms_busy, with about 0-3
> hits of it per complete run on my snb here.
>
> Testcase: igt/kms_busy.
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_gem.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index 1a8842f143fc..1c7453e2cc45 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -2955,7 +2955,6 @@ static bool i915_gem_reset_request(struct drm_i915_gem_request *request)
>                 skip_request(request);
>         } else {
>                 i915_gem_context_mark_innocent(request->ctx);
> -               dma_fence_set_error(&request->fence, -EAGAIN);
>         }
>
>         return guilty;
> --
> 2.13.2
>



-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for drm/i915: Don't set fence errors on non-guilty requests (rev2)

[Patchwork]

== Series Details ==

Series: drm/i915: Don't set fence errors on non-guilty requests (rev2)
URL   : https://patchwork.freedesktop.org/series/27665/
State : success

== Summary ==

Series 27665v2 drm/i915: Don't set fence errors on non-guilty requests
https://patchwork.freedesktop.org/api/1.0/series/27665/revisions/2/mbox/

Test kms_cursor_legacy:
        Subgroup basic-busy-flip-before-cursor-atomic:
                fail       -> PASS       (fi-snb-2600) fdo#100215
Test kms_pipe_crc_basic:
        Subgroup hang-read-crc-pipe-a:
                pass       -> DMESG-WARN (fi-pnv-d510) fdo#101597

fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215
fdo#101597 https://bugs.freedesktop.org/show_bug.cgi?id=101597

fi-bdw-5557u     total:279  pass:268  dwarn:0   dfail:0   fail:0   skip:11  time:442s
fi-bdw-gvtdvm    total:279  pass:265  dwarn:0   dfail:0   fail:0   skip:14  time:430s
fi-blb-e6850     total:279  pass:224  dwarn:1   dfail:0   fail:0   skip:54  time:355s
fi-bsw-n3050     total:279  pass:243  dwarn:0   dfail:0   fail:0   skip:36  time:535s
fi-bxt-j4205     total:279  pass:260  dwarn:0   dfail:0   fail:0   skip:19  time:508s
fi-byt-j1900     total:279  pass:255  dwarn:0   dfail:0   fail:0   skip:24  time:497s
fi-byt-n2820     total:279  pass:250  dwarn:1   dfail:0   fail:0   skip:28  time:490s
fi-glk-2a        total:279  pass:260  dwarn:0   dfail:0   fail:0   skip:19  time:602s
fi-hsw-4770      total:279  pass:263  dwarn:0   dfail:0   fail:0   skip:16  time:437s
fi-hsw-4770r     total:279  pass:263  dwarn:0   dfail:0   fail:0   skip:16  time:423s
fi-ilk-650       total:279  pass:229  dwarn:0   dfail:0   fail:0   skip:50  time:413s
fi-ivb-3520m     total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:503s
fi-ivb-3770      total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:472s
fi-kbl-7500u     total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:478s
fi-kbl-7560u     total:279  pass:269  dwarn:0   dfail:0   fail:0   skip:10  time:576s
fi-kbl-r         total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:595s
fi-pnv-d510      total:279  pass:221  dwarn:3   dfail:0   fail:0   skip:55  time:572s
fi-skl-6260u     total:279  pass:269  dwarn:0   dfail:0   fail:0   skip:10  time:461s
fi-skl-6700hq    total:279  pass:262  dwarn:0   dfail:0   fail:0   skip:17  time:589s
fi-skl-6700k     total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:469s
fi-skl-6770hq    total:279  pass:269  dwarn:0   dfail:0   fail:0   skip:10  time:475s
fi-skl-gvtdvm    total:279  pass:266  dwarn:0   dfail:0   fail:0   skip:13  time:439s
fi-skl-x1585l    total:279  pass:268  dwarn:0   dfail:0   fail:0   skip:11  time:471s
fi-snb-2520m     total:279  pass:251  dwarn:0   dfail:0   fail:0   skip:28  time:544s
fi-snb-2600      total:279  pass:250  dwarn:0   dfail:0   fail:0   skip:29  time:408s

07fe547642181ced02ac75bbf748cbb7ddd367b9 drm-tip: 2017y-07m-20d-18h-40m-36s UTC integration manifest
6f6300b drm/i915: Don't set fence errors on non-guilty requests

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5256/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH] drm/i915: Don't set fence errors on non-guilty requests

[Daniel Vetter]

... at least not in that place, because this can also fire for
requests which have completed. Which then hits the assert in
dma_fence_set_error.

Since I'm not really clear what should be done here I pinged Chris,
and he suggested we simply remove this for now.

Found while stress-testing gpu reset using kms_busy, with about 0-3
hits of it per complete run on my snb here.

Testcase: igt/kms_busy.
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 drivers/gpu/drm/i915/i915_gem.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 1a8842f143fc..1c7453e2cc45 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -2955,7 +2955,6 @@ static bool i915_gem_reset_request(struct drm_i915_gem_request *request)
 		skip_request(request);
 	} else {
 		i915_gem_context_mark_innocent(request->ctx);
-		dma_fence_set_error(&request->fence, -EAGAIN);
 	}
 
 	return guilty;
-- 
2.13.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Don't set fence errors on non-guilty requests

[Chris Wilson]

Quoting Daniel Vetter (2017-07-20 18:59:01)
> ... at least not in that place, because this can also fire for
> requests which have completed. Which then hits the assert in
> dma_fence_set_error.
> 
> Since I'm not really clear what should be done here I pinged Chris,
> and he suggested we simply remove this for now.

My idea was the patch this morning to shuffle engine_stalled around as
we are no longer getting here for innocent engines.
https://patchwork.freedesktop.org/patch/168056/
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx