[PATCH] of: irq: fix of_irq_to_resource() error check

[PATCH] of: irq: fix of_irq_to_resource() error check

[Sergei Shtylyov]

[-- Attachment #1: of-irq-fix-of_irq_to_resource-error-check.patch --]
[-- Type: text/plain, Size: 1105 bytes --]

of_irq_to_resource() has recently been fixed to return negative error #'s
along with 0, however of_irq_to_resource_table() still only regards 0 as
invalid IRQ -- fix it up.

Fixes: 7a4228bbff76 ("of: irq: use of_irq_get() in of_irq_to_resource()")
Signed-off-by: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>

---
The patch is against the 'dt/linus' branch of Rob Herring's 'linux.git' repo.

 drivers/of/irq.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux/drivers/of/irq.c
===================================================================
--- linux.orig/drivers/of/irq.c
+++ linux/drivers/of/irq.c
@@ -476,7 +476,7 @@ int of_irq_to_resource_table(struct devi
 	int i;
 
 	for (i = 0; i < nr_irqs; i++, res++)
-		if (!of_irq_to_resource(dev, i, res))
+		if (of_irq_to_resource(dev, i, res) <= 0)
 			break;
 
 	return i;

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] of: irq: fix of_irq_to_resource() error check

[Rob Herring]

On Fri, Jul 21, 2017 at 08:30:39PM +0300, Sergei Shtylyov wrote:
> of_irq_to_resource() has recently been fixed to return negative error #'s
> along with 0, however of_irq_to_resource_table() still only regards 0 as
> invalid IRQ -- fix it up.
> 
> Fixes: 7a4228bbff76 ("of: irq: use of_irq_get() in of_irq_to_resource()")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
> 
> ---
> The patch is against the 'dt/linus' branch of Rob Herring's 'linux.git' repo.
> 
>  drivers/of/irq.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied.

BTW, all the users of of_irq_to_resource_table outside of the DT 
platform code are erroneous IMO. Either the resources are already 
available when probing or only a single resource is retrieved. These may 
have been working around a problem that some resources couldn't be 
resolved at device creation time which is now fixed.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html