All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Brown <matthew.brown.dev@gmail.com>
To: linuxppc-dev@lists.ozlabs.org
Subject: [PATCH v3 1/5] powerpc/lib/sstep: Add cmpb instruction emulation
Date: Tue, 25 Jul 2017 13:33:16 +1000	[thread overview]
Message-ID: <20170725033320.17893-1-matthew.brown.dev@gmail.com> (raw)

This patch adds emulation of the cmpb instruction, enabling xmon to
emulate this instruction.
Tested for correctness against the cmpb asm instruction on ppc64le.

Signed-off-by: Matt Brown <matthew.brown.dev@gmail.com>
---
v2: 
	- fixed opcode
	- fixed mask typecasting
---
 arch/powerpc/lib/sstep.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/arch/powerpc/lib/sstep.c b/arch/powerpc/lib/sstep.c
index 33117f8..87d277f 100644
--- a/arch/powerpc/lib/sstep.c
+++ b/arch/powerpc/lib/sstep.c
@@ -596,6 +596,22 @@ static nokprobe_inline void do_cmp_unsigned(struct pt_regs *regs, unsigned long
 	regs->ccr = (regs->ccr & ~(0xf << shift)) | (crval << shift);
 }
 
+static nokprobe_inline void do_cmpb(struct pt_regs *regs, unsigned long v1,
+				unsigned long v2, int rd)
+{
+	unsigned long long out_val, mask;
+	int i;
+
+	out_val = 0;
+	for (i = 0; i < 8; i++) {
+		mask = 0xffUL << (i * 8);
+		if ((v1 & mask) == (v2 & mask))
+			out_val |= mask;
+	}
+
+	regs->gpr[rd] = out_val;
+}
+
 static nokprobe_inline int trap_compare(long v1, long v2)
 {
 	int ret = 0;
@@ -1049,6 +1065,10 @@ int analyse_instr(struct instruction_op *op, struct pt_regs *regs,
 			do_cmp_unsigned(regs, val, val2, rd >> 2);
 			goto instr_done;
 
+		case 508: /* cmpb */
+			do_cmpb(regs, regs->gpr[rd], regs->gpr[rb], ra);
+			goto instr_done;
+
 /*
  * Arithmetic instructions
  */
-- 
2.9.3

             reply	other threads:[~2017-07-25  3:33 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-25  3:33 Matt Brown [this message]
2017-07-25  3:33 ` [PATCH v3 2/5] powerpc/lib/sstep: Add popcnt instruction emulation Matt Brown
2017-07-25  7:12   ` Balbir Singh
2017-07-25 10:24   ` David Laight
2017-07-25 13:32     ` Balbir Singh
2017-07-26  7:29   ` Gabriel Paubert
2017-07-25  3:33 ` [PATCH v3 3/5] powerpc/lib/sstep: Add bpermd " Matt Brown
2017-07-25  3:33 ` [PATCH v3 4/5] powerpc/lib/sstep: Add prty " Matt Brown
2017-07-25  8:08   ` Balbir Singh
2017-07-26  7:49     ` Gabriel Paubert
2017-07-25 15:30   ` Segher Boessenkool
2017-07-26 10:03     ` Michael Ellerman
2017-07-26 16:02       ` Segher Boessenkool
2017-07-27  1:26         ` Michael Ellerman
2017-07-28  0:48           ` Matt Brown
2017-07-28  1:31             ` Michael Ellerman
2017-07-25  3:33 ` [PATCH v3 5/5] powerpc/lib/sstep: Add isel " Matt Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170725033320.17893-1-matthew.brown.dev@gmail.com \
    --to=matthew.brown.dev@gmail.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.