All of lore.kernel.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Matt Brown <matthew.brown.dev@gmail.com>, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v3 4/5] powerpc/lib/sstep: Add prty instruction emulation
Date: Wed, 26 Jul 2017 11:02:56 -0500	[thread overview]
Message-ID: <20170726160255.GO13471@gate.crashing.org> (raw)
In-Reply-To: <87tw1z5xcd.fsf@concordia.ellerman.id.au>

On Wed, Jul 26, 2017 at 08:03:30PM +1000, Michael Ellerman wrote:
> Segher Boessenkool <segher@kernel.crashing.org> writes:
> > A general question about these patches: some things are inside #ifdef
> > __powerpc64__, some are not.  It seems it is the wrong macro, and it
> > should be used (or not used) consistently?
> 
> Why is it the wrong macro? Because we tend to use CONFIG_PPC64 you mean?

Yeah.  But I see sstep.c already mixes those two at will (or if there
is a distinction, I'm not seeing it :-) )

> I thought the reason some are #ifdef'ed is that some are 64-bit only.
> ie. bpermd is 64-bit only ?

64-bit only, in what way?  It's not clear what the rules are.

It's not instructions that can only run in 64-bit mode.
It's not instructions that only give a usable result with 64-bit regs
implemented.
It's not instructions only implemented on 64-bit CPUs.
It's not even "all instructions that would not give a correct result
in the low 32 bits of GPRs if the high 32 bits are not implemented".


Segher

  reply	other threads:[~2017-07-26 16:03 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-25  3:33 [PATCH v3 1/5] powerpc/lib/sstep: Add cmpb instruction emulation Matt Brown
2017-07-25  3:33 ` [PATCH v3 2/5] powerpc/lib/sstep: Add popcnt " Matt Brown
2017-07-25  7:12   ` Balbir Singh
2017-07-25 10:24   ` David Laight
2017-07-25 13:32     ` Balbir Singh
2017-07-26  7:29   ` Gabriel Paubert
2017-07-25  3:33 ` [PATCH v3 3/5] powerpc/lib/sstep: Add bpermd " Matt Brown
2017-07-25  3:33 ` [PATCH v3 4/5] powerpc/lib/sstep: Add prty " Matt Brown
2017-07-25  8:08   ` Balbir Singh
2017-07-26  7:49     ` Gabriel Paubert
2017-07-25 15:30   ` Segher Boessenkool
2017-07-26 10:03     ` Michael Ellerman
2017-07-26 16:02       ` Segher Boessenkool [this message]
2017-07-27  1:26         ` Michael Ellerman
2017-07-28  0:48           ` Matt Brown
2017-07-28  1:31             ` Michael Ellerman
2017-07-25  3:33 ` [PATCH v3 5/5] powerpc/lib/sstep: Add isel " Matt Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170726160255.GO13471@gate.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=matthew.brown.dev@gmail.com \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.