From: Krzysztof Kozlowski <krzk@kernel.org> To: Arvind Yadav <arvind.yadav.cs@gmail.com> Cc: perex@perex.cz, tiwai@suse.com, broonie@kernel.org, sbkim73@samsung.com, lgirdwood@gmail.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/11] ASoC: samsung: s3c2412: Handle return value of clk_prepare_enable. Date: Tue, 25 Jul 2017 19:43:53 +0200 [thread overview] Message-ID: <20170725174353.GA8243@kozik-book> (raw) In-Reply-To: <1500977674-27960-2-git-send-email-arvind.yadav.cs@gmail.com> On Tue, Jul 25, 2017 at 03:44:28PM +0530, Arvind Yadav wrote: > clk_prepare_enable() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > --- > sound/soc/samsung/s3c2412-i2s.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/samsung/s3c2412-i2s.c b/sound/soc/samsung/s3c2412-i2s.c > index 0a47182..bcd1cbd 100644 > --- a/sound/soc/samsung/s3c2412-i2s.c > +++ b/sound/soc/samsung/s3c2412-i2s.c > @@ -71,7 +71,9 @@ static int s3c2412_i2s_probe(struct snd_soc_dai *dai) > /* Set MPLL as the source for IIS CLK */ > > clk_set_parent(s3c2412_i2s.iis_cclk, clk_get(NULL, "mpll")); > - clk_prepare_enable(s3c2412_i2s.iis_cclk); > + ret = clk_prepare_enable(s3c2412_i2s.iis_cclk); > + if (ret) You miss here path for error handling for things done in s3c_i2sv2_probe(). Best regards, Krzysztof > + return ret; > > s3c2412_i2s.iis_cclk = s3c2412_i2s.iis_pclk; > > -- > 1.9.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org> To: Arvind Yadav <arvind.yadav.cs@gmail.com> Cc: alsa-devel@alsa-project.org, sbkim73@samsung.com, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, tiwai@suse.com, broonie@kernel.org Subject: Re: [PATCH 01/11] ASoC: samsung: s3c2412: Handle return value of clk_prepare_enable. Date: Tue, 25 Jul 2017 19:43:53 +0200 [thread overview] Message-ID: <20170725174353.GA8243@kozik-book> (raw) In-Reply-To: <1500977674-27960-2-git-send-email-arvind.yadav.cs@gmail.com> On Tue, Jul 25, 2017 at 03:44:28PM +0530, Arvind Yadav wrote: > clk_prepare_enable() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > --- > sound/soc/samsung/s3c2412-i2s.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/samsung/s3c2412-i2s.c b/sound/soc/samsung/s3c2412-i2s.c > index 0a47182..bcd1cbd 100644 > --- a/sound/soc/samsung/s3c2412-i2s.c > +++ b/sound/soc/samsung/s3c2412-i2s.c > @@ -71,7 +71,9 @@ static int s3c2412_i2s_probe(struct snd_soc_dai *dai) > /* Set MPLL as the source for IIS CLK */ > > clk_set_parent(s3c2412_i2s.iis_cclk, clk_get(NULL, "mpll")); > - clk_prepare_enable(s3c2412_i2s.iis_cclk); > + ret = clk_prepare_enable(s3c2412_i2s.iis_cclk); > + if (ret) You miss here path for error handling for things done in s3c_i2sv2_probe(). Best regards, Krzysztof > + return ret; > > s3c2412_i2s.iis_cclk = s3c2412_i2s.iis_pclk; > > -- > 1.9.1 >
next prev parent reply other threads:[~2017-07-25 17:44 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-07-25 10:14 [PATCH 00/11] Handle return value of clk_prepare_enable Arvind Yadav 2017-07-25 10:14 ` [PATCH 01/11] ASoC: samsung: s3c2412: " Arvind Yadav 2017-07-25 17:43 ` Krzysztof Kozlowski [this message] 2017-07-25 17:43 ` Krzysztof Kozlowski 2017-07-26 14:17 ` Applied "ASoC: samsung: s3c2412: Handle return value of clk_prepare_enable." to the asoc tree Mark Brown 2017-07-26 14:17 ` Mark Brown 2017-07-26 15:46 ` Krzysztof Kozlowski 2017-07-26 16:07 ` Mark Brown 2017-07-26 16:13 ` Krzysztof Kozlowski 2017-07-25 10:14 ` [PATCH 02/11] ASoC: samsung: s3c24xx: Handle return value of clk_prepare_enable Arvind Yadav 2017-07-25 17:50 ` Krzysztof Kozlowski 2017-07-25 17:50 ` Krzysztof Kozlowski 2017-07-26 14:17 ` Applied "ASoC: samsung: s3c24xx: Handle return value of clk_prepare_enable." to the asoc tree Mark Brown 2017-07-26 14:17 ` Mark Brown 2017-07-25 10:14 ` [PATCH 03/11] ASoC: samsung: pcm: Handle return value of clk_prepare_enable Arvind Yadav 2017-07-25 17:51 ` Krzysztof Kozlowski 2017-07-26 14:17 ` Applied "ASoC: samsung: pcm: Handle return value of clk_prepare_enable." to the asoc tree Mark Brown 2017-07-26 14:17 ` Mark Brown 2017-07-25 10:14 ` [PATCH 04/11] ASoC: samsung: i2s: Handle return value of clk_prepare_enable Arvind Yadav 2017-07-25 17:58 ` Krzysztof Kozlowski 2017-07-25 17:58 ` Krzysztof Kozlowski 2017-07-26 14:17 ` Applied "ASoC: samsung: i2s: Handle return value of clk_prepare_enable." to the asoc tree Mark Brown 2017-07-26 14:17 ` Mark Brown 2017-07-25 10:14 ` [PATCH 05/11] ASoC: samsung: spdif: Handle return value of clk_prepare_enable Arvind Yadav 2017-07-25 18:01 ` Krzysztof Kozlowski 2017-07-25 18:01 ` Krzysztof Kozlowski 2017-07-26 14:17 ` Applied "ASoC: samsung: spdif: Handle return value of clk_prepare_enable." to the asoc tree Mark Brown 2017-07-26 14:17 ` Mark Brown 2017-07-25 10:14 ` [PATCH 06/11] ASoC: mxs-saif: Handle return value of clk_prepare_enable/clk_prepare Arvind Yadav 2017-07-26 14:16 ` Applied "ASoC: mxs-saif: Handle return value of clk_prepare_enable/clk_prepare." to the asoc tree Mark Brown 2017-07-26 14:16 ` Mark Brown 2017-07-25 10:14 ` [PATCH 07/11] ASoC: jz4740: Handle return value of clk_prepare_enable Arvind Yadav 2017-07-26 14:16 ` Applied "ASoC: jz4740: Handle return value of clk_prepare_enable." to the asoc tree Mark Brown 2017-07-26 14:16 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170725174353.GA8243@kozik-book \ --to=krzk@kernel.org \ --cc=alsa-devel@alsa-project.org \ --cc=arvind.yadav.cs@gmail.com \ --cc=broonie@kernel.org \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=perex@perex.cz \ --cc=sbkim73@samsung.com \ --cc=tiwai@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.