All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mbuf: fix mbuf bulk alloc Doxygen
@ 2017-07-26  4:05 Pablo de Lara
  2017-07-26  4:20 ` [PATCH v2] " Pablo de Lara
  0 siblings, 1 reply; 3+ messages in thread
From: Pablo de Lara @ 2017-07-26  4:05 UTC (permalink / raw)
  To: olivier.matz; +Cc: dev, Pablo de Lara

When calling rte_pktmbuf_alloc_bulk, if there are
not enough objects in the mempool, it returns
a negative value, which should be reflected
in the Doxygen comments.

Fixes: 9ec201f5d6e7 ("mbuf: provide bulk allocation")

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 lib/librte_mbuf/rte_mbuf.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
index 55206d9..eaed7ee 100644
--- a/lib/librte_mbuf/rte_mbuf.h
+++ b/lib/librte_mbuf/rte_mbuf.h
@@ -1138,6 +1138,7 @@ static inline struct rte_mbuf *rte_pktmbuf_alloc(struct rte_mempool *mp)
  *    Array size
  *  @return
  *   - 0: Success
+ *   - -ENOENT: Not enough entries in the mempool; no mbufs are retrieved.
  */
 static inline int rte_pktmbuf_alloc_bulk(struct rte_mempool *pool,
 	 struct rte_mbuf **mbufs, unsigned count)
-- 
2.9.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH v2] mbuf: fix mbuf bulk alloc Doxygen
  2017-07-26  4:05 [PATCH] mbuf: fix mbuf bulk alloc Doxygen Pablo de Lara
@ 2017-07-26  4:20 ` Pablo de Lara
  2017-07-31 15:17   ` [dpdk-stable] " Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Pablo de Lara @ 2017-07-26  4:20 UTC (permalink / raw)
  To: olivier.matz; +Cc: dev, Pablo de Lara, stable

When calling rte_pktmbuf_alloc_bulk, if there are
not enough objects in the mempool, it returns
a negative value, which should be reflected
in the Doxygen comments.

Fixes: 9ec201f5d6e7 ("mbuf: provide bulk allocation")
Cc: stable@dpdk.org

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---

Changes in v2:
- CC stable

 lib/librte_mbuf/rte_mbuf.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
index 55206d9..eaed7ee 100644
--- a/lib/librte_mbuf/rte_mbuf.h
+++ b/lib/librte_mbuf/rte_mbuf.h
@@ -1138,6 +1138,7 @@ static inline struct rte_mbuf *rte_pktmbuf_alloc(struct rte_mempool *mp)
  *    Array size
  *  @return
  *   - 0: Success
+ *   - -ENOENT: Not enough entries in the mempool; no mbufs are retrieved.
  */
 static inline int rte_pktmbuf_alloc_bulk(struct rte_mempool *pool,
 	 struct rte_mbuf **mbufs, unsigned count)
-- 
2.9.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH v2] mbuf: fix mbuf bulk alloc Doxygen
  2017-07-26  4:20 ` [PATCH v2] " Pablo de Lara
@ 2017-07-31 15:17   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2017-07-31 15:17 UTC (permalink / raw)
  To: Pablo de Lara; +Cc: stable, olivier.matz, dev

26/07/2017 06:20, Pablo de Lara:
> When calling rte_pktmbuf_alloc_bulk, if there are
> not enough objects in the mempool, it returns
> a negative value, which should be reflected
> in the Doxygen comments.
> 
> Fixes: 9ec201f5d6e7 ("mbuf: provide bulk allocation")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-07-31 15:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-26  4:05 [PATCH] mbuf: fix mbuf bulk alloc Doxygen Pablo de Lara
2017-07-26  4:20 ` [PATCH v2] " Pablo de Lara
2017-07-31 15:17   ` [dpdk-stable] " Thomas Monjalon

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.