* [Buildroot] [PATCH 1/1] host-mariadb: add host-openssl dependency
@ 2017-07-27 13:35 Adam Duskett
2017-07-27 14:10 ` Ryan Coe
2017-07-27 15:10 ` Thomas Petazzoni
0 siblings, 2 replies; 5+ messages in thread
From: Adam Duskett @ 2017-07-27 13:35 UTC (permalink / raw)
To: buildroot
On Fedora26, openssl 1.1.x is included by default. This causes build errors
when building the host variant of mariadb. Adding host-openssl as a dependency
fixes this issue.
Signed-off-by: Adam Duskett <aduskett@gmail.com>
---
package/mariadb/mariadb.mk | 3 +++
1 file changed, 3 insertions(+)
diff --git a/package/mariadb/mariadb.mk b/package/mariadb/mariadb.mk
index 1d6c2bcc4..8004709c7 100644
--- a/package/mariadb/mariadb.mk
+++ b/package/mariadb/mariadb.mk
@@ -22,6 +22,9 @@ MARIADB_DEPENDENCIES = \
libxml2 \
readline
+HOST_MARIADB_DEPENDENCIES = \
+ host-openssl
+
# We won't need unit tests
MARIADB_CONF_OPTS += -DWITH_UNIT_TESTS=0
--
2.13.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] host-mariadb: add host-openssl dependency
2017-07-27 13:35 [Buildroot] [PATCH 1/1] host-mariadb: add host-openssl dependency Adam Duskett
@ 2017-07-27 14:10 ` Ryan Coe
2017-07-27 15:10 ` Thomas Petazzoni
1 sibling, 0 replies; 5+ messages in thread
From: Ryan Coe @ 2017-07-27 14:10 UTC (permalink / raw)
To: buildroot
Adam,
On 7/27/2017 6:35 AM, Adam Duskett wrote:
> On Fedora26, openssl 1.1.x is included by default. This causes build errors
> when building the host variant of mariadb. Adding host-openssl as a dependency
> fixes this issue.
>
> Signed-off-by: Adam Duskett <aduskett@gmail.com>
> ---
> package/mariadb/mariadb.mk | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/package/mariadb/mariadb.mk b/package/mariadb/mariadb.mk
> index 1d6c2bcc4..8004709c7 100644
> --- a/package/mariadb/mariadb.mk
> +++ b/package/mariadb/mariadb.mk
> @@ -22,6 +22,9 @@ MARIADB_DEPENDENCIES = \
> libxml2 \
> readline
>
> +HOST_MARIADB_DEPENDENCIES = \
> + host-openssl
> +
> # We won't need unit tests
> MARIADB_CONF_OPTS += -DWITH_UNIT_TESTS=0
>
Acked-by: Ryan Coe <bluemrp9@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] host-mariadb: add host-openssl dependency
2017-07-27 13:35 [Buildroot] [PATCH 1/1] host-mariadb: add host-openssl dependency Adam Duskett
2017-07-27 14:10 ` Ryan Coe
@ 2017-07-27 15:10 ` Thomas Petazzoni
2017-07-27 22:34 ` Adam Duskett
1 sibling, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2017-07-27 15:10 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 27 Jul 2017 09:35:48 -0400, Adam Duskett wrote:
> On Fedora26, openssl 1.1.x is included by default. This causes build errors
> when building the host variant of mariadb. Adding host-openssl as a dependency
> fixes this issue.
>
> Signed-off-by: Adam Duskett <aduskett@gmail.com>
I don't think this is the correct fix. Indeed, host-mariadb builds just
fine on a system where the OpenSSL headers/development files are *NOT*
installed.
This means that host-mariadb does not require host-openssl, but uses
OpenSSL if available. So the proper solution is to pass some option at
configure time to tell host-mariadb to not attempt to use OpenSSL.
Indeed, we are not really interested in having OpenSSL support in
host-mariadb.
It apparently needs an SSL implementation, but has a small bundled one
based on yassl. Can you try:
HOST_MARIADB_CONF_OPTS += -DWITH_SSL=bundled
and see if it fixes the problem for you ?
You can try to compare the build time of host-mariadb + host-openssl
vs. host-maria-db + bundled SSL.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] host-mariadb: add host-openssl dependency
2017-07-27 15:10 ` Thomas Petazzoni
@ 2017-07-27 22:34 ` Adam Duskett
2017-07-28 6:14 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Adam Duskett @ 2017-07-27 22:34 UTC (permalink / raw)
To: buildroot
Hello;
On Thu, Jul 27, 2017 at 11:10 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Thu, 27 Jul 2017 09:35:48 -0400, Adam Duskett wrote:
>> On Fedora26, openssl 1.1.x is included by default. This causes build errors
>> when building the host variant of mariadb. Adding host-openssl as a dependency
>> fixes this issue.
>>
>> Signed-off-by: Adam Duskett <aduskett@gmail.com>
>
> I don't think this is the correct fix. Indeed, host-mariadb builds just
> fine on a system where the OpenSSL headers/development files are *NOT*
> installed.
>
> This means that host-mariadb does not require host-openssl, but uses
> OpenSSL if available. So the proper solution is to pass some option at
> configure time to tell host-mariadb to not attempt to use OpenSSL.
> Indeed, we are not really interested in having OpenSSL support in
> host-mariadb.
>
True; what about if host-openssl is already selected?
> It apparently needs an SSL implementation, but has a small bundled one
> based on yassl. Can you try:
>
> HOST_MARIADB_CONF_OPTS += -DWITH_SSL=bundled
>
> and see if it fixes the problem for you ?
This works and properly builds mariadb. That being said; should is there
a way to check if host-openssl is already selected? Or does it not matter?
>
> You can try to compare the build time of host-mariadb + host-openssl
> vs. host-maria-db + bundled SSL.
>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] host-mariadb: add host-openssl dependency
2017-07-27 22:34 ` Adam Duskett
@ 2017-07-28 6:14 ` Thomas Petazzoni
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2017-07-28 6:14 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 27 Jul 2017 18:34:52 -0400, Adam Duskett wrote:
> > This means that host-mariadb does not require host-openssl, but uses
> > OpenSSL if available. So the proper solution is to pass some option at
> > configure time to tell host-mariadb to not attempt to use OpenSSL.
> > Indeed, we are not really interested in having OpenSSL support in
> > host-mariadb.
> >
> True; what about if host-openssl is already selected?
>
> > It apparently needs an SSL implementation, but has a small bundled one
> > based on yassl. Can you try:
> >
> > HOST_MARIADB_CONF_OPTS += -DWITH_SSL=bundled
> >
> > and see if it fixes the problem for you ?
> This works and properly builds mariadb. That being said; should is there
> a way to check if host-openssl is already selected? Or does it not matter?
We currently have no way to know if a host package is selected, because
we don't have Config.in options for most host packages.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-07-28 6:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-27 13:35 [Buildroot] [PATCH 1/1] host-mariadb: add host-openssl dependency Adam Duskett
2017-07-27 14:10 ` Ryan Coe
2017-07-27 15:10 ` Thomas Petazzoni
2017-07-27 22:34 ` Adam Duskett
2017-07-28 6:14 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.