* [PATCH] staging: vboxvideo: select CONFIG_GENERIC_ALLOCATOR
@ 2017-07-28 13:21 Arnd Bergmann
2017-07-29 0:06 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2017-07-28 13:21 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Arnd Bergmann, Michael Thayer, Daniel Vetter, Hans de Goede,
devel, linux-kernel
vboxvideo fails to link without genalloc:
drivers/staging/vboxvideo/vbox_hgsmi.o: In function `hgsmi_buffer_alloc':
vbox_hgsmi.c:(.text+0x1e): undefined reference to `gen_pool_dma_alloc'
drivers/staging/vboxvideo/vbox_hgsmi.o: In function `hgsmi_buffer_free':
vbox_hgsmi.c:(.text+0xf2): undefined reference to `gen_pool_free'
This adds a Kconfig select statement, mirroring what all the other
users have.
Fixes: dd55d44f4084 ("staging: vboxvideo: Add vboxvideo to drivers/staging")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/staging/vboxvideo/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/vboxvideo/Kconfig b/drivers/staging/vboxvideo/Kconfig
index a52746f9a670..cfabe3ce4bab 100644
--- a/drivers/staging/vboxvideo/Kconfig
+++ b/drivers/staging/vboxvideo/Kconfig
@@ -2,6 +2,7 @@ config DRM_VBOXVIDEO
tristate "Virtual Box Graphics Card"
depends on DRM && X86 && PCI
select DRM_KMS_HELPER
+ select GENERIC_ALLOCATOR
help
This is a KMS driver for the virtual Graphics Card used in
Virtual Box virtual machines.
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: vboxvideo: select CONFIG_GENERIC_ALLOCATOR
2017-07-28 13:21 [PATCH] staging: vboxvideo: select CONFIG_GENERIC_ALLOCATOR Arnd Bergmann
@ 2017-07-29 0:06 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2017-07-29 0:06 UTC (permalink / raw)
To: Arnd Bergmann
Cc: devel, Michael Thayer, linux-kernel, Hans de Goede, Daniel Vetter
On Fri, Jul 28, 2017 at 03:21:01PM +0200, Arnd Bergmann wrote:
> vboxvideo fails to link without genalloc:
>
> drivers/staging/vboxvideo/vbox_hgsmi.o: In function `hgsmi_buffer_alloc':
> vbox_hgsmi.c:(.text+0x1e): undefined reference to `gen_pool_dma_alloc'
> drivers/staging/vboxvideo/vbox_hgsmi.o: In function `hgsmi_buffer_free':
> vbox_hgsmi.c:(.text+0xf2): undefined reference to `gen_pool_free'
>
> This adds a Kconfig select statement, mirroring what all the other
> users have.
>
> Fixes: dd55d44f4084 ("staging: vboxvideo: Add vboxvideo to drivers/staging")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/staging/vboxvideo/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Hans sent this same patch 2 days ago, sorry, just applied it now.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-29 0:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-28 13:21 [PATCH] staging: vboxvideo: select CONFIG_GENERIC_ALLOCATOR Arnd Bergmann
2017-07-29 0:06 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.