[PATCH] mpc832x_rdb: fix of_irq_to_resource() error check

[PATCH] mpc832x_rdb: fix of_irq_to_resource() error check

[Sergei Shtylyov]

of_irq_to_resource() has recently been  fixed to return negative error #'s
along with 0 in case of failure,  however the Freescale MPC832x RDB board
code still only regards 0 as as failure indication -- fix it up.

Fixes: 7a4228bbff76 ("of: irq: use of_irq_get() in of_irq_to_resource()")
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
The patch is against the 'master' branch of Scott Wood's 'linux.git' repo
(the 'fixes' branch is too much behind).

 arch/powerpc/platforms/83xx/mpc832x_rdb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux/arch/powerpc/platforms/83xx/mpc832x_rdb.c
===================================================================
--- linux.orig/arch/powerpc/platforms/83xx/mpc832x_rdb.c
+++ linux/arch/powerpc/platforms/83xx/mpc832x_rdb.c
@@ -89,7 +89,7 @@ static int __init of_fsl_spi_probe(char
 			goto err;
 
 		ret = of_irq_to_resource(np, 0, &res[1]);
-		if (!ret)
+		if (ret <= 0)
 			goto err;
 
 		pdev = platform_device_alloc("mpc83xx_spi", i);

Re: [PATCH] mpc832x_rdb: fix of_irq_to_resource() error check

[Scott Wood]

On Sat, 2017-07-29 at 22:52 +0300, Sergei Shtylyov wrote:
> of_irq_to_resource() has recently been  fixed to return negative error #'s
> along with 0 in case of failure,  however the Freescale MPC832x RDB board
> code still only regards 0 as as failure indication -- fix it up.
> 
> Fixes: 7a4228bbff76 ("of: irq: use of_irq_get() in of_irq_to_resource()")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> ---
> The patch is against the 'master' branch of Scott Wood's 'linux.git' repo
> (the 'fixes' branch is too much behind).

The master branch is also old.  Those branches are only used when needed to
apply patches; I don't update them just to sync up.  If they're older than
what's in Michael's or Linus's tree (as they almost always are), then use
those instead.

Not that I expect it to make a difference to this patch...

-Scott

Re: [PATCH] mpc832x_rdb: fix of_irq_to_resource() error check

[Michael Ellerman]

Scott Wood <oss@buserror.net> writes:

> On Sat, 2017-07-29 at 22:52 +0300, Sergei Shtylyov wrote:
>> of_irq_to_resource() has recently been=C2=A0=C2=A0fixed to return negati=
ve error #'s
>> along with 0 in case of failure,=C2=A0=C2=A0however the Freescale MPC832=
x RDB board
>> code still only regards 0 as as failure indication -- fix it up.
>>=20
>> Fixes: 7a4228bbff76 ("of: irq: use of_irq_get() in of_irq_to_resource()")
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>=20
>> ---
>> The patch is against the 'master' branch of Scott Wood's 'linux.git' repo
>> (the 'fixes' branch is too much behind).
>
> The master branch is also old.  Those branches are only used when needed =
to
> apply patches; I don't update them just to sync up.  If they're older than
> what's in Michael's or Linus's tree (as they almost always are), then use
> those instead.
>
> Not that I expect it to make a difference to this patch...

Do you want me to grab this as a fix for 4.13 ?

cheers

Re: [PATCH] mpc832x_rdb: fix of_irq_to_resource() error check

[Scott Wood]

On Mon, 2017-07-31 at 20:04 +1000, Michael Ellerman wrote:
> Scott Wood <oss@buserror.net> writes:
> 
> > On Sat, 2017-07-29 at 22:52 +0300, Sergei Shtylyov wrote:
> > > of_irq_to_resource() has recently been  fixed to return negative error
> > > #'s
> > > along with 0 in case of failure,  however the Freescale MPC832x RDB
> > > board
> > > code still only regards 0 as as failure indication -- fix it up.
> > > 
> > > Fixes: 7a4228bbff76 ("of: irq: use of_irq_get() in
> > > of_irq_to_resource()")
> > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> > > 
> > > ---
> > > The patch is against the 'master' branch of Scott Wood's 'linux.git'
> > > repo
> > > (the 'fixes' branch is too much behind).
> > 
> > The master branch is also old.  Those branches are only used when needed
> > to
> > apply patches; I don't update them just to sync up.  If they're older than
> > what's in Michael's or Linus's tree (as they almost always are), then use
> > those instead.
> > 
> > Not that I expect it to make a difference to this patch...
> 
> Do you want me to grab this as a fix for 4.13 ?

Sure:
Acked-by: Scott Wood <oss@buserror.net>

-Scott

Re: mpc832x_rdb: fix of_irq_to_resource() error check

[Michael Ellerman]

On Sat, 2017-07-29 at 19:52:09 UTC, Sergei Shtylyov wrote:
> of_irq_to_resource() has recently been  fixed to return negative error #'s
> along with 0 in case of failure,  however the Freescale MPC832x RDB board
> code still only regards 0 as as failure indication -- fix it up.
> 
> Fixes: 7a4228bbff76 ("of: irq: use of_irq_get() in of_irq_to_resource()")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Acked-by: Scott Wood <oss@buserror.net>

Applied to powerpc fixes, thanks.

https://git.kernel.org/powerpc/c/f29bb7861a5107cc1afbf5a565c310

cheers