All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xen-blkback: reset flush counter for log_stats
@ 2017-07-30 10:40 Valentin Vidic
  2017-08-01  7:30 ` Roger Pau Monné
  0 siblings, 1 reply; 2+ messages in thread
From: Valentin Vidic @ 2017-07-30 10:40 UTC (permalink / raw)
  To: Konrad Rzeszutek Wilk, Roger Pau Monné, xen-devel; +Cc: Valentin Vidic

All the other counters get reset to 0 when printing stats,
while the flush counter keeps incrementing:

[ 2118.107554] xen-blkback: (5.xvda-0): oo   0  |  rd 1748  |  wr    6 |  f 3424  |  ds    0 | pg:  161/1056
[ 2128.147524] xen-blkback: (5.xvda-0): oo   0  |  rd 5705  |  wr    9 |  f 3429  |  ds    0 | pg:  161/1056
[ 2138.179507] xen-blkback: (5.xvda-0): oo   0  |  rd  137  |  wr   16 |  f 3433  |  ds    0 | pg:  161/1056
[ 2148.187460] xen-blkback: (5.xvda-0): oo   0  |  rd    0  |  wr   25 |  f 3448  |  ds    0 | pg:  161/1056

Signed-off-by: Valentin Vidic <Valentin.Vidic@CARNet.hr>
---
 drivers/block/xen-blkback/blkback.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c
index fe7cd58c43d0..fe96219a533e 100644
--- a/drivers/block/xen-blkback/blkback.c
+++ b/drivers/block/xen-blkback/blkback.c
@@ -598,6 +598,7 @@ static void print_stats(struct xen_blkif_ring *ring)
 	ring->st_rd_req = 0;
 	ring->st_wr_req = 0;
 	ring->st_oo_req = 0;
+	ring->st_f_req  = 0;
 	ring->st_ds_req = 0;
 }
 
-- 
2.13.3


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] xen-blkback: reset flush counter for log_stats
  2017-07-30 10:40 [PATCH] xen-blkback: reset flush counter for log_stats Valentin Vidic
@ 2017-08-01  7:30 ` Roger Pau Monné
  0 siblings, 0 replies; 2+ messages in thread
From: Roger Pau Monné @ 2017-08-01  7:30 UTC (permalink / raw)
  To: Valentin Vidic; +Cc: xen-devel

On Sun, Jul 30, 2017 at 12:40:33PM +0200, Valentin Vidic wrote:
> All the other counters get reset to 0 when printing stats,
> while the flush counter keeps incrementing:
> 
> [ 2118.107554] xen-blkback: (5.xvda-0): oo   0  |  rd 1748  |  wr    6 |  f 3424  |  ds    0 | pg:  161/1056
> [ 2128.147524] xen-blkback: (5.xvda-0): oo   0  |  rd 5705  |  wr    9 |  f 3429  |  ds    0 | pg:  161/1056
> [ 2138.179507] xen-blkback: (5.xvda-0): oo   0  |  rd  137  |  wr   16 |  f 3433  |  ds    0 | pg:  161/1056
> [ 2148.187460] xen-blkback: (5.xvda-0): oo   0  |  rd    0  |  wr   25 |  f 3448  |  ds    0 | pg:  161/1056
> 
> Signed-off-by: Valentin Vidic <Valentin.Vidic@CARNet.hr>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-08-01  7:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-30 10:40 [PATCH] xen-blkback: reset flush counter for log_stats Valentin Vidic
2017-08-01  7:30 ` Roger Pau Monné

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.