From: Michal Hocko <mhocko@kernel.org> To: kbuild test robot <lkp@intel.com> Cc: kbuild-all@01.org, Andrew Morton <akpm@linux-foundation.org>, David Rientjes <rientjes@google.com>, Johannes Weiner <hannes@cmpxchg.org>, Roman Gushchin <guro@fb.com>, Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>, linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 2/2] mm: replace TIF_MEMDIE checks by tsk_is_oom_victim Date: Mon, 31 Jul 2017 08:46:26 +0200 [thread overview] Message-ID: <20170731064625.GB13036@dhcp22.suse.cz> (raw) In-Reply-To: <201707291609.lv5NwUPI%fengguang.wu@intel.com> On Sat 29-07-17 16:33:35, kbuild test robot wrote: > Hi Michal, > > [auto build test ERROR on cgroup/for-next] > [also build test ERROR on v4.13-rc2 next-20170728] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/Michal-Hocko/mm-oom-do-not-rely-on-TIF_MEMDIE-for-memory-reserves-access/20170728-101955 > base: https://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-next > config: i386-randconfig-c0-07291424 (attached as .config) > compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4 > reproduce: > # save the attached .config to linux build tree > make ARCH=i386 > > All errors (new ones prefixed by >>): > > In file included from include/linux/ioport.h:12:0, > from include/linux/device.h:16, > from include/linux/node.h:17, > from include/linux/cpu.h:16, > from kernel/cgroup/cpuset.c:25: > kernel/cgroup/cpuset.c: In function '__cpuset_node_allowed': > >> include/linux/compiler.h:123:18: error: implicit declaration of function 'tsk_is_oom_victim' [-Werror=implicit-function-declaration] Thanks for the report. We need this --- commit 638b5ab1ed275f23b52a71941b66c8966d332cd7 Author: Michal Hocko <mhocko@suse.com> Date: Mon Jul 31 08:45:53 2017 +0200 fold me - fix implicit declaration of function 'tsk_is_oom_victim' reported by 0day Signed-off-by: Michal Hocko <mhocko@suse.com> diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c index 1cc53dff0d94..734ae4fa9775 100644 --- a/kernel/cgroup/cpuset.c +++ b/kernel/cgroup/cpuset.c @@ -56,6 +56,7 @@ #include <linux/time64.h> #include <linux/backing-dev.h> #include <linux/sort.h> +#include <linux/oom.h> #include <linux/uaccess.h> #include <linux/atomic.h> -- Michal Hocko SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org> To: kbuild test robot <lkp@intel.com> Cc: kbuild-all@01.org, Andrew Morton <akpm@linux-foundation.org>, David Rientjes <rientjes@google.com>, Johannes Weiner <hannes@cmpxchg.org>, Roman Gushchin <guro@fb.com>, Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>, linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 2/2] mm: replace TIF_MEMDIE checks by tsk_is_oom_victim Date: Mon, 31 Jul 2017 08:46:26 +0200 [thread overview] Message-ID: <20170731064625.GB13036@dhcp22.suse.cz> (raw) In-Reply-To: <201707291609.lv5NwUPI%fengguang.wu@intel.com> On Sat 29-07-17 16:33:35, kbuild test robot wrote: > Hi Michal, > > [auto build test ERROR on cgroup/for-next] > [also build test ERROR on v4.13-rc2 next-20170728] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/Michal-Hocko/mm-oom-do-not-rely-on-TIF_MEMDIE-for-memory-reserves-access/20170728-101955 > base: https://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-next > config: i386-randconfig-c0-07291424 (attached as .config) > compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4 > reproduce: > # save the attached .config to linux build tree > make ARCH=i386 > > All errors (new ones prefixed by >>): > > In file included from include/linux/ioport.h:12:0, > from include/linux/device.h:16, > from include/linux/node.h:17, > from include/linux/cpu.h:16, > from kernel/cgroup/cpuset.c:25: > kernel/cgroup/cpuset.c: In function '__cpuset_node_allowed': > >> include/linux/compiler.h:123:18: error: implicit declaration of function 'tsk_is_oom_victim' [-Werror=implicit-function-declaration] Thanks for the report. We need this --- commit 638b5ab1ed275f23b52a71941b66c8966d332cd7 Author: Michal Hocko <mhocko@suse.com> Date: Mon Jul 31 08:45:53 2017 +0200 fold me - fix implicit declaration of function 'tsk_is_oom_victim' reported by 0day Signed-off-by: Michal Hocko <mhocko@suse.com> diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c index 1cc53dff0d94..734ae4fa9775 100644 --- a/kernel/cgroup/cpuset.c +++ b/kernel/cgroup/cpuset.c @@ -56,6 +56,7 @@ #include <linux/time64.h> #include <linux/backing-dev.h> #include <linux/sort.h> +#include <linux/oom.h> #include <linux/uaccess.h> #include <linux/atomic.h> -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-07-31 6:46 UTC|newest] Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-07-27 9:03 [PATCH 0/2] mm, oom: do not grant oom victims full memory reserves access Michal Hocko 2017-07-27 9:03 ` Michal Hocko 2017-07-27 9:03 ` [PATCH 1/2] mm, oom: do not rely on TIF_MEMDIE for " Michal Hocko 2017-07-27 9:03 ` Michal Hocko 2017-08-01 15:30 ` Tetsuo Handa 2017-08-01 15:30 ` Tetsuo Handa 2017-08-01 16:52 ` Michal Hocko 2017-08-01 16:52 ` Michal Hocko 2017-08-02 6:10 ` Michal Hocko 2017-08-02 6:10 ` Michal Hocko 2017-08-03 1:39 ` Tetsuo Handa 2017-08-03 1:39 ` Tetsuo Handa 2017-08-03 7:06 ` Michal Hocko 2017-08-03 7:06 ` Michal Hocko 2017-08-03 8:03 ` Tetsuo Handa 2017-08-03 8:03 ` Tetsuo Handa 2017-08-03 8:21 ` Michal Hocko 2017-08-03 8:21 ` Michal Hocko 2017-08-02 8:29 ` [PATCH v2 " Michal Hocko 2017-08-02 8:29 ` Michal Hocko 2017-08-03 9:37 ` Mel Gorman 2017-08-03 9:37 ` Mel Gorman 2017-08-03 11:00 ` Michal Hocko 2017-08-03 11:00 ` Michal Hocko 2017-08-03 12:22 ` Mel Gorman 2017-08-03 12:22 ` Mel Gorman 2017-07-27 9:03 ` [PATCH 2/2] mm: replace TIF_MEMDIE checks by tsk_is_oom_victim Michal Hocko 2017-07-27 9:03 ` Michal Hocko 2017-07-27 14:01 ` Tetsuo Handa 2017-07-27 14:01 ` Tetsuo Handa 2017-07-27 14:08 ` Tetsuo Handa 2017-07-27 14:08 ` Tetsuo Handa 2017-07-27 14:18 ` Michal Hocko 2017-07-27 14:18 ` Michal Hocko 2017-07-27 14:45 ` Michal Hocko 2017-07-27 14:45 ` Michal Hocko 2017-07-27 14:55 ` Roman Gushchin 2017-07-27 14:55 ` Roman Gushchin 2017-07-29 8:33 ` kbuild test robot 2017-07-31 6:46 ` Michal Hocko [this message] 2017-07-31 6:46 ` Michal Hocko 2017-08-01 12:16 ` [PATCH 0/2] mm, oom: do not grant oom victims full memory reserves access Michal Hocko 2017-08-01 12:16 ` Michal Hocko 2017-08-01 12:23 ` Roman Gushchin 2017-08-01 12:23 ` Roman Gushchin 2017-08-01 12:29 ` Michal Hocko 2017-08-01 12:29 ` Michal Hocko 2017-08-01 12:42 ` Roman Gushchin 2017-08-01 12:42 ` Roman Gushchin 2017-08-01 12:54 ` Michal Hocko 2017-08-01 12:54 ` Michal Hocko 2017-08-07 14:21 ` Michal Hocko 2017-08-07 14:21 ` Michal Hocko 2017-08-10 7:50 [PATCH v2 " Michal Hocko 2017-08-10 7:50 ` [PATCH 2/2] mm: replace TIF_MEMDIE checks by tsk_is_oom_victim Michal Hocko 2017-08-10 7:50 ` Michal Hocko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170731064625.GB13036@dhcp22.suse.cz \ --to=mhocko@kernel.org \ --cc=akpm@linux-foundation.org \ --cc=guro@fb.com \ --cc=hannes@cmpxchg.org \ --cc=kbuild-all@01.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=lkp@intel.com \ --cc=penguin-kernel@I-love.SAKURA.ne.jp \ --cc=rientjes@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.