* [PATCH] staging/pi433: Solved some coding style issues in pi433_if.c
@ 2017-07-31 10:21 RishabhHardas
2017-07-31 12:54 ` Wolf Entwicklungen
2017-07-31 15:56 ` Greg KH
0 siblings, 2 replies; 6+ messages in thread
From: RishabhHardas @ 2017-07-31 10:21 UTC (permalink / raw)
To: gregkh; +Cc: linux, colin.king, devel, linux-kernel, RishabhHardas
From: RishabhHardas <rishabhhardas@gmail.com>
Solved a few coding style issues, used BIT macro to set MINORBITS.
Signed-off-by: RishabhHardas <rishabhhardas@gmail.com>
---
drivers/staging/pi433/pi433_if.c | 24 ++++++++++++++----------
1 file changed, 14 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index d9328ce..f10ffc3 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -47,18 +47,18 @@
#include <linux/kthread.h>
#include <linux/wait.h>
#include <linux/spi/spi.h>
+#include <linux/bitops.h>
#ifdef CONFIG_COMPAT
-#include <asm/compat.h>
+#include <linux/compat.h>
#endif
#include "pi433_if.h"
#include "rf69.h"
-
-#define N_PI433_MINORS (1U << MINORBITS) /*32*/ /* ... up to 256 */
-#define MAX_MSG_SIZE 900 /* min: FIFO_SIZE! */
-#define MSG_FIFO_SIZE 65536 /* 65536 = 2^16 */
-#define NUM_DIO 2
+#define N_PI433_MINORS BIT(MINORBITS) /*32*/ /* ... up to 256 */
+#define MAX_MSG_SIZE 900 /* min: FIFO_SIZE! */
+#define MSG_FIFO_SIZE 65536 /* 65536 = 2^16 */
+#define NUM_DIO 2
static dev_t pi433_dev;
static DEFINE_IDR(pi433_idr);
@@ -66,10 +66,14 @@
static struct class *pi433_class; /* mainly for udev to create /dev/pi433 */
-/* tx config is instance specific
- so with each open a new tx config struct is needed */
-/* rx config is device specific
- so we have just one rx config, ebedded in device struct */
+/*
+ * tx config is instance specific
+ * so with each open a new tx config struct is needed
+ */
+/*
+ * rx config is device specific
+ * so we have just one rx config, ebedded in device struct
+ */
struct pi433_device {
/* device handling related values */
dev_t devt;
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] staging/pi433: Solved some coding style issues in pi433_if.c
2017-07-31 10:21 [PATCH] staging/pi433: Solved some coding style issues in pi433_if.c RishabhHardas
@ 2017-07-31 12:54 ` Wolf Entwicklungen
2017-07-31 15:56 ` Greg KH
1 sibling, 0 replies; 6+ messages in thread
From: Wolf Entwicklungen @ 2017-07-31 12:54 UTC (permalink / raw)
To: RishabhHardas
Cc: gregkh, linux, colin.king, devel, linux-kernel, RishabhHardas
Reviewed-by: Marcus Wolf <Linux@wolf-entwicklungen.de>
Thank you Rishabh!
Marcus
Am Mo, 31.07.2017, 12:21 schrieb RishabhHardas:
> From: RishabhHardas <rishabhhardas@gmail.com>
>
> Solved a few coding style issues, used BIT macro to set MINORBITS.
>
> Signed-off-by: RishabhHardas <rishabhhardas@gmail.com>
> ---
> drivers/staging/pi433/pi433_if.c | 24 ++++++++++++++----------
> 1 file changed, 14 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> index d9328ce..f10ffc3 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -47,18 +47,18 @@
> #include <linux/kthread.h>
> #include <linux/wait.h>
> #include <linux/spi/spi.h>
> +#include <linux/bitops.h>
> #ifdef CONFIG_COMPAT
> -#include <asm/compat.h>
> +#include <linux/compat.h>
> #endif
>
> #include "pi433_if.h"
> #include "rf69.h"
>
> -
> -#define N_PI433_MINORS (1U << MINORBITS) /*32*/ /* ... up to 256 */
> -#define MAX_MSG_SIZE 900 /* min: FIFO_SIZE! */
> -#define MSG_FIFO_SIZE 65536 /* 65536 = 2^16 */
> -#define NUM_DIO 2
> +#define N_PI433_MINORS BIT(MINORBITS) /*32*/ /* ... up to 256 */
> +#define MAX_MSG_SIZE 900 /* min: FIFO_SIZE! */
> +#define MSG_FIFO_SIZE 65536 /* 65536 = 2^16 */
> +#define NUM_DIO 2
>
> static dev_t pi433_dev;
> static DEFINE_IDR(pi433_idr);
> @@ -66,10 +66,14 @@
>
> static struct class *pi433_class; /* mainly for udev to create /dev/pi433 */
>
> -/* tx config is instance specific
> - so with each open a new tx config struct is needed */
> -/* rx config is device specific
> - so we have just one rx config, ebedded in device struct */
> +/*
> + * tx config is instance specific
> + * so with each open a new tx config struct is needed
> + */
> +/*
> + * rx config is device specific
> + * so we have just one rx config, ebedded in device struct
> + */
> struct pi433_device {
> /* device handling related values */
> dev_t devt;
> --
> 1.9.1
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging/pi433: Solved some coding style issues in pi433_if.c
2017-07-31 10:21 [PATCH] staging/pi433: Solved some coding style issues in pi433_if.c RishabhHardas
2017-07-31 12:54 ` Wolf Entwicklungen
@ 2017-07-31 15:56 ` Greg KH
1 sibling, 0 replies; 6+ messages in thread
From: Greg KH @ 2017-07-31 15:56 UTC (permalink / raw)
To: RishabhHardas; +Cc: devel, colin.king, linux, linux-kernel, RishabhHardas
On Mon, Jul 31, 2017 at 03:51:13PM +0530, RishabhHardas wrote:
> From: RishabhHardas <rishabhhardas@gmail.com>
>
> Solved a few coding style issues, used BIT macro to set MINORBITS.
>
> Signed-off-by: RishabhHardas <rishabhhardas@gmail.com>
For some reason I do not think your legal name has no space in it :(
Please fix and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging/pi433: Solved some coding style issues in pi433_if.c
2017-08-01 5:09 Rishabh Hardas
2017-08-02 8:15 ` Wolf Entwicklungen
@ 2017-08-15 0:54 ` Greg KH
1 sibling, 0 replies; 6+ messages in thread
From: Greg KH @ 2017-08-15 0:54 UTC (permalink / raw)
To: Rishabh Hardas; +Cc: devel, colin.king, linux, linux-kernel, Rishabh Hardas
On Tue, Aug 01, 2017 at 10:39:06AM +0530, Rishabh Hardas wrote:
> From: Rishabh Hardas <rishabhhardas@gmail.com>
>
> Solved a few coding style issues, used BIT macro to set MINORBITS.
>
> Signed-off-by: Rishabh Hardas <rishabhhardas@gmail.com>
> Reviewed-by: Marcus Wolf <linux@wolf-entwicklungen.de>
> ---
> drivers/staging/pi433/pi433_if.c | 24 ++++++++++++++----------
> 1 file changed, 14 insertions(+), 10 deletions(-)
Patch does not apply to my tree :(
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging/pi433: Solved some coding style issues in pi433_if.c
2017-08-01 5:09 Rishabh Hardas
@ 2017-08-02 8:15 ` Wolf Entwicklungen
2017-08-15 0:54 ` Greg KH
1 sibling, 0 replies; 6+ messages in thread
From: Wolf Entwicklungen @ 2017-08-02 8:15 UTC (permalink / raw)
To: Rishabh Hardas
Cc: gregkh, colin.king, linux, devel, linux-kernel, Rishabh Hardas
Reviewed-by: Marcus Wolf <linux@wolf-entwicklungen.de>
Thank you :-)
Am Di, 1.08.2017, 07:09 schrieb Rishabh Hardas:
> From: Rishabh Hardas <rishabhhardas@gmail.com>
>
> Solved a few coding style issues, used BIT macro to set MINORBITS.
>
> Signed-off-by: Rishabh Hardas <rishabhhardas@gmail.com>
> ---
> drivers/staging/pi433/pi433_if.c | 24 ++++++++++++++----------
> 1 file changed, 14 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> index d9328ce..f10ffc3 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -47,18 +47,18 @@
> #include <linux/kthread.h>
> #include <linux/wait.h>
> #include <linux/spi/spi.h>
> +#include <linux/bitops.h>
> #ifdef CONFIG_COMPAT
> -#include <asm/compat.h>
> +#include <linux/compat.h>
> #endif
>
> #include "pi433_if.h"
> #include "rf69.h"
>
> -
> -#define N_PI433_MINORS (1U << MINORBITS) /*32*/ /* ... up to 256 */
> -#define MAX_MSG_SIZE 900 /* min: FIFO_SIZE! */
> -#define MSG_FIFO_SIZE 65536 /* 65536 = 2^16 */
> -#define NUM_DIO 2
> +#define N_PI433_MINORS BIT(MINORBITS) /*32*/ /* ... up to 256 */
> +#define MAX_MSG_SIZE 900 /* min: FIFO_SIZE! */
> +#define MSG_FIFO_SIZE 65536 /* 65536 = 2^16 */
> +#define NUM_DIO 2
>
> static dev_t pi433_dev;
> static DEFINE_IDR(pi433_idr);
> @@ -66,10 +66,14 @@
>
> static struct class *pi433_class; /* mainly for udev to create /dev/pi433 */
>
> -/* tx config is instance specific
> - so with each open a new tx config struct is needed */
> -/* rx config is device specific
> - so we have just one rx config, ebedded in device struct */
> +/*
> + * tx config is instance specific
> + * so with each open a new tx config struct is needed
> + */
> +/*
> + * rx config is device specific
> + * so we have just one rx config, ebedded in device struct
> + */
> struct pi433_device {
> /* device handling related values */
> dev_t devt;
> --
> 1.9.1
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] staging/pi433: Solved some coding style issues in pi433_if.c
@ 2017-08-01 5:09 Rishabh Hardas
2017-08-02 8:15 ` Wolf Entwicklungen
2017-08-15 0:54 ` Greg KH
0 siblings, 2 replies; 6+ messages in thread
From: Rishabh Hardas @ 2017-08-01 5:09 UTC (permalink / raw)
To: gregkh; +Cc: colin.king, linux, devel, linux-kernel, Rishabh Hardas
From: Rishabh Hardas <rishabhhardas@gmail.com>
Solved a few coding style issues, used BIT macro to set MINORBITS.
Signed-off-by: Rishabh Hardas <rishabhhardas@gmail.com>
---
drivers/staging/pi433/pi433_if.c | 24 ++++++++++++++----------
1 file changed, 14 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index d9328ce..f10ffc3 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -47,18 +47,18 @@
#include <linux/kthread.h>
#include <linux/wait.h>
#include <linux/spi/spi.h>
+#include <linux/bitops.h>
#ifdef CONFIG_COMPAT
-#include <asm/compat.h>
+#include <linux/compat.h>
#endif
#include "pi433_if.h"
#include "rf69.h"
-
-#define N_PI433_MINORS (1U << MINORBITS) /*32*/ /* ... up to 256 */
-#define MAX_MSG_SIZE 900 /* min: FIFO_SIZE! */
-#define MSG_FIFO_SIZE 65536 /* 65536 = 2^16 */
-#define NUM_DIO 2
+#define N_PI433_MINORS BIT(MINORBITS) /*32*/ /* ... up to 256 */
+#define MAX_MSG_SIZE 900 /* min: FIFO_SIZE! */
+#define MSG_FIFO_SIZE 65536 /* 65536 = 2^16 */
+#define NUM_DIO 2
static dev_t pi433_dev;
static DEFINE_IDR(pi433_idr);
@@ -66,10 +66,14 @@
static struct class *pi433_class; /* mainly for udev to create /dev/pi433 */
-/* tx config is instance specific
- so with each open a new tx config struct is needed */
-/* rx config is device specific
- so we have just one rx config, ebedded in device struct */
+/*
+ * tx config is instance specific
+ * so with each open a new tx config struct is needed
+ */
+/*
+ * rx config is device specific
+ * so we have just one rx config, ebedded in device struct
+ */
struct pi433_device {
/* device handling related values */
dev_t devt;
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-08-15 0:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-31 10:21 [PATCH] staging/pi433: Solved some coding style issues in pi433_if.c RishabhHardas
2017-07-31 12:54 ` Wolf Entwicklungen
2017-07-31 15:56 ` Greg KH
2017-08-01 5:09 Rishabh Hardas
2017-08-02 8:15 ` Wolf Entwicklungen
2017-08-15 0:54 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.