* [PATCH] drivers/net/wan/z85230.c: Use designated initializers
@ 2017-07-31 1:31 Kees Cook
2017-08-01 22:29 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Kees Cook @ 2017-07-31 1:31 UTC (permalink / raw)
To: linux-kernel; +Cc: netdev
In preparation for the randstruct gcc plugin performing randomization of
structures that are entirely function pointers, use designated initializers
so the compiler doesn't get angry.
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
---
This is a prerequisite for the future randstruct fptr randomization. I'd
prefer to carry this in my gcc-plugin tree for v4.14 with an Ack from
someone on net-dev, or if possible, have it applied to v4.13 via net-dev.
Thanks!
---
drivers/net/wan/z85230.c | 30 ++++++++++++++----------------
1 file changed, 14 insertions(+), 16 deletions(-)
diff --git a/drivers/net/wan/z85230.c b/drivers/net/wan/z85230.c
index 2f0bd6955f33..deea41e96f01 100644
--- a/drivers/net/wan/z85230.c
+++ b/drivers/net/wan/z85230.c
@@ -483,11 +483,10 @@ static void z8530_status(struct z8530_channel *chan)
write_zsctrl(chan, RES_H_IUS);
}
-struct z8530_irqhandler z8530_sync =
-{
- z8530_rx,
- z8530_tx,
- z8530_status
+struct z8530_irqhandler z8530_sync = {
+ .rx = z8530_rx,
+ .tx = z8530_tx,
+ .status = z8530_status,
};
EXPORT_SYMBOL(z8530_sync);
@@ -605,15 +604,15 @@ static void z8530_dma_status(struct z8530_channel *chan)
}
static struct z8530_irqhandler z8530_dma_sync = {
- z8530_dma_rx,
- z8530_dma_tx,
- z8530_dma_status
+ .rx = z8530_dma_rx,
+ .tx = z8530_dma_tx,
+ .status = z8530_dma_status,
};
static struct z8530_irqhandler z8530_txdma_sync = {
- z8530_rx,
- z8530_dma_tx,
- z8530_dma_status
+ .rx = z8530_rx,
+ .tx = z8530_dma_tx,
+ .status = z8530_dma_status,
};
/**
@@ -678,11 +677,10 @@ static void z8530_status_clear(struct z8530_channel *chan)
write_zsctrl(chan, RES_H_IUS);
}
-struct z8530_irqhandler z8530_nop=
-{
- z8530_rx_clear,
- z8530_tx_clear,
- z8530_status_clear
+struct z8530_irqhandler z8530_nop = {
+ .rx = z8530_rx_clear,
+ .tx = z8530_tx_clear,
+ .status = z8530_status_clear,
};
--
2.7.4
--
Kees Cook
Pixel Security
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/net/wan/z85230.c: Use designated initializers
2017-07-31 1:31 [PATCH] drivers/net/wan/z85230.c: Use designated initializers Kees Cook
@ 2017-08-01 22:29 ` David Miller
2017-08-02 0:33 ` Kees Cook
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2017-08-01 22:29 UTC (permalink / raw)
To: keescook; +Cc: linux-kernel, netdev
From: Kees Cook <keescook@chromium.org>
Date: Sun, 30 Jul 2017 18:31:17 -0700
> In preparation for the randstruct gcc plugin performing randomization of
> structures that are entirely function pointers, use designated initializers
> so the compiler doesn't get angry.
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> This is a prerequisite for the future randstruct fptr randomization. I'd
> prefer to carry this in my gcc-plugin tree for v4.14 with an Ack from
> someone on net-dev, or if possible, have it applied to v4.13 via net-dev.
Please queue this up into the gcc-plugin tree then:
Acked-by: David S. Miller <davem@davemloft.net>
It isn't a bug fix so I would only have put it into 'net-next' rather
than 'net'.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/net/wan/z85230.c: Use designated initializers
2017-08-01 22:29 ` David Miller
@ 2017-08-02 0:33 ` Kees Cook
0 siblings, 0 replies; 3+ messages in thread
From: Kees Cook @ 2017-08-02 0:33 UTC (permalink / raw)
To: David Miller; +Cc: LKML, Network Development
On Tue, Aug 1, 2017 at 3:29 PM, David Miller <davem@davemloft.net> wrote:
> From: Kees Cook <keescook@chromium.org>
> Date: Sun, 30 Jul 2017 18:31:17 -0700
>
>> In preparation for the randstruct gcc plugin performing randomization of
>> structures that are entirely function pointers, use designated initializers
>> so the compiler doesn't get angry.
>>
>> Reported-by: kbuild test robot <fengguang.wu@intel.com>
>> Signed-off-by: Kees Cook <keescook@chromium.org>
>> ---
>> This is a prerequisite for the future randstruct fptr randomization. I'd
>> prefer to carry this in my gcc-plugin tree for v4.14 with an Ack from
>> someone on net-dev, or if possible, have it applied to v4.13 via net-dev.
>
> Please queue this up into the gcc-plugin tree then:
>
> Acked-by: David S. Miller <davem@davemloft.net>
>
> It isn't a bug fix so I would only have put it into 'net-next' rather
> than 'net'.
Okay, sounds good. I'll carry it. Thanks!
-Kees
--
Kees Cook
Pixel Security
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-02 0:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-31 1:31 [PATCH] drivers/net/wan/z85230.c: Use designated initializers Kees Cook
2017-08-01 22:29 ` David Miller
2017-08-02 0:33 ` Kees Cook
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.