From: Stefan Hajnoczi <stefanha@redhat.com>
To: Manos Pitsidianakis <el13635@mail.ntua.gr>
Cc: qemu-devel <qemu-devel@nongnu.org>, Kevin Wolf <kwolf@redhat.com>,
Alberto Garcia <berto@igalia.com>,
qemu-block <qemu-block@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v3 5/7] block: add throttle block filter driver
Date: Tue, 1 Aug 2017 17:14:45 +0100 [thread overview]
Message-ID: <20170801161445.GE22017@stefanha-x1.localdomain> (raw)
In-Reply-To: <20170731095443.28211-6-el13635@mail.ntua.gr>
[-- Attachment #1: Type: text/plain, Size: 524 bytes --]
On Mon, Jul 31, 2017 at 12:54:41PM +0300, Manos Pitsidianakis wrote:
> +static int throttle_configure_tgm(BlockDriverState *bs,
> + ThrottleGroupMember *tgm,
> + QDict *options, Error **errp)
> +{
> + int ret;
> + ThrottleConfig cfg;
> + const char *group_name = NULL;
> + Error *local_err = NULL;
> + QemuOpts *opts = qemu_opts_create(&throttle_opts, NULL, 0, &local_err);
If there is no scenario where this can fail please use error_abort.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2017-08-01 16:24 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 9:54 [Qemu-devel] [PATCH v3 0/7] add throttle block driver filter Manos Pitsidianakis
2017-07-31 9:54 ` [Qemu-devel] [PATCH v3 1/7] block: move ThrottleGroup membership to ThrottleGroupMember Manos Pitsidianakis
2017-08-04 11:59 ` Alberto Garcia
2017-07-31 9:54 ` [Qemu-devel] [PATCH v3 2/7] block: add aio_context field in ThrottleGroupMember Manos Pitsidianakis
2017-08-04 12:14 ` Alberto Garcia
2017-07-31 9:54 ` [Qemu-devel] [PATCH v3 3/7] block: tidy ThrottleGroupMember initializations Manos Pitsidianakis
2017-08-04 12:35 ` Alberto Garcia
2017-07-31 9:54 ` [Qemu-devel] [PATCH v3 4/7] block: convert ThrottleGroup to object with QOM Manos Pitsidianakis
2017-08-01 15:47 ` Stefan Hajnoczi
2017-08-01 16:49 ` Manos Pitsidianakis
2017-08-02 10:39 ` Stefan Hajnoczi
2017-08-02 10:57 ` Manos Pitsidianakis
2017-08-02 14:43 ` Stefan Hajnoczi
2017-08-03 8:08 ` Kevin Wolf
2017-08-03 10:53 ` Stefan Hajnoczi
2017-08-03 11:17 ` Kevin Wolf
2017-08-03 12:29 ` Manos Pitsidianakis
2017-08-08 13:01 ` Alberto Garcia
2017-07-31 9:54 ` [Qemu-devel] [PATCH v3 5/7] block: add throttle block filter driver Manos Pitsidianakis
2017-08-01 16:14 ` Stefan Hajnoczi [this message]
2017-08-03 8:07 ` Kevin Wolf
2017-08-03 11:48 ` Manos Pitsidianakis
2017-08-03 12:05 ` Kevin Wolf
2017-08-03 11:58 ` Eric Blake
2017-08-03 13:56 ` Manos Pitsidianakis
2017-08-08 13:13 ` Alberto Garcia
2017-08-08 13:45 ` Manos Pitsidianakis
2017-08-08 14:53 ` Alberto Garcia
2017-08-08 14:56 ` Manos Pitsidianakis
2017-08-08 15:04 ` Alberto Garcia
2017-08-09 9:36 ` Manos Pitsidianakis
2017-08-09 12:36 ` Alberto Garcia
2017-08-09 13:42 ` Manos Pitsidianakis
2017-08-09 14:45 ` Alberto Garcia
2017-08-09 15:39 ` Kevin Wolf
2017-08-14 12:15 ` Manos Pitsidianakis
2017-07-31 9:54 ` [Qemu-devel] [PATCH v3 6/7] block: add BlockDevOptionsThrottle to QAPI Manos Pitsidianakis
2017-08-01 16:16 ` Stefan Hajnoczi
2017-07-31 9:54 ` [Qemu-devel] [PATCH v3 7/7] block: add throttle block filter driver interface tests Manos Pitsidianakis
2017-08-03 8:07 ` Kevin Wolf
2017-08-03 13:24 ` Manos Pitsidianakis
2017-08-03 13:32 ` Kevin Wolf
2017-08-03 13:52 ` Manos Pitsidianakis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170801161445.GE22017@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=berto@igalia.com \
--cc=el13635@mail.ntua.gr \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.