Re: [Qemu-devel] [PATCH v3 5/7] block: add throttle block filter driver

[Manos Pitsidianakis <el13635@mail.ntua.gr>]

[-- Attachment #1: Type: text/plain, Size: 1287 bytes --]

On Thu, Aug 03, 2017 at 06:58:30AM -0500, Eric Blake wrote:
>On 08/03/2017 03:07 AM, Kevin Wolf wrote:
>> Am 31.07.2017 um 11:54 hat Manos Pitsidianakis geschrieben:
>>> block/throttle.c uses existing I/O throttle infrastructure inside a
>>> block filter driver. I/O operations are intercepted in the filter's
>>> read/write coroutines, and referred to block/throttle-groups.c
>>>
>>> The driver can be used with the syntax
>>> -drive driver=throttle,file.filename=foo.qcow2, \
>>>         limits.iops-total=...,throttle-group=bar
>>>
>>> The configuration flags and their semantics are identical to the
>>> hardcoded throttling ones.
>>>
>>> A node can be created referring to an existing group, and will overwrite
>>> its limits if any are specified, otherwise they are retained.
>>>
>>> Signed-off-by: Manos Pitsidianakis <el13635@mail.ntua.gr>
>>> ---
>
>>> +
>>> +    .is_filter                          =   true,
>>> +};
>>
>> What about .bdrv_co_get_block_status?
>
>And if so, do you want my byte-based block status to go in first?  (Our
>two series conflict, so we need to pick who needs to rebase on top of
>the other).

No problem. My patch is in Kevin's branch for 2.11.  Feel free to merge 
first if needed, I can rebase my patch if you do. 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]