[PATCH 0/3] HOWTO fix

[PATCH 0/3] HOWTO fix

[kusumi.tomohiro]

From: Tomohiro Kusumi <tkusumi@tuxera.com>

HOWTO bugs found while syncing the man page with HOWTO.

Tomohiro Kusumi (3):
  HOWTO: fix wrong description of trim_backlog=
  HOWTO: fix wrong "here follows the complete list of fio job
    parameters" position
  HOWTO: minor fix and backport from man page

 HOWTO | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

-- 
2.9.4

[PATCH 1/3] HOWTO: fix wrong description of trim_backlog=

[kusumi.tomohiro]

From: Tomohiro Kusumi <tkusumi@tuxera.com>

f80dba8d('Convert documentation to reStructured text.')
mixed this up with trim_verify_zero= located before this one.

The man page has this right as it's not synced (will be soon).

Signed-off-by: Tomohiro Kusumi <tkusumi@tuxera.com>
---
 HOWTO | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/HOWTO b/HOWTO
index caf6591..80d1c05 100644
--- a/HOWTO
+++ b/HOWTO
@@ -2595,7 +2595,7 @@ Verification
 
 .. option:: trim_backlog=int
 
-	Verify that trim/discarded blocks are returned as zeros.
+	Trim after this number of blocks are written.
 
 .. option:: trim_backlog_batch=int
 
-- 
2.9.4

[PATCH 2/3] HOWTO: fix wrong "here follows the complete list of fio job parameters" position

[kusumi.tomohiro]

From: Tomohiro Kusumi <tkusumi@tuxera.com>

f80dba8d('Convert documentation to reStructured text.')
made this sentence appear in the wrong place.
It should appear before "Units" job parameter section.

The man page has this right as it's not synced (will be soon).

Signed-off-by: Tomohiro Kusumi <tkusumi@tuxera.com>
---
 HOWTO | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/HOWTO b/HOWTO
index 80d1c05..3a02cc6 100644
--- a/HOWTO
+++ b/HOWTO
@@ -576,6 +576,8 @@ Parameter types
 **float_list**
 	A list of floating point numbers, separated by a ':' character.
 
+With the above in mind, here follows the complete list of fio job parameters.
+
 
 Units
 ~~~~~
@@ -622,9 +624,6 @@ Units
 		Bit based.
 
 
-With the above in mind, here follows the complete list of fio job parameters.
-
-
 Job description
 ~~~~~~~~~~~~~~~
 
-- 
2.9.4

[PATCH 3/3] HOWTO: minor fix and backport from man page

[kusumi.tomohiro]

From: Tomohiro Kusumi <tkusumi@tuxera.com>

Signed-off-by: Tomohiro Kusumi <tkusumi@tuxera.com>
---
 HOWTO | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/HOWTO b/HOWTO
index 3a02cc6..ee2b996 100644
--- a/HOWTO
+++ b/HOWTO
@@ -1529,6 +1529,7 @@ Buffers and memory
 
 		**cudamalloc**
 			Use GPU memory as the buffers for GPUDirect RDMA benchmark.
+			The ioengine must be rdma.
 
 	The area allocated is a function of the maximum allowed bs size for the job,
 	multiplied by the I/O depth given. Note that for **shmhuge** and
@@ -1857,7 +1858,7 @@ caveat that when used on the command line, they must come after the
 
    [libhdfs]
 
-		the listening port of the HFDS cluster namenode.
+		The listening port of the HFDS cluster namenode.
 
 .. option:: interface=str : [netsplice] [net]
 
@@ -1930,7 +1931,7 @@ caveat that when used on the command line, they must come after the
 	**0**
 		Default. Preallocate donor's file on init.
 	**1**
-		Allocate space immediately inside defragment event,	and free right
+		Allocate space immediately inside defragment event, and free right
 		after event.
 
 .. option:: clustername=str : [rbd]
@@ -1962,7 +1963,7 @@ caveat that when used on the command line, they must come after the
 
 .. option:: chunk_size : [libhdfs]
 
-	the size of the chunk to use for each file.
+	The size of the chunk to use for each file.
 
 
 I/O depth
@@ -2486,7 +2487,7 @@ Verification
 
 .. option:: verifysort_nr=int
 
-   Pre-load and sort verify blocks for a read workload.
+	Pre-load and sort verify blocks for a read workload.
 
 .. option:: verify_offset=int
 
-- 
2.9.4

Re: [PATCH 0/3] HOWTO fix

[Jens Axboe]

On 08/01/2017 01:49 PM, kusumi.tomohiro@gmail.com wrote:
> From: Tomohiro Kusumi <tkusumi@tuxera.com>
> 
> HOWTO bugs found while syncing the man page with HOWTO.
> 
> Tomohiro Kusumi (3):
>   HOWTO: fix wrong description of trim_backlog=
>   HOWTO: fix wrong "here follows the complete list of fio job
>     parameters" position
>   HOWTO: minor fix and backport from man page
> 
>  HOWTO | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)

Applied, thanks.

-- 
Jens Axboe