* [PATCH 2/2] atm: solos-pci: constify attribute_group structures
@ 2017-08-01 23:57 Amitoj Kaur Chawla
2017-08-02 23:53 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Amitoj Kaur Chawla @ 2017-08-01 23:57 UTC (permalink / raw)
To: 3chas3, linux-atm-general, netdev, linux-kernel
Functions working with attribute_groups provided by <linux/sysfs.h>
work with const attribute_group. These attribute_group structures do not
change at runtime so mark them as const.
File size before:
text data bss dec hex filename
35740 28424 832 64996 fde4 drivers/atm/solos-pci.o
File size after:
text data bss dec hex filename
35932 28232 832 64996 fde4 drivers/atm/solos-pci.o
This change was made with the help of Coccinelle.
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
drivers/atm/solos-pci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c
index c8f2ca6..3f9c37d 100644
--- a/drivers/atm/solos-pci.c
+++ b/drivers/atm/solos-pci.c
@@ -611,7 +611,7 @@ static struct attribute *solos_attrs[] = {
NULL
};
-static struct attribute_group solos_attr_group = {
+static const struct attribute_group solos_attr_group = {
.attrs = solos_attrs,
.name = "parameters",
};
@@ -628,7 +628,7 @@ static struct attribute *gpio_attrs[] = {
NULL
};
-static struct attribute_group gpio_attr_group = {
+static const struct attribute_group gpio_attr_group = {
.attrs = gpio_attrs,
.name = "gpio",
};
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] atm: solos-pci: constify attribute_group structures
2017-08-01 23:57 [PATCH 2/2] atm: solos-pci: constify attribute_group structures Amitoj Kaur Chawla
@ 2017-08-02 23:53 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-08-02 23:53 UTC (permalink / raw)
To: amitoj1606; +Cc: 3chas3, linux-atm-general, netdev, linux-kernel
From: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Date: Tue, 1 Aug 2017 19:57:47 -0400
> Functions working with attribute_groups provided by <linux/sysfs.h>
> work with const attribute_group. These attribute_group structures do not
> change at runtime so mark them as const.
>
> File size before:
> text data bss dec hex filename
> 35740 28424 832 64996 fde4 drivers/atm/solos-pci.o
>
> File size after:
> text data bss dec hex filename
> 35932 28232 832 64996 fde4 drivers/atm/solos-pci.o
>
> This change was made with the help of Coccinelle.
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-02 23:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-01 23:57 [PATCH 2/2] atm: solos-pci: constify attribute_group structures Amitoj Kaur Chawla
2017-08-02 23:53 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.