Re: [PATCH v2 2/2] Implement sysfs based cpuinfo for x86 cpus.

Re: [PATCH v2 2/2] Implement sysfs based cpuinfo for x86 cpus.

[Greg KH]

On Wed, Aug 02, 2017 at 07:35:16PM +0200, Felix Schnizlein wrote:
> Enable sysfs cpuinfo for x86 based cpus. Export often used cpu
> information to sysfs. Stepping, cpu flags, cpu bugs, bogomips,
> cpu family, vendor_id, model, and model_name are exported.
> 
> Sysfs documentation is updated to reflect changes.
> 
> Signed-off-by: Felix Schnizlein <fschnizlein@suse.com>
> Signed-off-by: Thomas Renninger <trenn@suse.com>
> ---
> 
>  Changes since v1:
>   - add missing documentation parts
>   - fix wording in documentation description

Note, your subject lines could use a bit better work.  How about:
	cpuinfo: implement sysfs nodes for x86

That makes it easier to see/sort in my inbox.  Same for patch 1.

Anyway, I'd really like to see this for another cpu arch at the same
time, just to verify you really have the correct api/interface here.
Can you do it for arm64 or something else as well?

thanks,

greg k-h

Re: [PATCH v2 2/2] Implement sysfs based cpuinfo for x86 cpus.

[Felix Schnizlein]

>>> Greg KH <gregkh@linuxfoundation.org> 08/02/17 7:47 PM >>>
On Wed, Aug 02, 2017 at 07:35:16PM +0200, Felix Schnizlein wrote:
>> Enable sysfs cpuinfo for x86 based cpus. Export often used cpu
>> information to sysfs. Stepping, cpu flags, cpu bugs, bogomips,
>> cpu family, vendor_id, model, and model_name are exported.
>> 
>> Sysfs documentation is updated to reflect changes.
>> 
>> Signed-off-by: Felix Schnizlein <fschnizlein@suse.com>
>> Signed-off-by: Thomas Renninger <trenn@suse.com>
>> ---
>> 
>>  Changes since v1:
>>   - add missing documentation parts
>>   - fix wording in documentation description

> Note, your subject lines could use a bit better work.  How about:
>   cpuinfo: implement sysfs nodes for x86

True, I will update them accordingly when I repost the next time.
>
> That makes it easier to see/sort in my inbox.  Same for patch 1.
>
> Anyway, I'd really like to see this for another cpu arch at the same
> time, just to verify you really have the correct api/interface here.
> Can you do it for arm64 or something else as well?

Sure, I will look into what devices are available for me and implement
another arch.

Felix
>
> thanks,
>
> greg k-h