Re: [PATCH] staging: rtl8192e: Change fixed function names with "%s: ", __func__

Re: [PATCH] staging: rtl8192e: Change fixed function names with "%s: ", __func__

[Greg Kroah-Hartman]

On Thu, Aug 03, 2017 at 01:59:56AM +0800, vergilzhang wrote:
> staging: rtl8192e: Fix coding style issue caught by checkpatch.pl related to function name in debug print
> 
> Signed-off-by: vergilzhang <zhang_shurong@foxmail.com>
> ---
>  drivers/staging/rtl8192e/dot11d.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

You didn't pay attention to the other issues my patch bot sent you about
this patch, why not?  I'll just wait for you to fix them all and drop
this one for now, sorry.

greg k-h

Re: [PATCH] staging: rtl8192e: Change fixed function names with "%s:", __func__

[Greg Kroah-Hartman]

On Mon, Aug 21, 2017 at 09:32:35PM +0800, Shurong Zhang wrote:
> Replace hard-coded function names in strings with "%s", __func__ in the dot11d.c file. Issue found by checkpatch.pl.

Please always wrap your changelog text at 72 columns.

And why did you send this twice?

thanks,

greg k-h

Re: [PATCH] staging: rtl8192e: Change fixed function names with "%s: ", __func__

[Greg Kroah-Hartman]

On Fri, Aug 18, 2017 at 11:53:41PM +0800, 张树荣 wrote:
> From: Shurong Zhang <zhang_shurong@foxmail.com>
> 
> Replace hard-coded function names in strings with "%s", __func__
>     in the dot11d.c file. Issue found by checkpatch.pl.
> 
> Signed-off-by: Shurong Zhang <zhang_shurong@foxmail.com>
> ---
>  drivers/staging/rtl8192e/dot11d.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

This patch doesn't apply at all, are you sure you generated it
correctly?

thanks,

greg k-h

[PATCH] staging: rtl8192e: Change fixed function names with "%s: ",__func__

[=?gb18030?B?1cXK98jZ?=]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb18030", Size: 1211 bytes --]

From: Shurong Zhang <zhang_shurong@foxmail.com>

Replace hard-coded function names in strings with "%s", __func__
    in the dot11d.c file. Issue found by checkpatch.pl.

Signed-off-by: Shurong Zhang <zhang_shurong@foxmail.com>
---
 drivers/staging/rtl8192e/dot11d.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192e/dot11d.c b/drivers/staging/rtl8192e/dot11d.c
index 017fe04..be78db1 100644
--- a/drivers/staging/rtl8192e/dot11d.c
+++ b/drivers/staging/rtl8192e/dot11d.c
@@ -128,12 +128,12 @@ void Dot11d_UpdateCountryIe(struct rtllib_device *dev, u8 *pTaddr,
 	pTriple = (struct chnl_txpow_triple *)(pCoutryIe + 3);
 	for (i = 0; i < NumTriples; i++) {
 	if (MaxChnlNum >= pTriple->FirstChnl) {
-	netdev_info(dev->dev, "Dot11d_UpdateCountryIe(): Invalid country IE, skip it........1\n");
+	netdev_info(dev->dev, "%s(): Invalid country IE, skip it........1\n",__func__);
 	return;
 	}
 	if (MAX_CHANNEL_NUMBER < (pTriple->FirstChnl +
 	    pTriple->NumChnls)) {
-	netdev_info(dev->dev, "Dot11d_UpdateCountryIe(): Invalid country IE, skip it........2\n");
+	netdev_info(dev->dev, "%s(): Invalid country IE, skip it........2\n",__func__);
 	return;
 	}
 
-- 
2.7.4

Re: [PATCH] staging: rtl8192e: Change fixed function names with "%s: ", __func__

[Greg Kroah-Hartman]

On Thu, Aug 03, 2017 at 09:46:26AM +0800, vergilzhang wrote:
> Replace hard-coded function names in strings with "%s", __func__
>     in the dot11d.c file. Issue found by checkpatch.pl.
> 
> Signed-off-by: vergilzhang <zhang_shurong@foxmail.com>

Please use your "legal" name here, and in the From line.  Please fix up
and resend all of your submitted patches with that change.

thanks,

greg k-h