All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 0/2] update GCC graphite support
@ 2017-08-01 23:42 Andrey Yurovsky
  2017-08-01 23:43 ` [Buildroot] [PATCH 1/2] gcc: support grahite for GCC 5 or above Andrey Yurovsky
  2017-08-01 23:43 ` [Buildroot] [PATCH 2/2] isl: bump to version 0.18 Andrey Yurovsky
  0 siblings, 2 replies; 5+ messages in thread
From: Andrey Yurovsky @ 2017-08-01 23:42 UTC (permalink / raw)
  To: buildroot

The current ISL prevents building GCC 7.X with graphite. Update ISL to
version 0.18 which works with GCC 5.X through 7.X and mark graphite as
unsupported for GCC 4.X. Addesses bug 10091.

Andrey Yurovsky (2):
  gcc: support grahite for GCC 5 or above
  isl: bump to version 0.18

 package/gcc/Config.in.host | 4 ++++
 package/gcc/gcc.mk         | 9 +++------
 package/isl/isl.hash       | 2 +-
 package/isl/isl.mk         | 5 +----
 4 files changed, 9 insertions(+), 11 deletions(-)

-- 
2.13.3

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/2] gcc: support grahite for GCC 5 or above
  2017-08-01 23:42 [Buildroot] [PATCH 0/2] update GCC graphite support Andrey Yurovsky
@ 2017-08-01 23:43 ` Andrey Yurovsky
  2017-08-02 19:41   ` Thomas Petazzoni
  2017-08-01 23:43 ` [Buildroot] [PATCH 2/2] isl: bump to version 0.18 Andrey Yurovsky
  1 sibling, 1 reply; 5+ messages in thread
From: Andrey Yurovsky @ 2017-08-01 23:43 UTC (permalink / raw)
  To: buildroot

Dropping graphite support for 4.X (of which only 4.9 remains) enables us
to build graphite support the modern way (which involves only ISL
rather than ISL and cloog). Newer versions of GCC require a newer ISL
which does not work with cloog.

Signed-off-by: Andrey Yurovsky <yurovsky@gmail.com>
---
 package/gcc/Config.in.host | 4 ++++
 package/gcc/gcc.mk         | 9 +++------
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/package/gcc/Config.in.host b/package/gcc/Config.in.host
index 768dc176ae..8a2efd39bb 100644
--- a/package/gcc/Config.in.host
+++ b/package/gcc/Config.in.host
@@ -159,6 +159,10 @@ config BR2_GCC_ENABLE_LIBMUDFLAP
 
 config BR2_GCC_ENABLE_GRAPHITE
 	bool "Enable graphite support"
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5
 	help
 	  This option enables the graphite optimizations in the
 	  compiler.
+
+comment "graphite support requires at least GCC 5.X"
+	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_5
diff --git a/package/gcc/gcc.mk b/package/gcc/gcc.mk
index 67d3343efe..ed1999e43a 100644
--- a/package/gcc/gcc.mk
+++ b/package/gcc/gcc.mk
@@ -173,15 +173,12 @@ else
 HOST_GCC_COMMON_CONF_OPTS += --enable-threads
 endif
 
+# gcc 5 doesn't need cloog any more, see
+# https://gcc.gnu.org/gcc-5/changes.html
+# and we don't support graphite on GCC 4.9.x
 ifeq ($(BR2_GCC_ENABLE_GRAPHITE),y)
 HOST_GCC_COMMON_DEPENDENCIES += host-isl
 HOST_GCC_COMMON_CONF_OPTS += --with-isl=$(HOST_DIR)
-# gcc 5 doesn't need cloog any more, see
-# https://gcc.gnu.org/gcc-5/changes.html
-ifeq ($(BR2_TOOLCHAIN_GCC_AT_LEAST_5),)
-HOST_GCC_COMMON_DEPENDENCIES += host-cloog
-HOST_GCC_COMMON_CONF_OPTS += --with-cloog=$(HOST_DIR)
-endif
 else
 HOST_GCC_COMMON_CONF_OPTS += --without-isl --without-cloog
 endif
-- 
2.13.3

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 2/2] isl: bump to version 0.18
  2017-08-01 23:42 [Buildroot] [PATCH 0/2] update GCC graphite support Andrey Yurovsky
  2017-08-01 23:43 ` [Buildroot] [PATCH 1/2] gcc: support grahite for GCC 5 or above Andrey Yurovsky
@ 2017-08-01 23:43 ` Andrey Yurovsky
  2017-08-02 19:41   ` Thomas Petazzoni
  1 sibling, 1 reply; 5+ messages in thread
From: Andrey Yurovsky @ 2017-08-01 23:43 UTC (permalink / raw)
  To: buildroot

This is needed by GCC 7.X for graphite support. There's no longer any
tie to cloog, so remove the comment related to that.

Signed-off-by: Andrey Yurovsky <yurovsky@gmail.com>
---
 package/isl/isl.hash | 2 +-
 package/isl/isl.mk   | 5 +----
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/package/isl/isl.hash b/package/isl/isl.hash
index e2c14ad149..43e5a463af 100644
--- a/package/isl/isl.hash
+++ b/package/isl/isl.hash
@@ -1,2 +1,2 @@
 # Locally computed
-sha256	8882c9e36549fc757efa267706a9af733bb8d7fe3905cbfde43e17a89eea4675	isl-0.14.1.tar.xz
+sha256	0f35051cc030b87c673ac1f187de40e386a1482a0cfdf2c552dd6031b307ddc4	isl-0.18.tar.xz
diff --git a/package/isl/isl.mk b/package/isl/isl.mk
index 74de125b60..32e7691f6b 100644
--- a/package/isl/isl.mk
+++ b/package/isl/isl.mk
@@ -4,10 +4,7 @@
 #
 ################################################################################
 
-# The latest 0.15 version is not yet compatible with cloog 0.18.3, so
-# bumping isl is not possible until a new version of cloog is
-# published.
-ISL_VERSION = 0.14.1
+ISL_VERSION = 0.18
 ISL_SOURCE = isl-$(ISL_VERSION).tar.xz
 ISL_SITE = http://isl.gforge.inria.fr
 ISL_LICENSE = MIT
-- 
2.13.3

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/2] gcc: support grahite for GCC 5 or above
  2017-08-01 23:43 ` [Buildroot] [PATCH 1/2] gcc: support grahite for GCC 5 or above Andrey Yurovsky
@ 2017-08-02 19:41   ` Thomas Petazzoni
  0 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2017-08-02 19:41 UTC (permalink / raw)
  To: buildroot

Hello,

On Tue,  1 Aug 2017 16:43:00 -0700, Andrey Yurovsky wrote:
> Dropping graphite support for 4.X (of which only 4.9 remains) enables us
> to build graphite support the modern way (which involves only ISL
> rather than ISL and cloog). Newer versions of GCC require a newer ISL
> which does not work with cloog.
> 
> Signed-off-by: Andrey Yurovsky <yurovsky@gmail.com>
> ---
>  package/gcc/Config.in.host | 4 ++++
>  package/gcc/gcc.mk         | 9 +++------
>  2 files changed, 7 insertions(+), 6 deletions(-)

Applied after tweaking the commit log. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 2/2] isl: bump to version 0.18
  2017-08-01 23:43 ` [Buildroot] [PATCH 2/2] isl: bump to version 0.18 Andrey Yurovsky
@ 2017-08-02 19:41   ` Thomas Petazzoni
  0 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2017-08-02 19:41 UTC (permalink / raw)
  To: buildroot

Hello,

On Tue,  1 Aug 2017 16:43:01 -0700, Andrey Yurovsky wrote:
> This is needed by GCC 7.X for graphite support. There's no longer any
> tie to cloog, so remove the comment related to that.
> 
> Signed-off-by: Andrey Yurovsky <yurovsky@gmail.com>
> ---
>  package/isl/isl.hash | 2 +-
>  package/isl/isl.mk   | 5 +----
>  2 files changed, 2 insertions(+), 5 deletions(-)

Applied after tweaking the commit log, and removing ISL_LIBTOOL_PATCH =
NO, which was no longer needed.

Also, I've removed the cloog package, which was no longer used anywhere.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-08-02 19:41 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-01 23:42 [Buildroot] [PATCH 0/2] update GCC graphite support Andrey Yurovsky
2017-08-01 23:43 ` [Buildroot] [PATCH 1/2] gcc: support grahite for GCC 5 or above Andrey Yurovsky
2017-08-02 19:41   ` Thomas Petazzoni
2017-08-01 23:43 ` [Buildroot] [PATCH 2/2] isl: bump to version 0.18 Andrey Yurovsky
2017-08-02 19:41   ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.