* [PATCH] PCI: qcom: Use gpiod_set_value_cansleep()
@ 2017-07-16 22:56 Fabio Estevam
2017-08-02 21:43 ` Bjorn Helgaas
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Fabio Estevam @ 2017-07-16 22:56 UTC (permalink / raw)
To: bhelgaas; +Cc: svarbanov, linux-pci, Fabio Estevam
From: Fabio Estevam <fabio.estevam@nxp.com>
The reset GPIO can be connected to a I2C or SPI IO expander, which
may sleep, so it is safer to use the gpiod_set_value_cansleep()
variant instead.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
drivers/pci/dwc/pcie-qcom.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/dwc/pcie-qcom.c b/drivers/pci/dwc/pcie-qcom.c
index 68c5f2a..8359de0 100644
--- a/drivers/pci/dwc/pcie-qcom.c
+++ b/drivers/pci/dwc/pcie-qcom.c
@@ -141,13 +141,13 @@ struct qcom_pcie {
static void qcom_ep_reset_assert(struct qcom_pcie *pcie)
{
- gpiod_set_value(pcie->reset, 1);
+ gpiod_set_value_cansleep(pcie->reset, 1);
usleep_range(PERST_DELAY_US, PERST_DELAY_US + 500);
}
static void qcom_ep_reset_deassert(struct qcom_pcie *pcie)
{
- gpiod_set_value(pcie->reset, 0);
+ gpiod_set_value_cansleep(pcie->reset, 0);
usleep_range(PERST_DELAY_US, PERST_DELAY_US + 500);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI: qcom: Use gpiod_set_value_cansleep()
2017-07-16 22:56 [PATCH] PCI: qcom: Use gpiod_set_value_cansleep() Fabio Estevam
@ 2017-08-02 21:43 ` Bjorn Helgaas
2017-08-03 9:19 ` Stanimir Varbanov
2017-08-03 21:10 ` Bjorn Helgaas
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Helgaas @ 2017-08-02 21:43 UTC (permalink / raw)
To: Fabio Estevam; +Cc: bhelgaas, svarbanov, linux-pci, Fabio Estevam
On Sun, Jul 16, 2017 at 07:56:38PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> The reset GPIO can be connected to a I2C or SPI IO expander, which
> may sleep, so it is safer to use the gpiod_set_value_cansleep()
> variant instead.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Any opinion, Stanimir?
> ---
> drivers/pci/dwc/pcie-qcom.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/dwc/pcie-qcom.c b/drivers/pci/dwc/pcie-qcom.c
> index 68c5f2a..8359de0 100644
> --- a/drivers/pci/dwc/pcie-qcom.c
> +++ b/drivers/pci/dwc/pcie-qcom.c
> @@ -141,13 +141,13 @@ struct qcom_pcie {
>
> static void qcom_ep_reset_assert(struct qcom_pcie *pcie)
> {
> - gpiod_set_value(pcie->reset, 1);
> + gpiod_set_value_cansleep(pcie->reset, 1);
> usleep_range(PERST_DELAY_US, PERST_DELAY_US + 500);
> }
>
> static void qcom_ep_reset_deassert(struct qcom_pcie *pcie)
> {
> - gpiod_set_value(pcie->reset, 0);
> + gpiod_set_value_cansleep(pcie->reset, 0);
> usleep_range(PERST_DELAY_US, PERST_DELAY_US + 500);
> }
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI: qcom: Use gpiod_set_value_cansleep()
2017-07-16 22:56 [PATCH] PCI: qcom: Use gpiod_set_value_cansleep() Fabio Estevam
2017-08-02 21:43 ` Bjorn Helgaas
@ 2017-08-03 9:19 ` Stanimir Varbanov
2017-08-03 21:10 ` Bjorn Helgaas
2 siblings, 0 replies; 4+ messages in thread
From: Stanimir Varbanov @ 2017-08-03 9:19 UTC (permalink / raw)
To: Fabio Estevam, bhelgaas; +Cc: linux-pci, Fabio Estevam
Hi,
Thanks for the patch!
On 07/17/2017 01:56 AM, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> The reset GPIO can be connected to a I2C or SPI IO expander, which
> may sleep, so it is safer to use the gpiod_set_value_cansleep()
> variant instead.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> drivers/pci/dwc/pcie-qcom.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Stanimir Varbanov <svarbanov@mm-sol.com>
>
> diff --git a/drivers/pci/dwc/pcie-qcom.c b/drivers/pci/dwc/pcie-qcom.c
> index 68c5f2a..8359de0 100644
> --- a/drivers/pci/dwc/pcie-qcom.c
> +++ b/drivers/pci/dwc/pcie-qcom.c
> @@ -141,13 +141,13 @@ struct qcom_pcie {
>
> static void qcom_ep_reset_assert(struct qcom_pcie *pcie)
> {
> - gpiod_set_value(pcie->reset, 1);
> + gpiod_set_value_cansleep(pcie->reset, 1);
> usleep_range(PERST_DELAY_US, PERST_DELAY_US + 500);
> }
>
> static void qcom_ep_reset_deassert(struct qcom_pcie *pcie)
> {
> - gpiod_set_value(pcie->reset, 0);
> + gpiod_set_value_cansleep(pcie->reset, 0);
> usleep_range(PERST_DELAY_US, PERST_DELAY_US + 500);
> }
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI: qcom: Use gpiod_set_value_cansleep()
2017-07-16 22:56 [PATCH] PCI: qcom: Use gpiod_set_value_cansleep() Fabio Estevam
2017-08-02 21:43 ` Bjorn Helgaas
2017-08-03 9:19 ` Stanimir Varbanov
@ 2017-08-03 21:10 ` Bjorn Helgaas
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Helgaas @ 2017-08-03 21:10 UTC (permalink / raw)
To: Fabio Estevam; +Cc: bhelgaas, svarbanov, linux-pci, Fabio Estevam
On Sun, Jul 16, 2017 at 07:56:38PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> The reset GPIO can be connected to a I2C or SPI IO expander, which
> may sleep, so it is safer to use the gpiod_set_value_cansleep()
> variant instead.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Applied with Stanimir's ack to pci/host-qcom for v4.14, thanks!
> ---
> drivers/pci/dwc/pcie-qcom.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/dwc/pcie-qcom.c b/drivers/pci/dwc/pcie-qcom.c
> index 68c5f2a..8359de0 100644
> --- a/drivers/pci/dwc/pcie-qcom.c
> +++ b/drivers/pci/dwc/pcie-qcom.c
> @@ -141,13 +141,13 @@ struct qcom_pcie {
>
> static void qcom_ep_reset_assert(struct qcom_pcie *pcie)
> {
> - gpiod_set_value(pcie->reset, 1);
> + gpiod_set_value_cansleep(pcie->reset, 1);
> usleep_range(PERST_DELAY_US, PERST_DELAY_US + 500);
> }
>
> static void qcom_ep_reset_deassert(struct qcom_pcie *pcie)
> {
> - gpiod_set_value(pcie->reset, 0);
> + gpiod_set_value_cansleep(pcie->reset, 0);
> usleep_range(PERST_DELAY_US, PERST_DELAY_US + 500);
> }
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-03 21:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-16 22:56 [PATCH] PCI: qcom: Use gpiod_set_value_cansleep() Fabio Estevam
2017-08-02 21:43 ` Bjorn Helgaas
2017-08-03 9:19 ` Stanimir Varbanov
2017-08-03 21:10 ` Bjorn Helgaas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.