From: Tobias Klauser <tklauser@distanz.ch> To: Oleksandr Shamray <oleksandrs@mellanox.com> Cc: gregkh@linuxfoundation.org, arnd@arndb.de, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, openbmc@lists.ozlabs.org, joel@jms.id.au, jiri@resnulli.us, linux-serial@vger.kernel.org, mec@shout.net, vadimp@maellanox.com, system-sw-low-level@mellanox.com, Jiri Pirko <jiri@mellanox.com> Subject: Re: [patch v1 1/2] drivers: jtag: Add JTAG core driver Date: Thu, 3 Aug 2017 11:28:27 +0200 [thread overview] Message-ID: <20170803092826.GF3546@distanz.ch> (raw) In-Reply-To: <1501679918-20486-2-git-send-email-oleksandrs@mellanox.com> Nice work! On 2017-08-02 at 15:18:37 +0200, Oleksandr Shamray <oleksandrs@mellanox.com> wrote: > --- /dev/null > +++ b/drivers/jtag/jtag.c [...] > +static int jtag_run_test_idle(struct jtag *jtag, > + struct jtag_run_test_idle *idle) Both the function and the struct it takes have the same name, which of course is perfectly valid C. However, IMO it would be easier to grep for the function/struct individually if they had different names. > +{ > + if (jtag->ops->idle) > + return jtag->ops->idle(jtag, idle); > + else > + return -EOPNOTSUPP; > +} [...] > --- /dev/null > +++ b/include/uapi/linux/jtag.h > @@ -0,0 +1,133 @@ [...] > +/** > + * struct jtag_run_test_idle - forces JTAG sm to > + * RUN_TEST/IDLE state * I guess a newline is needed here to make this a valid kerneldoc comment (the trailing '*' indicates that one was actually intended here ;) Also, 'sm' should probably be spelled out as 'state machine'. > + * @mode: access mode > + * @reset: 0 - run IDEL/PAUSE from current state > + * 1 - go trough TEST_LOGIC/RESET state before IDEL/PAUSE Typos: s/trough/through/ and s/IDEL/IDLE/ > + * @end: completion flag > + * @tck: clock counter > + * > + * Structure represents interface to JTAG device for jtag idle > + * execution. > + */ > +struct jtag_run_test_idle { > + enum jtag_xfer_mode mode; > + unsigned char reset; > + enum jtag_endstate endstate; > + unsigned char tck; > +};
WARNING: multiple messages have this Message-ID (diff)
From: tklauser@distanz.ch (Tobias Klauser) To: linux-arm-kernel@lists.infradead.org Subject: [patch v1 1/2] drivers: jtag: Add JTAG core driver Date: Thu, 3 Aug 2017 11:28:27 +0200 [thread overview] Message-ID: <20170803092826.GF3546@distanz.ch> (raw) In-Reply-To: <1501679918-20486-2-git-send-email-oleksandrs@mellanox.com> Nice work! On 2017-08-02 at 15:18:37 +0200, Oleksandr Shamray <oleksandrs@mellanox.com> wrote: > --- /dev/null > +++ b/drivers/jtag/jtag.c [...] > +static int jtag_run_test_idle(struct jtag *jtag, > + struct jtag_run_test_idle *idle) Both the function and the struct it takes have the same name, which of course is perfectly valid C. However, IMO it would be easier to grep for the function/struct individually if they had different names. > +{ > + if (jtag->ops->idle) > + return jtag->ops->idle(jtag, idle); > + else > + return -EOPNOTSUPP; > +} [...] > --- /dev/null > +++ b/include/uapi/linux/jtag.h > @@ -0,0 +1,133 @@ [...] > +/** > + * struct jtag_run_test_idle - forces JTAG sm to > + * RUN_TEST/IDLE state * I guess a newline is needed here to make this a valid kerneldoc comment (the trailing '*' indicates that one was actually intended here ;) Also, 'sm' should probably be spelled out as 'state machine'. > + * @mode: access mode > + * @reset: 0 - run IDEL/PAUSE from current state > + * 1 - go trough TEST_LOGIC/RESET state before IDEL/PAUSE Typos: s/trough/through/ and s/IDEL/IDLE/ > + * @end: completion flag > + * @tck: clock counter > + * > + * Structure represents interface to JTAG device for jtag idle > + * execution. > + */ > +struct jtag_run_test_idle { > + enum jtag_xfer_mode mode; > + unsigned char reset; > + enum jtag_endstate endstate; > + unsigned char tck; > +};
next prev parent reply other threads:[~2017-08-03 9:28 UTC|newest] Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-08-02 13:18 [patch v1 0/2] JTAG driver introduction Oleksandr Shamray 2017-08-02 13:18 ` Oleksandr Shamray 2017-08-02 13:18 ` Oleksandr Shamray 2017-08-02 13:18 ` [patch v1 1/2] drivers: jtag: Add JTAG core driver Oleksandr Shamray 2017-08-02 13:18 ` Oleksandr Shamray 2017-08-02 13:44 ` Greg KH 2017-08-02 13:44 ` Greg KH 2017-08-02 13:44 ` Greg KH 2017-08-02 13:44 ` Greg KH 2017-08-02 14:16 ` Andrew Lunn 2017-08-02 14:16 ` Andrew Lunn 2017-08-02 14:24 ` Neil Armstrong 2017-08-02 14:24 ` Neil Armstrong 2017-08-02 14:24 ` Neil Armstrong 2017-08-02 15:37 ` Arnd Bergmann 2017-08-02 15:37 ` Arnd Bergmann 2017-08-03 9:28 ` Tobias Klauser [this message] 2017-08-03 9:28 ` Tobias Klauser 2017-08-02 13:18 ` [patch v1 2/2] drivers: jtag: Add Aspeed SoC 24xx and 25xx families JTAG master driver Oleksandr Shamray 2017-08-02 13:18 ` Oleksandr Shamray 2017-08-02 14:30 ` Neil Armstrong 2017-08-02 14:30 ` Neil Armstrong 2017-08-02 14:56 ` Arnd Bergmann 2017-08-02 14:56 ` Arnd Bergmann 2017-08-02 14:56 ` Arnd Bergmann 2017-08-02 14:54 ` Arnd Bergmann 2017-08-02 14:54 ` Arnd Bergmann 2017-08-02 14:54 ` Arnd Bergmann 2017-08-02 15:31 ` Randy Dunlap 2017-08-02 15:31 ` Randy Dunlap 2017-08-03 12:12 ` kbuild test robot 2017-08-03 12:12 ` kbuild test robot 2017-08-03 12:12 ` kbuild test robot 2017-08-03 14:35 ` [PATCH] drivers: jtag: fix resource_size.cocci warnings kbuild test robot 2017-08-03 14:35 ` kbuild test robot 2017-08-03 14:35 ` kbuild test robot 2017-08-03 14:48 ` Oleksandr Shamray 2017-08-03 14:48 ` Oleksandr Shamray 2017-08-03 14:48 ` Oleksandr Shamray 2017-08-03 14:35 ` [patch v1 2/2] drivers: jtag: Add Aspeed SoC 24xx and 25xx families JTAG master driver kbuild test robot 2017-08-03 14:35 ` kbuild test robot 2017-08-03 14:35 ` kbuild test robot 2017-08-02 14:12 ` [patch v1 0/2] JTAG driver introduction Andrew Lunn 2017-08-02 14:12 ` Andrew Lunn 2017-08-03 15:26 ` Oleksandr Shamray 2017-08-03 15:26 ` Oleksandr Shamray 2017-08-03 15:26 ` Oleksandr Shamray 2017-08-03 15:26 ` Oleksandr Shamray 2017-08-03 17:48 ` Andrew Lunn 2017-08-03 17:48 ` Andrew Lunn 2017-08-03 17:48 ` Andrew Lunn 2017-08-28 20:03 ` Pavel Machek 2017-08-28 20:03 ` Pavel Machek 2017-08-28 20:03 ` Pavel Machek 2017-08-28 20:03 ` Pavel Machek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170803092826.GF3546@distanz.ch \ --to=tklauser@distanz.ch \ --cc=arnd@arndb.de \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=jiri@mellanox.com \ --cc=jiri@resnulli.us \ --cc=joel@jms.id.au \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=mec@shout.net \ --cc=oleksandrs@mellanox.com \ --cc=openbmc@lists.ozlabs.org \ --cc=system-sw-low-level@mellanox.com \ --cc=vadimp@maellanox.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.