* [PATCH v4 1/1] add new compatible strings for mtk nor controller
@ 2017-07-25 2:10 ` Guochun Mao
0 siblings, 0 replies; 26+ messages in thread
From: Guochun Mao @ 2017-07-25 2:10 UTC (permalink / raw)
To: Rob Herring, Matthias Brugger
Cc: Boris Brezillon, Cyrille Pitchen, Marek Vasut, David Woodhouse,
Richard Weinberger, Mark Rutland, Russell King, linux-mtd,
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel
Improve subject.
Guochun Mao (1):
dt-bindings: mtd: add new compatible strings for mtk nor controller
Documentation/devicetree/bindings/mtd/mtk-quadspi.txt | 2 ++
1 file changed, 2 insertions(+)
--
1.9.1
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH v4 1/1] add new compatible strings for mtk nor controller
@ 2017-07-25 2:10 ` Guochun Mao
0 siblings, 0 replies; 26+ messages in thread
From: Guochun Mao @ 2017-07-25 2:10 UTC (permalink / raw)
To: Rob Herring, Matthias Brugger
Cc: Boris Brezillon, Cyrille Pitchen, Marek Vasut, David Woodhouse,
Richard Weinberger, Mark Rutland, Russell King,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Improve subject.
Guochun Mao (1):
dt-bindings: mtd: add new compatible strings for mtk nor controller
Documentation/devicetree/bindings/mtd/mtk-quadspi.txt | 2 ++
1 file changed, 2 insertions(+)
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH v4 1/1] add new compatible strings for mtk nor controller
@ 2017-07-25 2:10 ` Guochun Mao
0 siblings, 0 replies; 26+ messages in thread
From: Guochun Mao @ 2017-07-25 2:10 UTC (permalink / raw)
To: linux-arm-kernel
Improve subject.
Guochun Mao (1):
dt-bindings: mtd: add new compatible strings for mtk nor controller
Documentation/devicetree/bindings/mtd/mtk-quadspi.txt | 2 ++
1 file changed, 2 insertions(+)
--
1.9.1
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH] dt-bindings: mtd: add new compatible strings for mtk nor controller
@ 2017-07-25 2:10 ` Guochun Mao
0 siblings, 0 replies; 26+ messages in thread
From: Guochun Mao @ 2017-07-25 2:10 UTC (permalink / raw)
To: Rob Herring, Matthias Brugger
Cc: Boris Brezillon, Cyrille Pitchen, Marek Vasut, David Woodhouse,
Richard Weinberger, Mark Rutland, Russell King, linux-mtd,
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
Guochun Mao
Add "mediatek,mt2712-nor" and "mediatek,mt7622-nor"
for nor flash node's compatible strings.
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Signed-off-by: Guochun Mao <guochun.mao@mediatek.com>
---
.../devicetree/bindings/mtd/mtk-quadspi.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
index 5ded66a..9845ff4 100644
--- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
+++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
@@ -3,6 +3,8 @@
Required properties:
- compatible: The possible values are:
"mediatek,mt2701-nor"
+ "mediatek,mt2712-nor"
+ "mediatek,mt7622-nor"
"mediatek,mt7623-nor"
"mediatek,mt8173-nor"
For mt8173, compatible should be "mediatek,mt8173-nor".
--
1.7.9.5
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH] dt-bindings: mtd: add new compatible strings for mtk nor controller
@ 2017-07-25 2:10 ` Guochun Mao
0 siblings, 0 replies; 26+ messages in thread
From: Guochun Mao @ 2017-07-25 2:10 UTC (permalink / raw)
To: Rob Herring, Matthias Brugger
Cc: Boris Brezillon, Cyrille Pitchen, Marek Vasut, David Woodhouse,
Richard Weinberger, Mark Rutland, Russell King,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Guochun Mao
Add "mediatek,mt2712-nor" and "mediatek,mt7622-nor"
for nor flash node's compatible strings.
Reviewed-by: Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Signed-off-by: Guochun Mao <guochun.mao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
---
.../devicetree/bindings/mtd/mtk-quadspi.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
index 5ded66a..9845ff4 100644
--- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
+++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
@@ -3,6 +3,8 @@
Required properties:
- compatible: The possible values are:
"mediatek,mt2701-nor"
+ "mediatek,mt2712-nor"
+ "mediatek,mt7622-nor"
"mediatek,mt7623-nor"
"mediatek,mt8173-nor"
For mt8173, compatible should be "mediatek,mt8173-nor".
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH] dt-bindings: mtd: add new compatible strings for mtk nor controller
@ 2017-07-25 2:10 ` Guochun Mao
0 siblings, 0 replies; 26+ messages in thread
From: Guochun Mao @ 2017-07-25 2:10 UTC (permalink / raw)
To: linux-arm-kernel
Add "mediatek,mt2712-nor" and "mediatek,mt7622-nor"
for nor flash node's compatible strings.
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Signed-off-by: Guochun Mao <guochun.mao@mediatek.com>
---
.../devicetree/bindings/mtd/mtk-quadspi.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
index 5ded66a..9845ff4 100644
--- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
+++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
@@ -3,6 +3,8 @@
Required properties:
- compatible: The possible values are:
"mediatek,mt2701-nor"
+ "mediatek,mt2712-nor"
+ "mediatek,mt7622-nor"
"mediatek,mt7623-nor"
"mediatek,mt8173-nor"
For mt8173, compatible should be "mediatek,mt8173-nor".
--
1.7.9.5
^ permalink raw reply related [flat|nested] 26+ messages in thread
* Re: [PATCH] dt-bindings: mtd: add new compatible strings for mtk nor controller
@ 2017-08-01 12:33 ` Matthias Brugger
0 siblings, 0 replies; 26+ messages in thread
From: Matthias Brugger @ 2017-08-01 12:33 UTC (permalink / raw)
To: Guochun Mao, Rob Herring, Boris Brezillon
Cc: Cyrille Pitchen, Marek Vasut, David Woodhouse,
Richard Weinberger, Mark Rutland, Russell King, linux-mtd,
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel
On 07/25/2017 04:10 AM, Guochun Mao wrote:
> Add "mediatek,mt2712-nor" and "mediatek,mt7622-nor"
> for nor flash node's compatible strings.
>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> Signed-off-by: Guochun Mao <guochun.mao@mediatek.com>
> ---
> .../devicetree/bindings/mtd/mtk-quadspi.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> index 5ded66a..9845ff4 100644
> --- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> +++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> @@ -3,6 +3,8 @@
> Required properties:
> - compatible: The possible values are:
> "mediatek,mt2701-nor"
> + "mediatek,mt2712-nor"
> + "mediatek,mt7622-nor"
> "mediatek,mt7623-nor"
> "mediatek,mt8173-nor"
> For mt8173, compatible should be "mediatek,mt8173-nor".
>
Boris, will you take this through your tree, or do you prefer that I take it?
Regards,
Matthias
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] dt-bindings: mtd: add new compatible strings for mtk nor controller
@ 2017-08-01 12:33 ` Matthias Brugger
0 siblings, 0 replies; 26+ messages in thread
From: Matthias Brugger @ 2017-08-01 12:33 UTC (permalink / raw)
To: Guochun Mao, Rob Herring, Boris Brezillon
Cc: Cyrille Pitchen, Marek Vasut, David Woodhouse,
Richard Weinberger, Mark Rutland, Russell King,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On 07/25/2017 04:10 AM, Guochun Mao wrote:
> Add "mediatek,mt2712-nor" and "mediatek,mt7622-nor"
> for nor flash node's compatible strings.
>
> Reviewed-by: Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Guochun Mao <guochun.mao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> ---
> .../devicetree/bindings/mtd/mtk-quadspi.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> index 5ded66a..9845ff4 100644
> --- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> +++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> @@ -3,6 +3,8 @@
> Required properties:
> - compatible: The possible values are:
> "mediatek,mt2701-nor"
> + "mediatek,mt2712-nor"
> + "mediatek,mt7622-nor"
> "mediatek,mt7623-nor"
> "mediatek,mt8173-nor"
> For mt8173, compatible should be "mediatek,mt8173-nor".
>
Boris, will you take this through your tree, or do you prefer that I take it?
Regards,
Matthias
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH] dt-bindings: mtd: add new compatible strings for mtk nor controller
@ 2017-08-01 12:33 ` Matthias Brugger
0 siblings, 0 replies; 26+ messages in thread
From: Matthias Brugger @ 2017-08-01 12:33 UTC (permalink / raw)
To: linux-arm-kernel
On 07/25/2017 04:10 AM, Guochun Mao wrote:
> Add "mediatek,mt2712-nor" and "mediatek,mt7622-nor"
> for nor flash node's compatible strings.
>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> Signed-off-by: Guochun Mao <guochun.mao@mediatek.com>
> ---
> .../devicetree/bindings/mtd/mtk-quadspi.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> index 5ded66a..9845ff4 100644
> --- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> +++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> @@ -3,6 +3,8 @@
> Required properties:
> - compatible: The possible values are:
> "mediatek,mt2701-nor"
> + "mediatek,mt2712-nor"
> + "mediatek,mt7622-nor"
> "mediatek,mt7623-nor"
> "mediatek,mt8173-nor"
> For mt8173, compatible should be "mediatek,mt8173-nor".
>
Boris, will you take this through your tree, or do you prefer that I take it?
Regards,
Matthias
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] dt-bindings: mtd: add new compatible strings for mtk nor controller
@ 2017-08-02 8:36 ` Boris Brezillon
0 siblings, 0 replies; 26+ messages in thread
From: Boris Brezillon @ 2017-08-02 8:36 UTC (permalink / raw)
To: Matthias Brugger, Marek Vasut, Cyrille Pitchen
Cc: Guochun Mao, Rob Herring, Mark Rutland, devicetree,
Richard Weinberger, Russell King, linux-kernel, linux-mtd,
linux-mediatek, David Woodhouse, linux-arm-kernel
Hi Matthias,
On Tue, 1 Aug 2017 14:33:22 +0200
Matthias Brugger <matthias.bgg@gmail.com> wrote:
> On 07/25/2017 04:10 AM, Guochun Mao wrote:
> > Add "mediatek,mt2712-nor" and "mediatek,mt7622-nor"
> > for nor flash node's compatible strings.
> >
> > Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> > Signed-off-by: Guochun Mao <guochun.mao@mediatek.com>
> > ---
> > .../devicetree/bindings/mtd/mtk-quadspi.txt | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> > index 5ded66a..9845ff4 100644
> > --- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> > +++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> > @@ -3,6 +3,8 @@
> > Required properties:
> > - compatible: The possible values are:
> > "mediatek,mt2701-nor"
> > + "mediatek,mt2712-nor"
> > + "mediatek,mt7622-nor"
> > "mediatek,mt7623-nor"
> > "mediatek,mt8173-nor"
> > For mt8173, compatible should be "mediatek,mt8173-nor".
> >
>
> Boris, will you take this through your tree, or do you prefer that I take it?
I'm not the spi-nor maintainer, you should ask Cyrille or Marek.
Regards,
Boris
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] dt-bindings: mtd: add new compatible strings for mtk nor controller
@ 2017-08-02 8:36 ` Boris Brezillon
0 siblings, 0 replies; 26+ messages in thread
From: Boris Brezillon @ 2017-08-02 8:36 UTC (permalink / raw)
To: Matthias Brugger, Marek Vasut, Cyrille Pitchen
Cc: Guochun Mao, Rob Herring, Mark Rutland,
devicetree-u79uwXL29TY76Z2rM5mHXA, Richard Weinberger,
Russell King, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, David Woodhouse,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Hi Matthias,
On Tue, 1 Aug 2017 14:33:22 +0200
Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> On 07/25/2017 04:10 AM, Guochun Mao wrote:
> > Add "mediatek,mt2712-nor" and "mediatek,mt7622-nor"
> > for nor flash node's compatible strings.
> >
> > Reviewed-by: Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > Signed-off-by: Guochun Mao <guochun.mao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> > ---
> > .../devicetree/bindings/mtd/mtk-quadspi.txt | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> > index 5ded66a..9845ff4 100644
> > --- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> > +++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> > @@ -3,6 +3,8 @@
> > Required properties:
> > - compatible: The possible values are:
> > "mediatek,mt2701-nor"
> > + "mediatek,mt2712-nor"
> > + "mediatek,mt7622-nor"
> > "mediatek,mt7623-nor"
> > "mediatek,mt8173-nor"
> > For mt8173, compatible should be "mediatek,mt8173-nor".
> >
>
> Boris, will you take this through your tree, or do you prefer that I take it?
I'm not the spi-nor maintainer, you should ask Cyrille or Marek.
Regards,
Boris
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH] dt-bindings: mtd: add new compatible strings for mtk nor controller
@ 2017-08-02 8:36 ` Boris Brezillon
0 siblings, 0 replies; 26+ messages in thread
From: Boris Brezillon @ 2017-08-02 8:36 UTC (permalink / raw)
To: linux-arm-kernel
Hi Matthias,
On Tue, 1 Aug 2017 14:33:22 +0200
Matthias Brugger <matthias.bgg@gmail.com> wrote:
> On 07/25/2017 04:10 AM, Guochun Mao wrote:
> > Add "mediatek,mt2712-nor" and "mediatek,mt7622-nor"
> > for nor flash node's compatible strings.
> >
> > Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> > Signed-off-by: Guochun Mao <guochun.mao@mediatek.com>
> > ---
> > .../devicetree/bindings/mtd/mtk-quadspi.txt | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> > index 5ded66a..9845ff4 100644
> > --- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> > +++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> > @@ -3,6 +3,8 @@
> > Required properties:
> > - compatible: The possible values are:
> > "mediatek,mt2701-nor"
> > + "mediatek,mt2712-nor"
> > + "mediatek,mt7622-nor"
> > "mediatek,mt7623-nor"
> > "mediatek,mt8173-nor"
> > For mt8173, compatible should be "mediatek,mt8173-nor".
> >
>
> Boris, will you take this through your tree, or do you prefer that I take it?
I'm not the spi-nor maintainer, you should ask Cyrille or Marek.
Regards,
Boris
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] dt-bindings: mtd: add new compatible strings for mtk nor controller
2017-08-02 8:36 ` Boris Brezillon
(?)
@ 2017-08-02 15:31 ` Cyrille Pitchen
-1 siblings, 0 replies; 26+ messages in thread
From: Cyrille Pitchen @ 2017-08-02 15:31 UTC (permalink / raw)
To: Boris Brezillon, Matthias Brugger, Marek Vasut, Cyrille Pitchen
Cc: Mark Rutland, devicetree, Guochun Mao, Richard Weinberger,
Russell King, linux-kernel, Rob Herring, linux-mtd,
linux-mediatek, David Woodhouse, linux-arm-kernel
Hi Guochun,
Le 02/08/2017 à 10:36, Boris Brezillon a écrit :
> Hi Matthias,
>
> On Tue, 1 Aug 2017 14:33:22 +0200
> Matthias Brugger <matthias.bgg@gmail.com> wrote:
>
>> On 07/25/2017 04:10 AM, Guochun Mao wrote:
>>> Add "mediatek,mt2712-nor" and "mediatek,mt7622-nor"
>>> for nor flash node's compatible strings.
>>>
>>> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
>>> Signed-off-by: Guochun Mao <guochun.mao@mediatek.com>
>>> ---
>>> .../devicetree/bindings/mtd/mtk-quadspi.txt | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
>>> index 5ded66a..9845ff4 100644
>>> --- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
>>> +++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
>>> @@ -3,6 +3,8 @@
>>> Required properties:
>>> - compatible: The possible values are:
>>> "mediatek,mt2701-nor"
>>> + "mediatek,mt2712-nor"
>>> + "mediatek,mt7622-nor"
>>> "mediatek,mt7623-nor"
>>> "mediatek,mt8173-nor"
>>> For mt8173, compatible should be "mediatek,mt8173-nor".
>>>
There should be another patch to update the mtk_nor_of_ids[] array in
the mtk-quadspi.c driver, shouldn't it?
Currently, I only see the "mediatek,mt8173-nor" compatible string at the
driver side. The driver and its documentation should be aligned and both
patches should be applied at the same time.
Best regards,
Cyrille
>>
>> Boris, will you take this through your tree, or do you prefer that I take it?
>
> I'm not the spi-nor maintainer, you should ask Cyrille or Marek.
>
> Regards,
>
> Boris
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
>
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] dt-bindings: mtd: add new compatible strings for mtk nor controller
@ 2017-08-02 15:31 ` Cyrille Pitchen
0 siblings, 0 replies; 26+ messages in thread
From: Cyrille Pitchen @ 2017-08-02 15:31 UTC (permalink / raw)
To: Boris Brezillon, Matthias Brugger, Marek Vasut, Cyrille Pitchen
Cc: Mark Rutland, devicetree-u79uwXL29TY76Z2rM5mHXA, Guochun Mao,
Richard Weinberger, Russell King,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Rob Herring,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, David Woodhouse,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Hi Guochun,
Le 02/08/2017 à 10:36, Boris Brezillon a écrit :
> Hi Matthias,
>
> On Tue, 1 Aug 2017 14:33:22 +0200
> Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>
>> On 07/25/2017 04:10 AM, Guochun Mao wrote:
>>> Add "mediatek,mt2712-nor" and "mediatek,mt7622-nor"
>>> for nor flash node's compatible strings.
>>>
>>> Reviewed-by: Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>> Signed-off-by: Guochun Mao <guochun.mao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
>>> ---
>>> .../devicetree/bindings/mtd/mtk-quadspi.txt | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
>>> index 5ded66a..9845ff4 100644
>>> --- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
>>> +++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
>>> @@ -3,6 +3,8 @@
>>> Required properties:
>>> - compatible: The possible values are:
>>> "mediatek,mt2701-nor"
>>> + "mediatek,mt2712-nor"
>>> + "mediatek,mt7622-nor"
>>> "mediatek,mt7623-nor"
>>> "mediatek,mt8173-nor"
>>> For mt8173, compatible should be "mediatek,mt8173-nor".
>>>
There should be another patch to update the mtk_nor_of_ids[] array in
the mtk-quadspi.c driver, shouldn't it?
Currently, I only see the "mediatek,mt8173-nor" compatible string at the
driver side. The driver and its documentation should be aligned and both
patches should be applied at the same time.
Best regards,
Cyrille
>>
>> Boris, will you take this through your tree, or do you prefer that I take it?
>
> I'm not the spi-nor maintainer, you should ask Cyrille or Marek.
>
> Regards,
>
> Boris
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH] dt-bindings: mtd: add new compatible strings for mtk nor controller
@ 2017-08-02 15:31 ` Cyrille Pitchen
0 siblings, 0 replies; 26+ messages in thread
From: Cyrille Pitchen @ 2017-08-02 15:31 UTC (permalink / raw)
To: linux-arm-kernel
Hi Guochun,
Le 02/08/2017 ? 10:36, Boris Brezillon a ?crit :
> Hi Matthias,
>
> On Tue, 1 Aug 2017 14:33:22 +0200
> Matthias Brugger <matthias.bgg@gmail.com> wrote:
>
>> On 07/25/2017 04:10 AM, Guochun Mao wrote:
>>> Add "mediatek,mt2712-nor" and "mediatek,mt7622-nor"
>>> for nor flash node's compatible strings.
>>>
>>> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
>>> Signed-off-by: Guochun Mao <guochun.mao@mediatek.com>
>>> ---
>>> .../devicetree/bindings/mtd/mtk-quadspi.txt | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
>>> index 5ded66a..9845ff4 100644
>>> --- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
>>> +++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
>>> @@ -3,6 +3,8 @@
>>> Required properties:
>>> - compatible: The possible values are:
>>> "mediatek,mt2701-nor"
>>> + "mediatek,mt2712-nor"
>>> + "mediatek,mt7622-nor"
>>> "mediatek,mt7623-nor"
>>> "mediatek,mt8173-nor"
>>> For mt8173, compatible should be "mediatek,mt8173-nor".
>>>
There should be another patch to update the mtk_nor_of_ids[] array in
the mtk-quadspi.c driver, shouldn't it?
Currently, I only see the "mediatek,mt8173-nor" compatible string at the
driver side. The driver and its documentation should be aligned and both
patches should be applied at the same time.
Best regards,
Cyrille
>>
>> Boris, will you take this through your tree, or do you prefer that I take it?
>
> I'm not the spi-nor maintainer, you should ask Cyrille or Marek.
>
> Regards,
>
> Boris
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
>
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] dt-bindings: mtd: add new compatible strings for mtk nor controller
@ 2017-08-03 2:16 ` Guochun Mao
0 siblings, 0 replies; 26+ messages in thread
From: Guochun Mao @ 2017-08-03 2:16 UTC (permalink / raw)
To: Cyrille Pitchen
Cc: Boris Brezillon, Matthias Brugger, Marek Vasut, Cyrille Pitchen,
Mark Rutland, devicetree, Richard Weinberger, Russell King,
linux-kernel, Rob Herring, linux-mtd, linux-mediatek,
David Woodhouse, linux-arm-kernel
Hi Cyrille,
On Wed, 2017-08-02 at 17:31 +0200, Cyrille Pitchen wrote:
> Hi Guochun,
>
> Le 02/08/2017 à 10:36, Boris Brezillon a écrit :
> > Hi Matthias,
> >
> > On Tue, 1 Aug 2017 14:33:22 +0200
> > Matthias Brugger <matthias.bgg@gmail.com> wrote:
> >
> >> On 07/25/2017 04:10 AM, Guochun Mao wrote:
> >>> Add "mediatek,mt2712-nor" and "mediatek,mt7622-nor"
> >>> for nor flash node's compatible strings.
> >>>
> >>> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> >>> Signed-off-by: Guochun Mao <guochun.mao@mediatek.com>
> >>> ---
> >>> .../devicetree/bindings/mtd/mtk-quadspi.txt | 2 ++
> >>> 1 file changed, 2 insertions(+)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> >>> index 5ded66a..9845ff4 100644
> >>> --- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> >>> +++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> >>> @@ -3,6 +3,8 @@
> >>> Required properties:
> >>> - compatible: The possible values are:
> >>> "mediatek,mt2701-nor"
> >>> + "mediatek,mt2712-nor"
> >>> + "mediatek,mt7622-nor"
> >>> "mediatek,mt7623-nor"
> >>> "mediatek,mt8173-nor"
> >>> For mt8173, compatible should be "mediatek,mt8173-nor".
> >>>
>
> There should be another patch to update the mtk_nor_of_ids[] array in
> the mtk-quadspi.c driver, shouldn't it?
>
> Currently, I only see the "mediatek,mt8173-nor" compatible string at the
> driver side. The driver and its documentation should be aligned and both
> patches should be applied at the same time.
> Best regards,
>
> Cyrille
>From my designer's info, these IPs' nor controller could use same
driver, and I had verified it. I think there's no need to update
mtk_nor_of_ids[], unless we find difference between these IPs(exactly
compared with mt8173).
How do you think?
And, we will add dts patches for new SOCs, are these patches should
applied with this documentation?
Best regards,
Guochun
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] dt-bindings: mtd: add new compatible strings for mtk nor controller
@ 2017-08-03 2:16 ` Guochun Mao
0 siblings, 0 replies; 26+ messages in thread
From: Guochun Mao @ 2017-08-03 2:16 UTC (permalink / raw)
To: Cyrille Pitchen
Cc: Boris Brezillon, Matthias Brugger, Marek Vasut, Cyrille Pitchen,
Mark Rutland, devicetree-u79uwXL29TY76Z2rM5mHXA,
Richard Weinberger, Russell King,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Rob Herring,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, David Woodhouse,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Hi Cyrille,
On Wed, 2017-08-02 at 17:31 +0200, Cyrille Pitchen wrote:
> Hi Guochun,
>
> Le 02/08/2017 à 10:36, Boris Brezillon a écrit :
> > Hi Matthias,
> >
> > On Tue, 1 Aug 2017 14:33:22 +0200
> > Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> >
> >> On 07/25/2017 04:10 AM, Guochun Mao wrote:
> >>> Add "mediatek,mt2712-nor" and "mediatek,mt7622-nor"
> >>> for nor flash node's compatible strings.
> >>>
> >>> Reviewed-by: Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >>> Signed-off-by: Guochun Mao <guochun.mao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> >>> ---
> >>> .../devicetree/bindings/mtd/mtk-quadspi.txt | 2 ++
> >>> 1 file changed, 2 insertions(+)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> >>> index 5ded66a..9845ff4 100644
> >>> --- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> >>> +++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> >>> @@ -3,6 +3,8 @@
> >>> Required properties:
> >>> - compatible: The possible values are:
> >>> "mediatek,mt2701-nor"
> >>> + "mediatek,mt2712-nor"
> >>> + "mediatek,mt7622-nor"
> >>> "mediatek,mt7623-nor"
> >>> "mediatek,mt8173-nor"
> >>> For mt8173, compatible should be "mediatek,mt8173-nor".
> >>>
>
> There should be another patch to update the mtk_nor_of_ids[] array in
> the mtk-quadspi.c driver, shouldn't it?
>
> Currently, I only see the "mediatek,mt8173-nor" compatible string at the
> driver side. The driver and its documentation should be aligned and both
> patches should be applied at the same time.
> Best regards,
>
> Cyrille
>From my designer's info, these IPs' nor controller could use same
driver, and I had verified it. I think there's no need to update
mtk_nor_of_ids[], unless we find difference between these IPs(exactly
compared with mt8173).
How do you think?
And, we will add dts patches for new SOCs, are these patches should
applied with this documentation?
Best regards,
Guochun
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH] dt-bindings: mtd: add new compatible strings for mtk nor controller
@ 2017-08-03 2:16 ` Guochun Mao
0 siblings, 0 replies; 26+ messages in thread
From: Guochun Mao @ 2017-08-03 2:16 UTC (permalink / raw)
To: linux-arm-kernel
Hi Cyrille,
On Wed, 2017-08-02 at 17:31 +0200, Cyrille Pitchen wrote:
> Hi Guochun,
>
> Le 02/08/2017 ? 10:36, Boris Brezillon a ?crit :
> > Hi Matthias,
> >
> > On Tue, 1 Aug 2017 14:33:22 +0200
> > Matthias Brugger <matthias.bgg@gmail.com> wrote:
> >
> >> On 07/25/2017 04:10 AM, Guochun Mao wrote:
> >>> Add "mediatek,mt2712-nor" and "mediatek,mt7622-nor"
> >>> for nor flash node's compatible strings.
> >>>
> >>> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> >>> Signed-off-by: Guochun Mao <guochun.mao@mediatek.com>
> >>> ---
> >>> .../devicetree/bindings/mtd/mtk-quadspi.txt | 2 ++
> >>> 1 file changed, 2 insertions(+)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> >>> index 5ded66a..9845ff4 100644
> >>> --- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> >>> +++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> >>> @@ -3,6 +3,8 @@
> >>> Required properties:
> >>> - compatible: The possible values are:
> >>> "mediatek,mt2701-nor"
> >>> + "mediatek,mt2712-nor"
> >>> + "mediatek,mt7622-nor"
> >>> "mediatek,mt7623-nor"
> >>> "mediatek,mt8173-nor"
> >>> For mt8173, compatible should be "mediatek,mt8173-nor".
> >>>
>
> There should be another patch to update the mtk_nor_of_ids[] array in
> the mtk-quadspi.c driver, shouldn't it?
>
> Currently, I only see the "mediatek,mt8173-nor" compatible string at the
> driver side. The driver and its documentation should be aligned and both
> patches should be applied at the same time.
> Best regards,
>
> Cyrille
>From my designer's info, these IPs' nor controller could use same
driver, and I had verified it. I think there's no need to update
mtk_nor_of_ids[], unless we find difference between these IPs(exactly
compared with mt8173).
How do you think?
And, we will add dts patches for new SOCs, are these patches should
applied with this documentation?
Best regards,
Guochun
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] dt-bindings: mtd: add new compatible strings for mtk nor controller
2017-08-03 2:16 ` Guochun Mao
@ 2017-08-03 10:09 ` Matthias Brugger
-1 siblings, 0 replies; 26+ messages in thread
From: Matthias Brugger @ 2017-08-03 10:09 UTC (permalink / raw)
To: Guochun Mao, Cyrille Pitchen
Cc: Boris Brezillon, Marek Vasut, Cyrille Pitchen, Mark Rutland,
devicetree, Richard Weinberger, Russell King, linux-kernel,
Rob Herring, linux-mtd, linux-mediatek, David Woodhouse,
linux-arm-kernel
On 08/03/2017 04:16 AM, Guochun Mao wrote:
> Hi Cyrille,
>
> On Wed, 2017-08-02 at 17:31 +0200, Cyrille Pitchen wrote:
>> Hi Guochun,
>>
>> Le 02/08/2017 à 10:36, Boris Brezillon a écrit :
>>> Hi Matthias,
>>>
>>> On Tue, 1 Aug 2017 14:33:22 +0200
>>> Matthias Brugger <matthias.bgg@gmail.com> wrote:
>>>
>>>> On 07/25/2017 04:10 AM, Guochun Mao wrote:
>>>>> Add "mediatek,mt2712-nor" and "mediatek,mt7622-nor"
>>>>> for nor flash node's compatible strings.
>>>>>
>>>>> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
>>>>> Signed-off-by: Guochun Mao <guochun.mao@mediatek.com>
>>>>> ---
>>>>> .../devicetree/bindings/mtd/mtk-quadspi.txt | 2 ++
>>>>> 1 file changed, 2 insertions(+)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
>>>>> index 5ded66a..9845ff4 100644
>>>>> --- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
>>>>> +++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
>>>>> @@ -3,6 +3,8 @@
>>>>> Required properties:
>>>>> - compatible: The possible values are:
>>>>> "mediatek,mt2701-nor"
>>>>> + "mediatek,mt2712-nor"
>>>>> + "mediatek,mt7622-nor"
>>>>> "mediatek,mt7623-nor"
>>>>> "mediatek,mt8173-nor"
>>>>> For mt8173, compatible should be "mediatek,mt8173-nor".
>>>>>
>>
>> There should be another patch to update the mtk_nor_of_ids[] array in
>> the mtk-quadspi.c driver, shouldn't it?
>>
>> Currently, I only see the "mediatek,mt8173-nor" compatible string at the
>> driver side. The driver and its documentation should be aligned and both
>> patches should be applied at the same time.
>
>> Best regards,
>>
>> Cyrille
>
>
> From my designer's info, these IPs' nor controller could use same
> driver, and I had verified it. I think there's no need to update
> mtk_nor_of_ids[], unless we find difference between these IPs(exactly
> compared with mt8173).
> How do you think?
>
Right, mt8173-nor is the fallback binding which will be used by the driver. As
the documentation states, the compatible string should be something like:
"mediatek,mt7622-nor", "mediatek,mt8173-nor"
So the mt7622-nor binding is not matched in the driver, as the driver is the
same on all SoCs. Nonetheless if we realize in the future that mt7622 IP has
some special feature/bug, we can use the binding to implement that in the driver.
AFAIK this is the standard way for bindings. Cyrille, is this ok for you, or do
want all bindings to be reflected in the driver even though they don't change
any functionality?
Regards,
Matthias
> And, we will add dts patches for new SOCs, are these patches should
> applied with this documentation?
>
> Best regards,
> Guochun
>
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH] dt-bindings: mtd: add new compatible strings for mtk nor controller
@ 2017-08-03 10:09 ` Matthias Brugger
0 siblings, 0 replies; 26+ messages in thread
From: Matthias Brugger @ 2017-08-03 10:09 UTC (permalink / raw)
To: linux-arm-kernel
On 08/03/2017 04:16 AM, Guochun Mao wrote:
> Hi Cyrille,
>
> On Wed, 2017-08-02 at 17:31 +0200, Cyrille Pitchen wrote:
>> Hi Guochun,
>>
>> Le 02/08/2017 ? 10:36, Boris Brezillon a ?crit :
>>> Hi Matthias,
>>>
>>> On Tue, 1 Aug 2017 14:33:22 +0200
>>> Matthias Brugger <matthias.bgg@gmail.com> wrote:
>>>
>>>> On 07/25/2017 04:10 AM, Guochun Mao wrote:
>>>>> Add "mediatek,mt2712-nor" and "mediatek,mt7622-nor"
>>>>> for nor flash node's compatible strings.
>>>>>
>>>>> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
>>>>> Signed-off-by: Guochun Mao <guochun.mao@mediatek.com>
>>>>> ---
>>>>> .../devicetree/bindings/mtd/mtk-quadspi.txt | 2 ++
>>>>> 1 file changed, 2 insertions(+)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
>>>>> index 5ded66a..9845ff4 100644
>>>>> --- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
>>>>> +++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
>>>>> @@ -3,6 +3,8 @@
>>>>> Required properties:
>>>>> - compatible: The possible values are:
>>>>> "mediatek,mt2701-nor"
>>>>> + "mediatek,mt2712-nor"
>>>>> + "mediatek,mt7622-nor"
>>>>> "mediatek,mt7623-nor"
>>>>> "mediatek,mt8173-nor"
>>>>> For mt8173, compatible should be "mediatek,mt8173-nor".
>>>>>
>>
>> There should be another patch to update the mtk_nor_of_ids[] array in
>> the mtk-quadspi.c driver, shouldn't it?
>>
>> Currently, I only see the "mediatek,mt8173-nor" compatible string at the
>> driver side. The driver and its documentation should be aligned and both
>> patches should be applied at the same time.
>
>> Best regards,
>>
>> Cyrille
>
>
> From my designer's info, these IPs' nor controller could use same
> driver, and I had verified it. I think there's no need to update
> mtk_nor_of_ids[], unless we find difference between these IPs(exactly
> compared with mt8173).
> How do you think?
>
Right, mt8173-nor is the fallback binding which will be used by the driver. As
the documentation states, the compatible string should be something like:
"mediatek,mt7622-nor", "mediatek,mt8173-nor"
So the mt7622-nor binding is not matched in the driver, as the driver is the
same on all SoCs. Nonetheless if we realize in the future that mt7622 IP has
some special feature/bug, we can use the binding to implement that in the driver.
AFAIK this is the standard way for bindings. Cyrille, is this ok for you, or do
want all bindings to be reflected in the driver even though they don't change
any functionality?
Regards,
Matthias
> And, we will add dts patches for new SOCs, are these patches should
> applied with this documentation?
>
> Best regards,
> Guochun
>
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] dt-bindings: mtd: add new compatible strings for mtk nor controller
2017-08-03 2:16 ` Guochun Mao
(?)
@ 2017-08-03 17:47 ` Rob Herring
-1 siblings, 0 replies; 26+ messages in thread
From: Rob Herring @ 2017-08-03 17:47 UTC (permalink / raw)
To: Guochun Mao
Cc: Cyrille Pitchen, Boris Brezillon, Matthias Brugger, Marek Vasut,
Cyrille Pitchen, Mark Rutland, devicetree, Richard Weinberger,
Russell King, linux-kernel, linux-mtd, linux-mediatek,
David Woodhouse, linux-arm-kernel
On Thu, Aug 03, 2017 at 10:16:42AM +0800, Guochun Mao wrote:
> Hi Cyrille,
>
> On Wed, 2017-08-02 at 17:31 +0200, Cyrille Pitchen wrote:
> > Hi Guochun,
> >
> > Le 02/08/2017 à 10:36, Boris Brezillon a écrit :
> > > Hi Matthias,
> > >
> > > On Tue, 1 Aug 2017 14:33:22 +0200
> > > Matthias Brugger <matthias.bgg@gmail.com> wrote:
> > >
> > >> On 07/25/2017 04:10 AM, Guochun Mao wrote:
> > >>> Add "mediatek,mt2712-nor" and "mediatek,mt7622-nor"
> > >>> for nor flash node's compatible strings.
> > >>>
> > >>> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> > >>> Signed-off-by: Guochun Mao <guochun.mao@mediatek.com>
> > >>> ---
> > >>> .../devicetree/bindings/mtd/mtk-quadspi.txt | 2 ++
> > >>> 1 file changed, 2 insertions(+)
> > >>>
> > >>> diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> > >>> index 5ded66a..9845ff4 100644
> > >>> --- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> > >>> +++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> > >>> @@ -3,6 +3,8 @@
> > >>> Required properties:
> > >>> - compatible: The possible values are:
> > >>> "mediatek,mt2701-nor"
> > >>> + "mediatek,mt2712-nor"
> > >>> + "mediatek,mt7622-nor"
> > >>> "mediatek,mt7623-nor"
> > >>> "mediatek,mt8173-nor"
> > >>> For mt8173, compatible should be "mediatek,mt8173-nor".
> > >>>
> >
> > There should be another patch to update the mtk_nor_of_ids[] array in
> > the mtk-quadspi.c driver, shouldn't it?
> >
> > Currently, I only see the "mediatek,mt8173-nor" compatible string at the
> > driver side. The driver and its documentation should be aligned and both
> > patches should be applied at the same time.
>
> > Best regards,
> >
> > Cyrille
>
>
> From my designer's info, these IPs' nor controller could use same
> driver, and I had verified it. I think there's no need to update
> mtk_nor_of_ids[], unless we find difference between these IPs(exactly
> compared with mt8173).
> How do you think?
That is perfectly fine, but then the documentation needs to be explicit
as to what are the fallback compatibles. It's one valid combination per
line, not 1 compatible string per line.
Rob
>
> And, we will add dts patches for new SOCs, are these patches should
> applied with this documentation?
>
> Best regards,
> Guochun
>
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] dt-bindings: mtd: add new compatible strings for mtk nor controller
@ 2017-08-03 17:47 ` Rob Herring
0 siblings, 0 replies; 26+ messages in thread
From: Rob Herring @ 2017-08-03 17:47 UTC (permalink / raw)
To: Guochun Mao
Cc: Cyrille Pitchen, Boris Brezillon, Matthias Brugger, Marek Vasut,
Cyrille Pitchen, Mark Rutland, devicetree-u79uwXL29TY76Z2rM5mHXA,
Richard Weinberger, Russell King,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, David Woodhouse,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On Thu, Aug 03, 2017 at 10:16:42AM +0800, Guochun Mao wrote:
> Hi Cyrille,
>
> On Wed, 2017-08-02 at 17:31 +0200, Cyrille Pitchen wrote:
> > Hi Guochun,
> >
> > Le 02/08/2017 à 10:36, Boris Brezillon a écrit :
> > > Hi Matthias,
> > >
> > > On Tue, 1 Aug 2017 14:33:22 +0200
> > > Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> > >
> > >> On 07/25/2017 04:10 AM, Guochun Mao wrote:
> > >>> Add "mediatek,mt2712-nor" and "mediatek,mt7622-nor"
> > >>> for nor flash node's compatible strings.
> > >>>
> > >>> Reviewed-by: Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > >>> Signed-off-by: Guochun Mao <guochun.mao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> > >>> ---
> > >>> .../devicetree/bindings/mtd/mtk-quadspi.txt | 2 ++
> > >>> 1 file changed, 2 insertions(+)
> > >>>
> > >>> diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> > >>> index 5ded66a..9845ff4 100644
> > >>> --- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> > >>> +++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> > >>> @@ -3,6 +3,8 @@
> > >>> Required properties:
> > >>> - compatible: The possible values are:
> > >>> "mediatek,mt2701-nor"
> > >>> + "mediatek,mt2712-nor"
> > >>> + "mediatek,mt7622-nor"
> > >>> "mediatek,mt7623-nor"
> > >>> "mediatek,mt8173-nor"
> > >>> For mt8173, compatible should be "mediatek,mt8173-nor".
> > >>>
> >
> > There should be another patch to update the mtk_nor_of_ids[] array in
> > the mtk-quadspi.c driver, shouldn't it?
> >
> > Currently, I only see the "mediatek,mt8173-nor" compatible string at the
> > driver side. The driver and its documentation should be aligned and both
> > patches should be applied at the same time.
>
> > Best regards,
> >
> > Cyrille
>
>
> From my designer's info, these IPs' nor controller could use same
> driver, and I had verified it. I think there's no need to update
> mtk_nor_of_ids[], unless we find difference between these IPs(exactly
> compared with mt8173).
> How do you think?
That is perfectly fine, but then the documentation needs to be explicit
as to what are the fallback compatibles. It's one valid combination per
line, not 1 compatible string per line.
Rob
>
> And, we will add dts patches for new SOCs, are these patches should
> applied with this documentation?
>
> Best regards,
> Guochun
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH] dt-bindings: mtd: add new compatible strings for mtk nor controller
@ 2017-08-03 17:47 ` Rob Herring
0 siblings, 0 replies; 26+ messages in thread
From: Rob Herring @ 2017-08-03 17:47 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Aug 03, 2017 at 10:16:42AM +0800, Guochun Mao wrote:
> Hi Cyrille,
>
> On Wed, 2017-08-02 at 17:31 +0200, Cyrille Pitchen wrote:
> > Hi Guochun,
> >
> > Le 02/08/2017 ? 10:36, Boris Brezillon a ?crit :
> > > Hi Matthias,
> > >
> > > On Tue, 1 Aug 2017 14:33:22 +0200
> > > Matthias Brugger <matthias.bgg@gmail.com> wrote:
> > >
> > >> On 07/25/2017 04:10 AM, Guochun Mao wrote:
> > >>> Add "mediatek,mt2712-nor" and "mediatek,mt7622-nor"
> > >>> for nor flash node's compatible strings.
> > >>>
> > >>> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> > >>> Signed-off-by: Guochun Mao <guochun.mao@mediatek.com>
> > >>> ---
> > >>> .../devicetree/bindings/mtd/mtk-quadspi.txt | 2 ++
> > >>> 1 file changed, 2 insertions(+)
> > >>>
> > >>> diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> > >>> index 5ded66a..9845ff4 100644
> > >>> --- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> > >>> +++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> > >>> @@ -3,6 +3,8 @@
> > >>> Required properties:
> > >>> - compatible: The possible values are:
> > >>> "mediatek,mt2701-nor"
> > >>> + "mediatek,mt2712-nor"
> > >>> + "mediatek,mt7622-nor"
> > >>> "mediatek,mt7623-nor"
> > >>> "mediatek,mt8173-nor"
> > >>> For mt8173, compatible should be "mediatek,mt8173-nor".
> > >>>
> >
> > There should be another patch to update the mtk_nor_of_ids[] array in
> > the mtk-quadspi.c driver, shouldn't it?
> >
> > Currently, I only see the "mediatek,mt8173-nor" compatible string at the
> > driver side. The driver and its documentation should be aligned and both
> > patches should be applied at the same time.
>
> > Best regards,
> >
> > Cyrille
>
>
> From my designer's info, these IPs' nor controller could use same
> driver, and I had verified it. I think there's no need to update
> mtk_nor_of_ids[], unless we find difference between these IPs(exactly
> compared with mt8173).
> How do you think?
That is perfectly fine, but then the documentation needs to be explicit
as to what are the fallback compatibles. It's one valid combination per
line, not 1 compatible string per line.
Rob
>
> And, we will add dts patches for new SOCs, are these patches should
> applied with this documentation?
>
> Best regards,
> Guochun
>
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] dt-bindings: mtd: add new compatible strings for mtk nor controller
2017-08-03 17:47 ` Rob Herring
(?)
@ 2017-08-04 3:44 ` Guochun Mao
-1 siblings, 0 replies; 26+ messages in thread
From: Guochun Mao @ 2017-08-04 3:44 UTC (permalink / raw)
To: Rob Herring
Cc: Cyrille Pitchen, Boris Brezillon, Matthias Brugger, Marek Vasut,
Cyrille Pitchen, Mark Rutland, devicetree, Richard Weinberger,
Russell King, linux-kernel, linux-mtd, linux-mediatek,
David Woodhouse, linux-arm-kernel
On Thu, 2017-08-03 at 12:47 -0500, Rob Herring wrote:
> On Thu, Aug 03, 2017 at 10:16:42AM +0800, Guochun Mao wrote:
> > Hi Cyrille,
> >
> > On Wed, 2017-08-02 at 17:31 +0200, Cyrille Pitchen wrote:
> > > Hi Guochun,
> > >
> > > Le 02/08/2017 à 10:36, Boris Brezillon a écrit :
> > > > Hi Matthias,
> > > >
> > > > On Tue, 1 Aug 2017 14:33:22 +0200
> > > > Matthias Brugger <matthias.bgg@gmail.com> wrote:
> > > >
> > > >> On 07/25/2017 04:10 AM, Guochun Mao wrote:
> > > >>> Add "mediatek,mt2712-nor" and "mediatek,mt7622-nor"
> > > >>> for nor flash node's compatible strings.
> > > >>>
> > > >>> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> > > >>> Signed-off-by: Guochun Mao <guochun.mao@mediatek.com>
> > > >>> ---
> > > >>> .../devicetree/bindings/mtd/mtk-quadspi.txt | 2 ++
> > > >>> 1 file changed, 2 insertions(+)
> > > >>>
> > > >>> diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> > > >>> index 5ded66a..9845ff4 100644
> > > >>> --- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> > > >>> +++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> > > >>> @@ -3,6 +3,8 @@
> > > >>> Required properties:
> > > >>> - compatible: The possible values are:
> > > >>> "mediatek,mt2701-nor"
> > > >>> + "mediatek,mt2712-nor"
> > > >>> + "mediatek,mt7622-nor"
> > > >>> "mediatek,mt7623-nor"
> > > >>> "mediatek,mt8173-nor"
> > > >>> For mt8173, compatible should be "mediatek,mt8173-nor".
> > > >>>
> > >
> > > There should be another patch to update the mtk_nor_of_ids[] array in
> > > the mtk-quadspi.c driver, shouldn't it?
> > >
> > > Currently, I only see the "mediatek,mt8173-nor" compatible string at the
> > > driver side. The driver and its documentation should be aligned and both
> > > patches should be applied at the same time.
> >
> > > Best regards,
> > >
> > > Cyrille
> >
> >
> > From my designer's info, these IPs' nor controller could use same
> > driver, and I had verified it. I think there's no need to update
> > mtk_nor_of_ids[], unless we find difference between these IPs(exactly
> > compared with mt8173).
> > How do you think?
>
> That is perfectly fine, but then the documentation needs to be explicit
> as to what are the fallback compatibles. It's one valid combination per
> line, not 1 compatible string per line.
OK, I'll corret the description in next version.
Thanks a lot.
Guochun
>
> Rob
>
> >
> > And, we will add dts patches for new SOCs, are these patches should
> > applied with this documentation?
> >
> > Best regards,
> > Guochun
> >
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] dt-bindings: mtd: add new compatible strings for mtk nor controller
@ 2017-08-04 3:44 ` Guochun Mao
0 siblings, 0 replies; 26+ messages in thread
From: Guochun Mao @ 2017-08-04 3:44 UTC (permalink / raw)
To: Rob Herring
Cc: Cyrille Pitchen, Boris Brezillon, Matthias Brugger, Marek Vasut,
Cyrille Pitchen, Mark Rutland, devicetree-u79uwXL29TY76Z2rM5mHXA,
Richard Weinberger, Russell King,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, David Woodhouse,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On Thu, 2017-08-03 at 12:47 -0500, Rob Herring wrote:
> On Thu, Aug 03, 2017 at 10:16:42AM +0800, Guochun Mao wrote:
> > Hi Cyrille,
> >
> > On Wed, 2017-08-02 at 17:31 +0200, Cyrille Pitchen wrote:
> > > Hi Guochun,
> > >
> > > Le 02/08/2017 à 10:36, Boris Brezillon a écrit :
> > > > Hi Matthias,
> > > >
> > > > On Tue, 1 Aug 2017 14:33:22 +0200
> > > > Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> > > >
> > > >> On 07/25/2017 04:10 AM, Guochun Mao wrote:
> > > >>> Add "mediatek,mt2712-nor" and "mediatek,mt7622-nor"
> > > >>> for nor flash node's compatible strings.
> > > >>>
> > > >>> Reviewed-by: Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > > >>> Signed-off-by: Guochun Mao <guochun.mao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> > > >>> ---
> > > >>> .../devicetree/bindings/mtd/mtk-quadspi.txt | 2 ++
> > > >>> 1 file changed, 2 insertions(+)
> > > >>>
> > > >>> diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> > > >>> index 5ded66a..9845ff4 100644
> > > >>> --- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> > > >>> +++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> > > >>> @@ -3,6 +3,8 @@
> > > >>> Required properties:
> > > >>> - compatible: The possible values are:
> > > >>> "mediatek,mt2701-nor"
> > > >>> + "mediatek,mt2712-nor"
> > > >>> + "mediatek,mt7622-nor"
> > > >>> "mediatek,mt7623-nor"
> > > >>> "mediatek,mt8173-nor"
> > > >>> For mt8173, compatible should be "mediatek,mt8173-nor".
> > > >>>
> > >
> > > There should be another patch to update the mtk_nor_of_ids[] array in
> > > the mtk-quadspi.c driver, shouldn't it?
> > >
> > > Currently, I only see the "mediatek,mt8173-nor" compatible string at the
> > > driver side. The driver and its documentation should be aligned and both
> > > patches should be applied at the same time.
> >
> > > Best regards,
> > >
> > > Cyrille
> >
> >
> > From my designer's info, these IPs' nor controller could use same
> > driver, and I had verified it. I think there's no need to update
> > mtk_nor_of_ids[], unless we find difference between these IPs(exactly
> > compared with mt8173).
> > How do you think?
>
> That is perfectly fine, but then the documentation needs to be explicit
> as to what are the fallback compatibles. It's one valid combination per
> line, not 1 compatible string per line.
OK, I'll corret the description in next version.
Thanks a lot.
Guochun
>
> Rob
>
> >
> > And, we will add dts patches for new SOCs, are these patches should
> > applied with this documentation?
> >
> > Best regards,
> > Guochun
> >
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH] dt-bindings: mtd: add new compatible strings for mtk nor controller
@ 2017-08-04 3:44 ` Guochun Mao
0 siblings, 0 replies; 26+ messages in thread
From: Guochun Mao @ 2017-08-04 3:44 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, 2017-08-03 at 12:47 -0500, Rob Herring wrote:
> On Thu, Aug 03, 2017 at 10:16:42AM +0800, Guochun Mao wrote:
> > Hi Cyrille,
> >
> > On Wed, 2017-08-02 at 17:31 +0200, Cyrille Pitchen wrote:
> > > Hi Guochun,
> > >
> > > Le 02/08/2017 ? 10:36, Boris Brezillon a ?crit :
> > > > Hi Matthias,
> > > >
> > > > On Tue, 1 Aug 2017 14:33:22 +0200
> > > > Matthias Brugger <matthias.bgg@gmail.com> wrote:
> > > >
> > > >> On 07/25/2017 04:10 AM, Guochun Mao wrote:
> > > >>> Add "mediatek,mt2712-nor" and "mediatek,mt7622-nor"
> > > >>> for nor flash node's compatible strings.
> > > >>>
> > > >>> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> > > >>> Signed-off-by: Guochun Mao <guochun.mao@mediatek.com>
> > > >>> ---
> > > >>> .../devicetree/bindings/mtd/mtk-quadspi.txt | 2 ++
> > > >>> 1 file changed, 2 insertions(+)
> > > >>>
> > > >>> diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> > > >>> index 5ded66a..9845ff4 100644
> > > >>> --- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> > > >>> +++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> > > >>> @@ -3,6 +3,8 @@
> > > >>> Required properties:
> > > >>> - compatible: The possible values are:
> > > >>> "mediatek,mt2701-nor"
> > > >>> + "mediatek,mt2712-nor"
> > > >>> + "mediatek,mt7622-nor"
> > > >>> "mediatek,mt7623-nor"
> > > >>> "mediatek,mt8173-nor"
> > > >>> For mt8173, compatible should be "mediatek,mt8173-nor".
> > > >>>
> > >
> > > There should be another patch to update the mtk_nor_of_ids[] array in
> > > the mtk-quadspi.c driver, shouldn't it?
> > >
> > > Currently, I only see the "mediatek,mt8173-nor" compatible string at the
> > > driver side. The driver and its documentation should be aligned and both
> > > patches should be applied at the same time.
> >
> > > Best regards,
> > >
> > > Cyrille
> >
> >
> > From my designer's info, these IPs' nor controller could use same
> > driver, and I had verified it. I think there's no need to update
> > mtk_nor_of_ids[], unless we find difference between these IPs(exactly
> > compared with mt8173).
> > How do you think?
>
> That is perfectly fine, but then the documentation needs to be explicit
> as to what are the fallback compatibles. It's one valid combination per
> line, not 1 compatible string per line.
OK, I'll corret the description in next version.
Thanks a lot.
Guochun
>
> Rob
>
> >
> > And, we will add dts patches for new SOCs, are these patches should
> > applied with this documentation?
> >
> > Best regards,
> > Guochun
> >
^ permalink raw reply [flat|nested] 26+ messages in thread
end of thread, other threads:[~2017-08-04 3:44 UTC | newest]
Thread overview: 26+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-25 2:10 [PATCH v4 1/1] add new compatible strings for mtk nor controller Guochun Mao
2017-07-25 2:10 ` Guochun Mao
2017-07-25 2:10 ` Guochun Mao
2017-07-25 2:10 ` [PATCH] dt-bindings: mtd: " Guochun Mao
2017-07-25 2:10 ` Guochun Mao
2017-07-25 2:10 ` Guochun Mao
2017-08-01 12:33 ` Matthias Brugger
2017-08-01 12:33 ` Matthias Brugger
2017-08-01 12:33 ` Matthias Brugger
2017-08-02 8:36 ` Boris Brezillon
2017-08-02 8:36 ` Boris Brezillon
2017-08-02 8:36 ` Boris Brezillon
2017-08-02 15:31 ` Cyrille Pitchen
2017-08-02 15:31 ` Cyrille Pitchen
2017-08-02 15:31 ` Cyrille Pitchen
2017-08-03 2:16 ` Guochun Mao
2017-08-03 2:16 ` Guochun Mao
2017-08-03 2:16 ` Guochun Mao
2017-08-03 10:09 ` Matthias Brugger
2017-08-03 10:09 ` Matthias Brugger
2017-08-03 17:47 ` Rob Herring
2017-08-03 17:47 ` Rob Herring
2017-08-03 17:47 ` Rob Herring
2017-08-04 3:44 ` Guochun Mao
2017-08-04 3:44 ` Guochun Mao
2017-08-04 3:44 ` Guochun Mao
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.