* [PATCH] thunderbolt: constify attribute_group structure
@ 2017-08-05 1:42 Amitoj Kaur Chawla
2017-08-05 8:35 ` Mika Westerberg
0 siblings, 1 reply; 2+ messages in thread
From: Amitoj Kaur Chawla @ 2017-08-05 1:42 UTC (permalink / raw)
To: andreas.noever, michael.jamet, mika.westerberg, yehezkel.bernat,
linux-kernel
Functions working with attribute_groups provided by <linux/device.h>
work with const attribute_group. These attribute_group structures do not
change at runtime so mark them as const.
File size before:
text data bss dec hex filename
28565 7300 0 35865 8c19 drivers/thunderbolt/switch.o
File size after:
text data bss dec hex filename
28661 7204 0 35865 8c19 drivers/thunderbolt/switch.o
This change was made with the help of Coccinelle.
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
drivers/thunderbolt/switch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thunderbolt/switch.c b/drivers/thunderbolt/switch.c
index e9391bb..6cd4f14 100644
--- a/drivers/thunderbolt/switch.c
+++ b/drivers/thunderbolt/switch.c
@@ -970,7 +970,7 @@ static umode_t switch_attr_is_visible(struct kobject *kobj,
return sw->safe_mode ? 0 : attr->mode;
}
-static struct attribute_group switch_group = {
+static const struct attribute_group switch_group = {
.is_visible = switch_attr_is_visible,
.attrs = switch_attrs,
};
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] thunderbolt: constify attribute_group structure
2017-08-05 1:42 [PATCH] thunderbolt: constify attribute_group structure Amitoj Kaur Chawla
@ 2017-08-05 8:35 ` Mika Westerberg
0 siblings, 0 replies; 2+ messages in thread
From: Mika Westerberg @ 2017-08-05 8:35 UTC (permalink / raw)
To: Amitoj Kaur Chawla
Cc: andreas.noever, michael.jamet, yehezkel.bernat, linux-kernel,
Greg Kroah-Hartman
On Fri, Aug 04, 2017 at 09:42:09PM -0400, Amitoj Kaur Chawla wrote:
> Functions working with attribute_groups provided by <linux/device.h>
> work with const attribute_group. These attribute_group structures do not
> change at runtime so mark them as const.
>
> File size before:
> text data bss dec hex filename
> 28565 7300 0 35865 8c19 drivers/thunderbolt/switch.o
>
> File size after:
> text data bss dec hex filename
> 28661 7204 0 35865 8c19 drivers/thunderbolt/switch.o
>
> This change was made with the help of Coccinelle.
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Unfortunately you forgot to Cc Greg. He has been gathering Thunderbolt
related patches. I added him now but it may be that you need to resend
the patch to make it easier for him to apply.
> ---
> drivers/thunderbolt/switch.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thunderbolt/switch.c b/drivers/thunderbolt/switch.c
> index e9391bb..6cd4f14 100644
> --- a/drivers/thunderbolt/switch.c
> +++ b/drivers/thunderbolt/switch.c
> @@ -970,7 +970,7 @@ static umode_t switch_attr_is_visible(struct kobject *kobj,
> return sw->safe_mode ? 0 : attr->mode;
> }
>
> -static struct attribute_group switch_group = {
> +static const struct attribute_group switch_group = {
> .is_visible = switch_attr_is_visible,
> .attrs = switch_attrs,
> };
> --
> 2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-05 8:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-05 1:42 [PATCH] thunderbolt: constify attribute_group structure Amitoj Kaur Chawla
2017-08-05 8:35 ` Mika Westerberg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.