* [PATCH] pnfs/blocklayout: require 64-bit ѕector_t
@ 2017-08-05 8:59 Christoph Hellwig
2017-08-11 15:14 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2017-08-05 8:59 UTC (permalink / raw)
To: linux-nfs; +Cc: Arnd Bergmann
The blocklayout code does not compile cleanly for a 32-bit sector_t,
and also has no reliable checks for devices sizes, which makes it
unsafe to use with a kernel that doesn't support large block devices.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reported-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 5c83746a0cf2 ("pnfs/blocklayout: in-kernel GETDEVICEINFO XDR parsing")
---
fs/nfs/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/nfs/Kconfig b/fs/nfs/Kconfig
index 69d02cf8cf37..5f93cfacb3d1 100644
--- a/fs/nfs/Kconfig
+++ b/fs/nfs/Kconfig
@@ -121,6 +121,7 @@ config PNFS_FILE_LAYOUT
config PNFS_BLOCK
tristate
depends on NFS_V4_1 && BLK_DEV_DM
+ depends on 64BIT || LBDAF
default NFS_V4
config PNFS_FLEXFILE_LAYOUT
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pnfs/blocklayout: require 64-bit ѕector_t
2017-08-05 8:59 [PATCH] pnfs/blocklayout: require 64-bit ѕector_t Christoph Hellwig
@ 2017-08-11 15:14 ` Christoph Hellwig
2017-08-11 19:00 ` Anna Schumaker
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2017-08-11 15:14 UTC (permalink / raw)
To: Trond Myklebust, Anna Schumaker, linux-nfs; +Cc: Arnd Bergmann
Trond, Anna,
can you pick this up? Maybe even for 3.13 given that it should
be pretty harmless for 98% of the configfs, and will prevent problems
for the others.
On Sat, Aug 05, 2017 at 10:59:14AM +0200, Christoph Hellwig wrote:
> The blocklayout code does not compile cleanly for a 32-bit sector_t,
> and also has no reliable checks for devices sizes, which makes it
> unsafe to use with a kernel that doesn't support large block devices.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 5c83746a0cf2 ("pnfs/blocklayout: in-kernel GETDEVICEINFO XDR parsing")
> ---
> fs/nfs/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/nfs/Kconfig b/fs/nfs/Kconfig
> index 69d02cf8cf37..5f93cfacb3d1 100644
> --- a/fs/nfs/Kconfig
> +++ b/fs/nfs/Kconfig
> @@ -121,6 +121,7 @@ config PNFS_FILE_LAYOUT
> config PNFS_BLOCK
> tristate
> depends on NFS_V4_1 && BLK_DEV_DM
> + depends on 64BIT || LBDAF
> default NFS_V4
>
> config PNFS_FLEXFILE_LAYOUT
> --
> 2.11.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
---end quoted text---
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pnfs/blocklayout: require 64-bit ѕector_t
2017-08-11 15:14 ` Christoph Hellwig
@ 2017-08-11 19:00 ` Anna Schumaker
0 siblings, 0 replies; 3+ messages in thread
From: Anna Schumaker @ 2017-08-11 19:00 UTC (permalink / raw)
To: Christoph Hellwig, Trond Myklebust, linux-nfs; +Cc: Arnd Bergmann
Hi Christoph,
On 08/11/2017 11:14 AM, Christoph Hellwig wrote:
> Trond, Anna,
>
> can you pick this up? Maybe even for 3.13 given that it should
> be pretty harmless for 98% of the configfs, and will prevent problems
> for the others.
The patch looks okay to me, so I'll take it for the next rc.
Anna
>
> On Sat, Aug 05, 2017 at 10:59:14AM +0200, Christoph Hellwig wrote:
>> The blocklayout code does not compile cleanly for a 32-bit sector_t,
>> and also has no reliable checks for devices sizes, which makes it
>> unsafe to use with a kernel that doesn't support large block devices.
>>
>> Signed-off-by: Christoph Hellwig <hch@lst.de>
>> Reported-by: Arnd Bergmann <arnd@arndb.de>
>> Fixes: 5c83746a0cf2 ("pnfs/blocklayout: in-kernel GETDEVICEINFO XDR parsing")
>> ---
>> fs/nfs/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/fs/nfs/Kconfig b/fs/nfs/Kconfig
>> index 69d02cf8cf37..5f93cfacb3d1 100644
>> --- a/fs/nfs/Kconfig
>> +++ b/fs/nfs/Kconfig
>> @@ -121,6 +121,7 @@ config PNFS_FILE_LAYOUT
>> config PNFS_BLOCK
>> tristate
>> depends on NFS_V4_1 && BLK_DEV_DM
>> + depends on 64BIT || LBDAF
>> default NFS_V4
>>
>> config PNFS_FLEXFILE_LAYOUT
>> --
>> 2.11.0
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> ---end quoted text---
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-11 19:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-05 8:59 [PATCH] pnfs/blocklayout: require 64-bit ѕector_t Christoph Hellwig
2017-08-11 15:14 ` Christoph Hellwig
2017-08-11 19:00 ` Anna Schumaker
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.