* [PATCH] Fix missing PCI ID (thanks to CoolStar); Necessary for Lenovo Yoga 720-15 Touchpad
@ 2017-08-01 1:47 Hoeze
2017-08-07 7:57 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Hoeze @ 2017-08-01 1:47 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, git.ich
---
This patch fixes a missing PCI ID which is necessary for the Lenovo Yoga 720-15 Touchpad to work.
See this bug report on Launchpad:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1700657
Many thanks to CoolStar, who found this solution!
drivers/mfd/intel-lpss-pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
index 16ffeaeb1385..867df181d475 100644
--- a/drivers/mfd/intel-lpss-pci.c
+++ b/drivers/mfd/intel-lpss-pci.c
@@ -208,6 +208,7 @@ static const struct pci_device_id intel_lpss_pci_ids[] = {
{ PCI_VDEVICE(INTEL, 0xa12a), (kernel_ulong_t)&spt_info },
{ PCI_VDEVICE(INTEL, 0xa160), (kernel_ulong_t)&spt_i2c_info },
{ PCI_VDEVICE(INTEL, 0xa161), (kernel_ulong_t)&spt_i2c_info },
+ { PCI_VDEVICE(INTEL, 0xa162), (kernel_ulong_t)&spt_i2c_info },
{ PCI_VDEVICE(INTEL, 0xa166), (kernel_ulong_t)&spt_uart_info },
/* KBL-H */
{ PCI_VDEVICE(INTEL, 0xa2a7), (kernel_ulong_t)&spt_uart_info },
--
2.13.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix missing PCI ID (thanks to CoolStar); Necessary for Lenovo Yoga 720-15 Touchpad
2017-08-01 1:47 [PATCH] Fix missing PCI ID (thanks to CoolStar); Necessary for Lenovo Yoga 720-15 Touchpad Hoeze
@ 2017-08-07 7:57 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2017-08-07 7:57 UTC (permalink / raw)
To: Hoeze; +Cc: linux-kernel
Subject line looks wrong. To see the format expected please use:
`git log --oneline -- drivers/mfd`
You are missing your SoB.
> ---
> This patch fixes a missing PCI ID which is necessary for the Lenovo Yoga 720-15 Touchpad to work.
This should be in the commit log above.
> See this bug report on Launchpad:
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1700657
Drop external links to LP please.
> Many thanks to CoolStar, who found this solution!
This should be a "Reported-by".
Please see Documentation/SubmittingPatches' for more details.
> drivers/mfd/intel-lpss-pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
> index 16ffeaeb1385..867df181d475 100644
> --- a/drivers/mfd/intel-lpss-pci.c
> +++ b/drivers/mfd/intel-lpss-pci.c
> @@ -208,6 +208,7 @@ static const struct pci_device_id intel_lpss_pci_ids[] = {
> { PCI_VDEVICE(INTEL, 0xa12a), (kernel_ulong_t)&spt_info },
> { PCI_VDEVICE(INTEL, 0xa160), (kernel_ulong_t)&spt_i2c_info },
> { PCI_VDEVICE(INTEL, 0xa161), (kernel_ulong_t)&spt_i2c_info },
> + { PCI_VDEVICE(INTEL, 0xa162), (kernel_ulong_t)&spt_i2c_info },
The tabbing looks wrong here.
> { PCI_VDEVICE(INTEL, 0xa166), (kernel_ulong_t)&spt_uart_info },
> /* KBL-H */
> { PCI_VDEVICE(INTEL, 0xa2a7), (kernel_ulong_t)&spt_uart_info },
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-07 7:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-01 1:47 [PATCH] Fix missing PCI ID (thanks to CoolStar); Necessary for Lenovo Yoga 720-15 Touchpad Hoeze
2017-08-07 7:57 ` Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.