* [PATCH] ARM:dts:armadillo800eva: Add console parametters
@ 2017-08-06 13:55 ` Bui Duc Phuc (Fukuda)
0 siblings, 0 replies; 16+ messages in thread
From: Bui Duc Phuc (Fukuda) @ 2017-08-06 13:55 UTC (permalink / raw)
To: geert+renesas, horms
Cc: devicetree, linux-arm-kernel, linux-sh, linux-renesas-soc,
linux-arm-kernel, laurent.pinchart+renesas, magnus.damm,
kuninori.morimoto.gx, yoshihiro.shimoda.uh
From: Bui Duc Phuc <phucduc.bui@gmail.com>
Hi, Everyone!
I have a patch for the armadillo board device-tree.
Please consider this patch.
Best regards.
Bui Duc Phuc (1):
ARM:dts:armadillo800eva: Add console parametters
arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--
2.7.4
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] ARM:dts:armadillo800eva: Add console parametters
@ 2017-08-06 13:55 ` Bui Duc Phuc (Fukuda)
0 siblings, 0 replies; 16+ messages in thread
From: Bui Duc Phuc (Fukuda) @ 2017-08-06 13:55 UTC (permalink / raw)
To: linux-arm-kernel
From: Bui Duc Phuc <phucduc.bui@gmail.com>
Hi, Everyone!
I have a patch for the armadillo board device-tree.
Please consider this patch.
Best regards.
Bui Duc Phuc (1):
ARM:dts:armadillo800eva: Add console parametters
arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--
2.7.4
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] ARM:dts:armadillo800eva: Add console parametters
@ 2017-08-06 13:55 ` Bui Duc Phuc (Fukuda)
0 siblings, 0 replies; 16+ messages in thread
From: Bui Duc Phuc (Fukuda) @ 2017-08-06 13:55 UTC (permalink / raw)
To: linux-arm-kernel
From: Bui Duc Phuc <phucduc.bui@gmail.com>
Hi, Everyone!
I have a patch for the armadillo board device-tree.
Please consider this patch.
Best regards.
Bui Duc Phuc (1):
ARM:dts:armadillo800eva: Add console parametters
arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--
2.7.4
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] ARM:dts:armadillo800eva: Add console parametters
2017-08-06 13:55 ` Bui Duc Phuc (Fukuda)
(?)
(?)
@ 2017-08-06 13:55 ` Bui Duc Phuc (Fukuda)
-1 siblings, 0 replies; 16+ messages in thread
From: Bui Duc Phuc (Fukuda) @ 2017-08-06 13:55 UTC (permalink / raw)
To: geert+renesas, horms
Cc: devicetree, linux-arm-kernel, linux-sh, linux-renesas-soc,
linux-arm-kernel, laurent.pinchart+renesas, magnus.damm,
kuninori.morimoto.gx, yoshihiro.shimoda.uh
From: Bui Duc Phuc <phucduc.bui@gmail.com>
After the kernel boot, the login prompt doesn't appear.
This patch will add console parametters to bootargs to fix it.
Signed-off-by: Bui Duc Phuc <phucduc.bui@gmail.com>
---
arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
index 1788e18..d383b37 100644
--- a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
+++ b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
@@ -24,7 +24,8 @@
};
chosen {
- bootargs = "earlyprintk ignore_loglevel root=/dev/nfs ip=dhcp rw";
+ bootargs = "console=tty0 console=ttySC0,115200 earlyprintk
+ ignore_loglevel root=/dev/nfs ip=dhcp rw";
stdout-path = "serial0:115200n8";
};
--
2.7.4
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH] ARM:dts:armadillo800eva: Add console parametters
@ 2017-08-06 13:55 ` Bui Duc Phuc (Fukuda)
0 siblings, 0 replies; 16+ messages in thread
From: Bui Duc Phuc (Fukuda) @ 2017-08-06 13:55 UTC (permalink / raw)
To: linux-arm-kernel
From: Bui Duc Phuc <phucduc.bui@gmail.com>
After the kernel boot, the login prompt doesn't appear.
This patch will add console parametters to bootargs to fix it.
Signed-off-by: Bui Duc Phuc <phucduc.bui@gmail.com>
---
arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
index 1788e18..d383b37 100644
--- a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
+++ b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
@@ -24,7 +24,8 @@
};
chosen {
- bootargs = "earlyprintk ignore_loglevel root=/dev/nfs ip=dhcp rw";
+ bootargs = "console=tty0 console=ttySC0,115200 earlyprintk
+ ignore_loglevel root=/dev/nfs ip=dhcp rw";
stdout-path = "serial0:115200n8";
};
--
2.7.4
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH] ARM:dts:armadillo800eva: Add console parametters
@ 2017-08-06 13:55 ` Bui Duc Phuc (Fukuda)
0 siblings, 0 replies; 16+ messages in thread
From: Bui Duc Phuc (Fukuda) @ 2017-08-06 13:55 UTC (permalink / raw)
To: geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ, horms-/R6kz+dDXgpPR4JQBCEnsQ
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-sh-u79uwXL29TY76Z2rM5mHXA,
linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-u79uwXL29TY76Z2rM5mHXA,
laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw,
magnus.damm-Re5JQEeQqe8AvxtiuMwx3w,
kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ,
yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ
From: Bui Duc Phuc <phucduc.bui-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
After the kernel boot, the login prompt doesn't appear.
This patch will add console parametters to bootargs to fix it.
Signed-off-by: Bui Duc Phuc <phucduc.bui-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
index 1788e18..d383b37 100644
--- a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
+++ b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
@@ -24,7 +24,8 @@
};
chosen {
- bootargs = "earlyprintk ignore_loglevel root=/dev/nfs ip=dhcp rw";
+ bootargs = "console=tty0 console=ttySC0,115200 earlyprintk
+ ignore_loglevel root=/dev/nfs ip=dhcp rw";
stdout-path = "serial0:115200n8";
};
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH] ARM:dts:armadillo800eva: Add console parametters
@ 2017-08-06 13:55 ` Bui Duc Phuc (Fukuda)
0 siblings, 0 replies; 16+ messages in thread
From: Bui Duc Phuc (Fukuda) @ 2017-08-06 13:55 UTC (permalink / raw)
To: linux-arm-kernel
From: Bui Duc Phuc <phucduc.bui@gmail.com>
After the kernel boot, the login prompt doesn't appear.
This patch will add console parametters to bootargs to fix it.
Signed-off-by: Bui Duc Phuc <phucduc.bui@gmail.com>
---
arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
index 1788e18..d383b37 100644
--- a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
+++ b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
@@ -24,7 +24,8 @@
};
chosen {
- bootargs = "earlyprintk ignore_loglevel root=/dev/nfs ip=dhcp rw";
+ bootargs = "console=tty0 console=ttySC0,115200 earlyprintk
+ ignore_loglevel root=/dev/nfs ip=dhcp rw";
stdout-path = "serial0:115200n8";
};
--
2.7.4
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH] ARM:dts:armadillo800eva: Add console parametters
2017-08-06 13:55 ` Bui Duc Phuc (Fukuda)
(?)
@ 2017-08-07 7:59 ` Simon Horman
-1 siblings, 0 replies; 16+ messages in thread
From: Simon Horman @ 2017-08-07 7:59 UTC (permalink / raw)
To: Bui Duc Phuc (Fukuda)
Cc: geert+renesas, devicetree, linux-arm-kernel, linux-sh,
linux-renesas-soc, linux-arm-kernel, laurent.pinchart+renesas,
magnus.damm, kuninori.morimoto.gx, yoshihiro.shimoda.uh
On Sun, Aug 06, 2017 at 08:55:02PM +0700, Bui Duc Phuc (Fukuda) wrote:
> From: Bui Duc Phuc <phucduc.bui@gmail.com>
>
> After the kernel boot, the login prompt doesn't appear.
> This patch will add console parametters to bootargs to fix it.
>
> Signed-off-by: Bui Duc Phuc <phucduc.bui@gmail.com>
> ---
> arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
> index 1788e18..d383b37 100644
> --- a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
> +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
> @@ -24,7 +24,8 @@
> };
>
> chosen {
> - bootargs = "earlyprintk ignore_loglevel root=/dev/nfs ip=dhcp rw";
> + bootargs = "console=tty0 console=ttySC0,115200 earlyprintk
> + ignore_loglevel root=/dev/nfs ip=dhcp rw";
> stdout-path = "serial0:115200n8";
> };
Hi,
this feels wrong. My understanding is that stdout-path should be enough
to get the console.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] ARM:dts:armadillo800eva: Add console parametters
@ 2017-08-07 7:59 ` Simon Horman
0 siblings, 0 replies; 16+ messages in thread
From: Simon Horman @ 2017-08-07 7:59 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Aug 06, 2017 at 08:55:02PM +0700, Bui Duc Phuc (Fukuda) wrote:
> From: Bui Duc Phuc <phucduc.bui@gmail.com>
>
> After the kernel boot, the login prompt doesn't appear.
> This patch will add console parametters to bootargs to fix it.
>
> Signed-off-by: Bui Duc Phuc <phucduc.bui@gmail.com>
> ---
> arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
> index 1788e18..d383b37 100644
> --- a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
> +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
> @@ -24,7 +24,8 @@
> };
>
> chosen {
> - bootargs = "earlyprintk ignore_loglevel root=/dev/nfs ip=dhcp rw";
> + bootargs = "console=tty0 console=ttySC0,115200 earlyprintk
> + ignore_loglevel root=/dev/nfs ip=dhcp rw";
> stdout-path = "serial0:115200n8";
> };
Hi,
this feels wrong. My understanding is that stdout-path should be enough
to get the console.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] ARM:dts:armadillo800eva: Add console parametters
@ 2017-08-07 7:59 ` Simon Horman
0 siblings, 0 replies; 16+ messages in thread
From: Simon Horman @ 2017-08-07 7:59 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Aug 06, 2017 at 08:55:02PM +0700, Bui Duc Phuc (Fukuda) wrote:
> From: Bui Duc Phuc <phucduc.bui@gmail.com>
>
> After the kernel boot, the login prompt doesn't appear.
> This patch will add console parametters to bootargs to fix it.
>
> Signed-off-by: Bui Duc Phuc <phucduc.bui@gmail.com>
> ---
> arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
> index 1788e18..d383b37 100644
> --- a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
> +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
> @@ -24,7 +24,8 @@
> };
>
> chosen {
> - bootargs = "earlyprintk ignore_loglevel root=/dev/nfs ip=dhcp rw";
> + bootargs = "console=tty0 console=ttySC0,115200 earlyprintk
> + ignore_loglevel root=/dev/nfs ip=dhcp rw";
> stdout-path = "serial0:115200n8";
> };
Hi,
this feels wrong. My understanding is that stdout-path should be enough
to get the console.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] ARM:dts:armadillo800eva: Add console parametters
[not found] ` <CAABR9nHUuSw7m6BCBxDs28YtppHxwHNQR5f06H0n8xcXKx7gCw@mail.gmail.com>
2017-08-10 8:12 ` Kuninori Morimoto
@ 2017-08-10 8:12 ` Kuninori Morimoto
0 siblings, 0 replies; 16+ messages in thread
From: Kuninori Morimoto @ 2017-08-10 8:12 UTC (permalink / raw)
To: Bui Duc Phuc, Simon Horman
Cc: geert+renesas, devicetree, linux-arm-kernel, linux-sh,
linux-renesas-soc, linux-arm-kernel, laurent.pinchart+renesas,
Magnus Damm, Yoshihiro Shimoda
Hi Simon
> > chosen {
> > - bootargs = "earlyprintk ignore_loglevel root=/dev/nfs ip=dhcp rw";
> > + bootargs = "console=tty0 console=ttySC0,115200 earlyprintk
> > + ignore_loglevel root=/dev/nfs ip=dhcp rw";
> > stdout-path = "serial0:115200n8";
> > };
>
> Hi,
>
> this feels wrong. My understanding is that stdout-path should be enough
> to get the console.
(snip)
> Thank you for your comment.
> Before creating this patch, I have a patch reference of you and Geert.
> https://patchwork.kernel.org/patch/5184001/
I think he want to say here is that it needs "console=" which
is indicated by Geert on https://patchwork.kernel.org/patch/5184001/
"Note that we have to keep the "console=ttySC1" parameter in
chosen/bootargs, ..."
I don't have armadillo800eva anymore, so I can't test this patch.
But according to Phuc-san, there is not command prompt after boot
without this patch.
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] ARM:dts:armadillo800eva: Add console parametters
@ 2017-08-10 8:12 ` Kuninori Morimoto
0 siblings, 0 replies; 16+ messages in thread
From: Kuninori Morimoto @ 2017-08-10 8:12 UTC (permalink / raw)
To: linux-arm-kernel
Hi Simon
> > chosen {
> > - bootargs = "earlyprintk ignore_loglevel root=/dev/nfs ip=dhcp rw";
> > + bootargs = "console=tty0 console=ttySC0,115200 earlyprintk
> > + ignore_loglevel root=/dev/nfs ip=dhcp rw";
> > stdout-path = "serial0:115200n8";
> > };
>
> Hi,
>
> this feels wrong. My understanding is that stdout-path should be enough
> to get the console.
(snip)
> Thank you for your comment.
> Before creating this patch, I have a patch reference of you and Geert.
> https://patchwork.kernel.org/patch/5184001/
I think he want to say here is that it needs "console=" which
is indicated by Geert on https://patchwork.kernel.org/patch/5184001/
"Note that we have to keep the "console=ttySC1" parameter in
chosen/bootargs, ..."
I don't have armadillo800eva anymore, so I can't test this patch.
But according to Phuc-san, there is not command prompt after boot
without this patch.
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] ARM:dts:armadillo800eva: Add console parametters
@ 2017-08-10 8:12 ` Kuninori Morimoto
0 siblings, 0 replies; 16+ messages in thread
From: Kuninori Morimoto @ 2017-08-10 8:12 UTC (permalink / raw)
To: linux-arm-kernel
Hi Simon
> > chosen {
> > - bootargs = "earlyprintk ignore_loglevel root=/dev/nfs ip=dhcp rw";
> > + bootargs = "console=tty0 console=ttySC0,115200 earlyprintk
> > + ignore_loglevel root=/dev/nfs ip=dhcp rw";
> > stdout-path = "serial0:115200n8";
> > };
>
> Hi,
>
> this feels wrong. My understanding is that stdout-path should be enough
> to get the console.
(snip)
> Thank you for your comment.
> Before creating this patch, I have a patch reference of you and Geert.
> https://patchwork.kernel.org/patch/5184001/
I think he want to say here is that it needs "console=" which
is indicated by Geert on https://patchwork.kernel.org/patch/5184001/
"Note that we have to keep the "console=ttySC1" parameter in
chosen/bootargs, ..."
I don't have armadillo800eva anymore, so I can't test this patch.
But according to Phuc-san, there is not command prompt after boot
without this patch.
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] ARM:dts:armadillo800eva: Add console parametters
2017-08-10 8:12 ` Kuninori Morimoto
(?)
@ 2017-08-10 8:25 ` Geert Uytterhoeven
-1 siblings, 0 replies; 16+ messages in thread
From: Geert Uytterhoeven @ 2017-08-10 8:25 UTC (permalink / raw)
To: Kuninori Morimoto
Cc: Bui Duc Phuc, Simon Horman, Geert Uytterhoeven, devicetree,
linux-arm-kernel, Linux-sh list, Linux-Renesas, linux-arm-kernel,
Laurent Pinchart, Magnus Damm, Yoshihiro Shimoda
Hi Morimoto-san, Phuc-san,
On Thu, Aug 10, 2017 at 10:12 AM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
>> > chosen {
>> > - bootargs = "earlyprintk ignore_loglevel root=/dev/nfs ip=dhcp rw";
>> > + bootargs = "console=tty0 console=ttySC0,115200 earlyprintk
>> > + ignore_loglevel root=/dev/nfs ip=dhcp rw";
>> > stdout-path = "serial0:115200n8";
>> > };
>>
>> Hi,
>>
>> this feels wrong. My understanding is that stdout-path should be enough
>> to get the console.
> (snip)
>> Thank you for your comment.
>> Before creating this patch, I have a patch reference of you and Geert.
>> https://patchwork.kernel.org/patch/5184001/
>
> I think he want to say here is that it needs "console=" which
> is indicated by Geert on https://patchwork.kernel.org/patch/5184001/
>
> "Note that we have to keep the "console=ttySC1" parameter in
> chosen/bootargs, ..."
"... else we only get console messages on tty0, and because
this DTS is shared between legacy and multi-platform."
That was needed at the time of commit 2c32622c3f3f9c7e ("ARM:
shmobile: armadillo800eva dts: Add chosen/stdout-path").
Due to generic DT/console updates later, the "console=" parameters were
no longer needed, cfr. commit 1403e38b829acdad ("ARM: dts: armadillo800eva:
Update console parameters").
> I don't have armadillo800eva anymore, so I can't test this patch.
> But according to Phuc-san, there is not command prompt after boot
> without this patch.
I'm quite sure I do get console output on both ttyS0 and tty0 with the current
kernel (can't test right now due to board farm move/restructuring).
For a userspace prompt, I guess Phuc-san uses /dev/console as the console
device in e.g. /etc/inittab (or an equivalent)? If you want a prompt on tty0,
you better specify /dev/tty0 instead of /dev/console.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] ARM:dts:armadillo800eva: Add console parametters
@ 2017-08-10 8:25 ` Geert Uytterhoeven
0 siblings, 0 replies; 16+ messages in thread
From: Geert Uytterhoeven @ 2017-08-10 8:25 UTC (permalink / raw)
To: linux-arm-kernel
Hi Morimoto-san, Phuc-san,
On Thu, Aug 10, 2017 at 10:12 AM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
>> > chosen {
>> > - bootargs = "earlyprintk ignore_loglevel root=/dev/nfs ip=dhcp rw";
>> > + bootargs = "console=tty0 console=ttySC0,115200 earlyprintk
>> > + ignore_loglevel root=/dev/nfs ip=dhcp rw";
>> > stdout-path = "serial0:115200n8";
>> > };
>>
>> Hi,
>>
>> this feels wrong. My understanding is that stdout-path should be enough
>> to get the console.
> (snip)
>> Thank you for your comment.
>> Before creating this patch, I have a patch reference of you and Geert.
>> https://patchwork.kernel.org/patch/5184001/
>
> I think he want to say here is that it needs "console=" which
> is indicated by Geert on https://patchwork.kernel.org/patch/5184001/
>
> "Note that we have to keep the "console=ttySC1" parameter in
> chosen/bootargs, ..."
"... else we only get console messages on tty0, and because
this DTS is shared between legacy and multi-platform."
That was needed at the time of commit 2c32622c3f3f9c7e ("ARM:
shmobile: armadillo800eva dts: Add chosen/stdout-path").
Due to generic DT/console updates later, the "console=" parameters were
no longer needed, cfr. commit 1403e38b829acdad ("ARM: dts: armadillo800eva:
Update console parameters").
> I don't have armadillo800eva anymore, so I can't test this patch.
> But according to Phuc-san, there is not command prompt after boot
> without this patch.
I'm quite sure I do get console output on both ttyS0 and tty0 with the current
kernel (can't test right now due to board farm move/restructuring).
For a userspace prompt, I guess Phuc-san uses /dev/console as the console
device in e.g. /etc/inittab (or an equivalent)? If you want a prompt on tty0,
you better specify /dev/tty0 instead of /dev/console.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] ARM:dts:armadillo800eva: Add console parametters
@ 2017-08-10 8:25 ` Geert Uytterhoeven
0 siblings, 0 replies; 16+ messages in thread
From: Geert Uytterhoeven @ 2017-08-10 8:25 UTC (permalink / raw)
To: linux-arm-kernel
Hi Morimoto-san, Phuc-san,
On Thu, Aug 10, 2017 at 10:12 AM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
>> > chosen {
>> > - bootargs = "earlyprintk ignore_loglevel root=/dev/nfs ip=dhcp rw";
>> > + bootargs = "console=tty0 console=ttySC0,115200 earlyprintk
>> > + ignore_loglevel root=/dev/nfs ip=dhcp rw";
>> > stdout-path = "serial0:115200n8";
>> > };
>>
>> Hi,
>>
>> this feels wrong. My understanding is that stdout-path should be enough
>> to get the console.
> (snip)
>> Thank you for your comment.
>> Before creating this patch, I have a patch reference of you and Geert.
>> https://patchwork.kernel.org/patch/5184001/
>
> I think he want to say here is that it needs "console=" which
> is indicated by Geert on https://patchwork.kernel.org/patch/5184001/
>
> "Note that we have to keep the "console=ttySC1" parameter in
> chosen/bootargs, ..."
"... else we only get console messages on tty0, and because
this DTS is shared between legacy and multi-platform."
That was needed at the time of commit 2c32622c3f3f9c7e ("ARM:
shmobile: armadillo800eva dts: Add chosen/stdout-path").
Due to generic DT/console updates later, the "console=" parameters were
no longer needed, cfr. commit 1403e38b829acdad ("ARM: dts: armadillo800eva:
Update console parameters").
> I don't have armadillo800eva anymore, so I can't test this patch.
> But according to Phuc-san, there is not command prompt after boot
> without this patch.
I'm quite sure I do get console output on both ttyS0 and tty0 with the current
kernel (can't test right now due to board farm move/restructuring).
For a userspace prompt, I guess Phuc-san uses /dev/console as the console
device in e.g. /etc/inittab (or an equivalent)? If you want a prompt on tty0,
you better specify /dev/tty0 instead of /dev/console.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2017-08-10 8:25 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-06 13:55 [PATCH] ARM:dts:armadillo800eva: Add console parametters Bui Duc Phuc (Fukuda)
2017-08-06 13:55 ` Bui Duc Phuc (Fukuda)
2017-08-06 13:55 ` Bui Duc Phuc (Fukuda)
2017-08-06 13:55 ` Bui Duc Phuc (Fukuda)
2017-08-06 13:55 ` Bui Duc Phuc (Fukuda)
2017-08-06 13:55 ` Bui Duc Phuc (Fukuda)
2017-08-06 13:55 ` Bui Duc Phuc (Fukuda)
2017-08-07 7:59 ` Simon Horman
2017-08-07 7:59 ` Simon Horman
2017-08-07 7:59 ` Simon Horman
[not found] ` <CAABR9nHUuSw7m6BCBxDs28YtppHxwHNQR5f06H0n8xcXKx7gCw@mail.gmail.com>
2017-08-10 8:12 ` Kuninori Morimoto
2017-08-10 8:12 ` Kuninori Morimoto
2017-08-10 8:12 ` Kuninori Morimoto
2017-08-10 8:25 ` Geert Uytterhoeven
2017-08-10 8:25 ` Geert Uytterhoeven
2017-08-10 8:25 ` Geert Uytterhoeven
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.