Re: [PATCH] RDMA/uverbs: Fix the check for port number

From: Chien Tin Tung <chien.tin.tung-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: Mustafa Ismail
	<mustafa.ismail-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	e1000-rdma-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	"# v4 . 2-v4 . 9"
	<stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	security-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Steve Wise
	<swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>,
	Mike Marciniszyn
	<mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] RDMA/uverbs: Fix the check for port number
Date: Mon, 7 Aug 2017 07:11:52 -0500	[thread overview]
Message-ID: <20170807121151.GA13740@ctung-MOBL3.amr.corp.intel.com> (raw)
In-Reply-To: <20170807110307.GB2462@yuvallap>

On Mon, Aug 07, 2017 at 02:03:08PM +0300, Yuval Shaia wrote:
> On Wed, Jul 26, 2017 at 11:14:46AM -0500, Mustafa Ismail wrote:
> > The port number is only valid if IB_QP_PORT is set in the mask.
> > So only check port number if it is valid to prevent modify_qp
> > from failing due to an invalid port number.
> > 
> > Fixes: 5ecce4c9b17b("Check port number supplied by user verbs cmds")
> > Cc: <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> # v4.2-v4.9
> > Cc: <security-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> > Cc: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> > Cc: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
> > Cc: Mike Marciniszyn <mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > 
> > Signed-off-by: Mustafa Ismail <mustafa.ismail-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > 
> > Upstream commit 5a7a88f1b488("Fix the check for port number")
> > Modified from upstream commit: helper function rdma_is_port_valid does not
> > exist in these kernel versions.
> > ---
> >  drivers/infiniband/core/uverbs_cmd.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core/uverbs_cmd.c
> > index 01e3a37..d118ffe 100644
> > --- a/drivers/infiniband/core/uverbs_cmd.c
> > +++ b/drivers/infiniband/core/uverbs_cmd.c
> > @@ -2342,8 +2342,9 @@ ssize_t ib_uverbs_modify_qp(struct ib_uverbs_file *file,
> >  	if (copy_from_user(&cmd, buf, sizeof cmd))
> >  		return -EFAULT;
> >  
> > -	if (cmd.port_num < rdma_start_port(ib_dev) ||
> > -	    cmd.port_num > rdma_end_port(ib_dev))
> > +	if ((cmd.attr_mask & IB_QP_PORT) &&
> > +	    (cmd.port_num < rdma_start_port(ib_dev) ||
> > +	     cmd.port_num > rdma_end_port(ib_dev)))
> 
> Please use rdma_is_port_valid

Yuval,

This patch is meant for Stable v4.2-v4.9 which does not have
rdma_is_port_valid.  The patch upstream is using rdma_is_port_valid.
Here is a link to it: https://patchwork.kernel.org/patch/9841243/

Chien
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html