From: Simon Horman <horms@verge.net.au> To: Magnus Damm <magnus.damm@gmail.com> Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 00/10] ARM, arm64: dts: renesas: Use R-Car GPIO Gen[123] fallback compat strings Date: Wed, 9 Aug 2017 09:55:26 +0200 [thread overview] Message-ID: <20170809075526.GE2705@verge.net.au> (raw) In-Reply-To: <CANqRtoRcsAhvFB=DNoJHzJt4dejKX+Z8ar04D8O1cFq1XkxWkw@mail.gmail.com> On Tue, Aug 08, 2017 at 07:29:28PM +0900, Magnus Damm wrote: > Hi Simon, > > On Tue, Aug 8, 2017 at 5:39 PM, Simon Horman <horms+renesas@verge.net.au> wrote: > > Use newly added R-Car GPIO Gen 1, 2 and 3 fallback compat strings in place > > of now deprecated non-generation specific R-Car GPIO fallback compat string > > in the DT of Renesas ARM and arm64 based SoCs. > > > > This should have no run-time effect as the driver matches against the > > per-SoC compat string before considering the fallback compat string. > > Thanks for your efforts.I have no issue with your series (apart from > the GPIO and SATA mistake), but at the same time I believe the GPIO > hardware itself is backwards compatible between various generations. > > In the nitpick department I would like to point out that the level of > hardware difference between say R-Car Gen1 GPIO and R-Car Gen2 GPIO is > similar to say good old uarts like 8250 and 16450 hardware. Basically > a couple of registers were added to the hardware in a > backwards-compatible way if I recall correctly. > > So if we are going to use "compatible" to point out if hardware is > compatible or not then I would do this instead: Thanks for your feedback. When the generation specific compat strings were recently added the renesas,gpio-rcar compat string was marked as deprecated as I was under the understanding that it was only compatibile with gen 1 SoCs. It now seems that was not the best thing to do and renesas,gpio-rcar should be re-instated as being a generic fallback for all R-Car versions supported in upstream. Do you concur? > > --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi > @@ -214,7 +214,7 @@ > > gpio0: gpio@e6050000 { > compatible = "renesas,gpio-r8a7796", > + "renesas,rcar-gen3-gpio"; > "renesas,gpio-rcar"; > reg = <0 0xe6050000 0 0x50>; > interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>; > #gpio-cells = <2>; > > At the same time I'm not sure if I care _that_ much. =) > > Thanks, > > / magnus >
WARNING: multiple messages have this Message-ID (diff)
From: horms@verge.net.au (Simon Horman) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 00/10] ARM, arm64: dts: renesas: Use R-Car GPIO Gen[123] fallback compat strings Date: Wed, 9 Aug 2017 09:55:26 +0200 [thread overview] Message-ID: <20170809075526.GE2705@verge.net.au> (raw) In-Reply-To: <CANqRtoRcsAhvFB=DNoJHzJt4dejKX+Z8ar04D8O1cFq1XkxWkw@mail.gmail.com> On Tue, Aug 08, 2017 at 07:29:28PM +0900, Magnus Damm wrote: > Hi Simon, > > On Tue, Aug 8, 2017 at 5:39 PM, Simon Horman <horms+renesas@verge.net.au> wrote: > > Use newly added R-Car GPIO Gen 1, 2 and 3 fallback compat strings in place > > of now deprecated non-generation specific R-Car GPIO fallback compat string > > in the DT of Renesas ARM and arm64 based SoCs. > > > > This should have no run-time effect as the driver matches against the > > per-SoC compat string before considering the fallback compat string. > > Thanks for your efforts.I have no issue with your series (apart from > the GPIO and SATA mistake), but at the same time I believe the GPIO > hardware itself is backwards compatible between various generations. > > In the nitpick department I would like to point out that the level of > hardware difference between say R-Car Gen1 GPIO and R-Car Gen2 GPIO is > similar to say good old uarts like 8250 and 16450 hardware. Basically > a couple of registers were added to the hardware in a > backwards-compatible way if I recall correctly. > > So if we are going to use "compatible" to point out if hardware is > compatible or not then I would do this instead: Thanks for your feedback. When the generation specific compat strings were recently added the renesas,gpio-rcar compat string was marked as deprecated as I was under the understanding that it was only compatibile with gen 1 SoCs. It now seems that was not the best thing to do and renesas,gpio-rcar should be re-instated as being a generic fallback for all R-Car versions supported in upstream. Do you concur? > > --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi > @@ -214,7 +214,7 @@ > > gpio0: gpio at e6050000 { > compatible = "renesas,gpio-r8a7796", > + "renesas,rcar-gen3-gpio"; > "renesas,gpio-rcar"; > reg = <0 0xe6050000 0 0x50>; > interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>; > #gpio-cells = <2>; > > At the same time I'm not sure if I care _that_ much. =) > > Thanks, > > / magnus >
next prev parent reply other threads:[~2017-08-09 7:55 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-08-08 8:39 [PATCH 00/10] ARM, arm64: dts: renesas: Use R-Car GPIO Gen[123] fallback compat strings Simon Horman 2017-08-08 8:39 ` Simon Horman 2017-08-08 8:39 ` [PATCH 01/10] ARM: dts: r8a7778: Use R-Car GPIO Gen1 fallback compat string Simon Horman 2017-08-08 8:39 ` Simon Horman 2017-08-14 13:46 ` Geert Uytterhoeven 2017-08-14 13:46 ` Geert Uytterhoeven 2017-08-08 8:39 ` [PATCH 02/10] ARM: dts: r8a7779: " Simon Horman 2017-08-08 8:39 ` Simon Horman 2017-08-14 13:48 ` Geert Uytterhoeven 2017-08-14 13:48 ` Geert Uytterhoeven 2017-08-08 8:39 ` [PATCH 03/10] ARM: dts: r8a7743: Use R-Car GPIO Gen2 " Simon Horman 2017-08-08 8:39 ` Simon Horman 2017-08-14 13:49 ` Geert Uytterhoeven 2017-08-14 13:49 ` Geert Uytterhoeven 2017-08-08 8:39 ` [PATCH 04/10] ARM: dts: r8a7790: " Simon Horman 2017-08-08 8:39 ` Simon Horman 2017-08-14 13:50 ` Geert Uytterhoeven 2017-08-14 13:50 ` Geert Uytterhoeven 2017-08-08 8:39 ` [PATCH 05/10] ARM: dts: r8a7791: " Simon Horman 2017-08-08 8:39 ` Simon Horman 2017-08-14 13:51 ` Geert Uytterhoeven 2017-08-14 13:51 ` Geert Uytterhoeven 2017-08-08 8:39 ` [PATCH 06/10] ARM: dts: r8a7792: " Simon Horman 2017-08-08 8:39 ` Simon Horman 2017-08-14 13:52 ` Geert Uytterhoeven 2017-08-14 13:52 ` Geert Uytterhoeven 2017-08-08 8:39 ` [PATCH 07/10] ARM: dts: r8a7793: " Simon Horman 2017-08-08 8:39 ` Simon Horman 2017-08-14 13:52 ` Geert Uytterhoeven 2017-08-14 13:52 ` Geert Uytterhoeven 2017-08-08 8:39 ` [PATCH 08/10] ARM: dts: r8a7794: " Simon Horman 2017-08-08 8:39 ` Simon Horman 2017-08-08 8:39 ` [PATCH 09/10] arm64: dts: r8a7795: Use R-Car GPIO Gen3 " Simon Horman 2017-08-08 8:39 ` Simon Horman 2017-08-14 13:53 ` Geert Uytterhoeven 2017-08-14 13:53 ` Geert Uytterhoeven 2017-08-08 8:39 ` [PATCH 10/10] arm64: dts: r8a7796: " Simon Horman 2017-08-08 8:39 ` Simon Horman 2017-08-14 13:54 ` Geert Uytterhoeven 2017-08-14 13:54 ` Geert Uytterhoeven 2017-08-08 10:29 ` [PATCH 00/10] ARM, arm64: dts: renesas: Use R-Car GPIO Gen[123] fallback compat strings Magnus Damm 2017-08-08 10:29 ` Magnus Damm 2017-08-09 7:55 ` Simon Horman [this message] 2017-08-09 7:55 ` Simon Horman 2017-08-09 8:22 ` Simon Horman 2017-08-09 8:22 ` Simon Horman 2017-08-09 11:11 ` Magnus Damm 2017-08-09 11:11 ` Magnus Damm 2017-08-10 8:09 ` Simon Horman 2017-08-10 8:09 ` Simon Horman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170809075526.GE2705@verge.net.au \ --to=horms@verge.net.au \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=magnus.damm@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.