All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/vc4: Fix leak of HDMI EDID
@ 2017-08-08 20:56 ` Eric Anholt
  0 siblings, 0 replies; 7+ messages in thread
From: Eric Anholt @ 2017-08-08 20:56 UTC (permalink / raw)
  To: dri-devel; +Cc: linux-kernel, Eric Anholt, Stefan Wahren

We don't keep a pointer to it around anywhere, so it's our job to free
it.

Cc: Stefan Wahren <stefan.wahren@i2se.com>
Link: https://github.com/anholt/linux/issues/101
Fixes: c8b75bca92cb ("drm/vc4: Add KMS support for Raspberry Pi.")
Signed-off-by: Eric Anholt <eric@anholt.net>
---
 drivers/gpu/drm/vc4/vc4_hdmi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
index ff09b8e2f9ee..937da8dd65b8 100644
--- a/drivers/gpu/drm/vc4/vc4_hdmi.c
+++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
@@ -288,6 +288,7 @@ static int vc4_hdmi_connector_get_modes(struct drm_connector *connector)
 	drm_mode_connector_update_edid_property(connector, edid);
 	ret = drm_add_edid_modes(connector, edid);
 	drm_edid_to_eld(connector, edid);
+	kfree(edid);
 
 	return ret;
 }
-- 
2.13.3

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH] drm/vc4: Fix leak of HDMI EDID
@ 2017-08-08 20:56 ` Eric Anholt
  0 siblings, 0 replies; 7+ messages in thread
From: Eric Anholt @ 2017-08-08 20:56 UTC (permalink / raw)
  To: dri-devel; +Cc: Stefan Wahren, linux-kernel

We don't keep a pointer to it around anywhere, so it's our job to free
it.

Cc: Stefan Wahren <stefan.wahren@i2se.com>
Link: https://github.com/anholt/linux/issues/101
Fixes: c8b75bca92cb ("drm/vc4: Add KMS support for Raspberry Pi.")
Signed-off-by: Eric Anholt <eric@anholt.net>
---
 drivers/gpu/drm/vc4/vc4_hdmi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
index ff09b8e2f9ee..937da8dd65b8 100644
--- a/drivers/gpu/drm/vc4/vc4_hdmi.c
+++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
@@ -288,6 +288,7 @@ static int vc4_hdmi_connector_get_modes(struct drm_connector *connector)
 	drm_mode_connector_update_edid_property(connector, edid);
 	ret = drm_add_edid_modes(connector, edid);
 	drm_edid_to_eld(connector, edid);
+	kfree(edid);
 
 	return ret;
 }
-- 
2.13.3

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH] drm/vc4: Fix leak of HDMI EDID
  2017-08-08 20:56 ` Eric Anholt
@ 2017-08-09 17:36   ` Daniel Vetter
  -1 siblings, 0 replies; 7+ messages in thread
From: Daniel Vetter @ 2017-08-09 17:36 UTC (permalink / raw)
  To: Eric Anholt; +Cc: dri-devel, Stefan Wahren, linux-kernel

On Tue, Aug 08, 2017 at 01:56:05PM -0700, Eric Anholt wrote:
> We don't keep a pointer to it around anywhere, so it's our job to free
> it.
> 
> Cc: Stefan Wahren <stefan.wahren@i2se.com>
> Link: https://github.com/anholt/linux/issues/101
> Fixes: c8b75bca92cb ("drm/vc4: Add KMS support for Raspberry Pi.")
> Signed-off-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  drivers/gpu/drm/vc4/vc4_hdmi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
> index ff09b8e2f9ee..937da8dd65b8 100644
> --- a/drivers/gpu/drm/vc4/vc4_hdmi.c
> +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
> @@ -288,6 +288,7 @@ static int vc4_hdmi_connector_get_modes(struct drm_connector *connector)
>  	drm_mode_connector_update_edid_property(connector, edid);
>  	ret = drm_add_edid_modes(connector, edid);
>  	drm_edid_to_eld(connector, edid);
> +	kfree(edid);
>  
>  	return ret;
>  }
> -- 
> 2.13.3
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] drm/vc4: Fix leak of HDMI EDID
@ 2017-08-09 17:36   ` Daniel Vetter
  0 siblings, 0 replies; 7+ messages in thread
From: Daniel Vetter @ 2017-08-09 17:36 UTC (permalink / raw)
  To: Eric Anholt; +Cc: Stefan Wahren, linux-kernel, dri-devel

On Tue, Aug 08, 2017 at 01:56:05PM -0700, Eric Anholt wrote:
> We don't keep a pointer to it around anywhere, so it's our job to free
> it.
> 
> Cc: Stefan Wahren <stefan.wahren@i2se.com>
> Link: https://github.com/anholt/linux/issues/101
> Fixes: c8b75bca92cb ("drm/vc4: Add KMS support for Raspberry Pi.")
> Signed-off-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  drivers/gpu/drm/vc4/vc4_hdmi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
> index ff09b8e2f9ee..937da8dd65b8 100644
> --- a/drivers/gpu/drm/vc4/vc4_hdmi.c
> +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
> @@ -288,6 +288,7 @@ static int vc4_hdmi_connector_get_modes(struct drm_connector *connector)
>  	drm_mode_connector_update_edid_property(connector, edid);
>  	ret = drm_add_edid_modes(connector, edid);
>  	drm_edid_to_eld(connector, edid);
> +	kfree(edid);
>  
>  	return ret;
>  }
> -- 
> 2.13.3
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] drm/vc4: Fix leak of HDMI EDID
  2017-08-08 20:56 ` Eric Anholt
  (?)
  (?)
@ 2017-08-11 17:33 ` Stefan Wahren
  -1 siblings, 0 replies; 7+ messages in thread
From: Stefan Wahren @ 2017-08-11 17:33 UTC (permalink / raw)
  To: Eric Anholt, dri-devel; +Cc: linux-kernel

> Eric Anholt <eric@anholt.net> hat am 8. August 2017 um 22:56 geschrieben:
> 
> 
> We don't keep a pointer to it around anywhere, so it's our job to free
> it.
> 
> Cc: Stefan Wahren <stefan.wahren@i2se.com>
> Link: https://github.com/anholt/linux/issues/101
> Fixes: c8b75bca92cb ("drm/vc4: Add KMS support for Raspberry Pi.")
> Signed-off-by: Eric Anholt <eric@anholt.net>

Tested-by: Stefan Wahren <stefan.wahren@i2se.com>

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] drm/vc4: Fix leak of HDMI EDID
  2017-08-09 17:36   ` Daniel Vetter
@ 2017-08-14 21:11     ` Eric Anholt
  -1 siblings, 0 replies; 7+ messages in thread
From: Eric Anholt @ 2017-08-14 21:11 UTC (permalink / raw)
  To: Daniel Vetter; +Cc: dri-devel, Stefan Wahren, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 490 bytes --]

Daniel Vetter <daniel@ffwll.ch> writes:

> On Tue, Aug 08, 2017 at 01:56:05PM -0700, Eric Anholt wrote:
>> We don't keep a pointer to it around anywhere, so it's our job to free
>> it.
>> 
>> Cc: Stefan Wahren <stefan.wahren@i2se.com>
>> Link: https://github.com/anholt/linux/issues/101
>> Fixes: c8b75bca92cb ("drm/vc4: Add KMS support for Raspberry Pi.")
>> Signed-off-by: Eric Anholt <eric@anholt.net>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Pushed.  Thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] drm/vc4: Fix leak of HDMI EDID
@ 2017-08-14 21:11     ` Eric Anholt
  0 siblings, 0 replies; 7+ messages in thread
From: Eric Anholt @ 2017-08-14 21:11 UTC (permalink / raw)
  To: Daniel Vetter; +Cc: Stefan Wahren, linux-kernel, dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 490 bytes --]

Daniel Vetter <daniel@ffwll.ch> writes:

> On Tue, Aug 08, 2017 at 01:56:05PM -0700, Eric Anholt wrote:
>> We don't keep a pointer to it around anywhere, so it's our job to free
>> it.
>> 
>> Cc: Stefan Wahren <stefan.wahren@i2se.com>
>> Link: https://github.com/anholt/linux/issues/101
>> Fixes: c8b75bca92cb ("drm/vc4: Add KMS support for Raspberry Pi.")
>> Signed-off-by: Eric Anholt <eric@anholt.net>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Pushed.  Thanks!

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-08-14 21:17 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-08 20:56 [PATCH] drm/vc4: Fix leak of HDMI EDID Eric Anholt
2017-08-08 20:56 ` Eric Anholt
2017-08-09 17:36 ` Daniel Vetter
2017-08-09 17:36   ` Daniel Vetter
2017-08-14 21:11   ` Eric Anholt
2017-08-14 21:11     ` Eric Anholt
2017-08-11 17:33 ` Stefan Wahren

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.