From: Christoph Hellwig <hch@infradead.org>
To: James Smart <jsmart2021@gmail.com>
Cc: linux-nvme@lists.infradead.org,
James Smart <james.smart@broadcom.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/2] nvmet_fc: add defer_req callback for deferment of cmd buffer return
Date: Thu, 10 Aug 2017 11:06:04 +0200 [thread overview]
Message-ID: <20170810090604.65ccmgooqzilhkjq@infradead.org> (raw)
In-Reply-To: <20170801221240.31723-2-jsmart2021@gmail.com>
> @@ -463,9 +472,9 @@ static struct nvmet_fc_fcp_iod *
> nvmet_fc_alloc_fcp_iod(struct nvmet_fc_tgt_queue *queue)
> {
> static struct nvmet_fc_fcp_iod *fod;
This isn't new, but is this really supposed to be a static variable,
that is all instances of this code sharing it use the same?
After a short code inspection this looks like a nasty bug to me.
WARNING: multiple messages have this Message-ID (diff)
From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH 1/2] nvmet_fc: add defer_req callback for deferment of cmd buffer return
Date: Thu, 10 Aug 2017 11:06:04 +0200 [thread overview]
Message-ID: <20170810090604.65ccmgooqzilhkjq@infradead.org> (raw)
In-Reply-To: <20170801221240.31723-2-jsmart2021@gmail.com>
> @@ -463,9 +472,9 @@ static struct nvmet_fc_fcp_iod *
> nvmet_fc_alloc_fcp_iod(struct nvmet_fc_tgt_queue *queue)
> {
> static struct nvmet_fc_fcp_iod *fod;
This isn't new, but is this really supposed to be a static variable,
that is all instances of this code sharing it use the same?
After a short code inspection this looks like a nasty bug to me.
next prev parent reply other threads:[~2017-08-10 9:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 22:12 [PATCH 0/2] nvmet_fc: work around overalloc of queue elements James Smart
2017-08-01 22:12 ` James Smart
2017-08-01 22:12 ` [PATCH 1/2] nvmet_fc: add defer_req callback for deferment of cmd buffer return James Smart
2017-08-01 22:12 ` James Smart
2017-08-02 8:16 ` Johannes Thumshirn
2017-08-02 8:16 ` Johannes Thumshirn
2017-08-02 14:29 ` James Smart
2017-08-02 14:29 ` James Smart
2017-08-10 9:04 ` Christoph Hellwig
2017-08-10 9:04 ` Christoph Hellwig
2017-08-10 9:06 ` Christoph Hellwig [this message]
2017-08-10 9:06 ` Christoph Hellwig
2017-08-16 7:53 ` Christoph Hellwig
2017-08-16 7:53 ` Christoph Hellwig
2017-08-01 22:12 ` [PATCH 2/2] lpfc: support nvmet_fc defer_rcv callback James Smart
2017-08-01 22:12 ` James Smart
2017-08-02 8:32 ` Johannes Thumshirn
2017-08-02 8:32 ` Johannes Thumshirn
2017-08-02 9:17 ` Johannes Thumshirn
2017-08-02 9:17 ` Johannes Thumshirn
2017-08-02 14:32 ` James Smart
2017-08-02 14:32 ` James Smart
2017-08-10 9:08 ` Christoph Hellwig
2017-08-10 9:08 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170810090604.65ccmgooqzilhkjq@infradead.org \
--to=hch@infradead.org \
--cc=james.smart@broadcom.com \
--cc=jsmart2021@gmail.com \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.