All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [Qemu-devel] [PATCH v3 00/12] Convert over to use keycodemapdb
@ 2017-08-14 18:46 Programmingkid
  2017-08-15  8:38 ` Daniel P. Berrange
  0 siblings, 1 reply; 16+ messages in thread
From: Programmingkid @ 2017-08-14 18:46 UTC (permalink / raw)
  To: Daniel P. Berrange
  Cc: qemu-devel@nongnu.org qemu-devel, Eric Blake, Gerd Hoffmann

Sorry but there appears to be an issue with your patchset. I ran this command:

./configure --target-list=ppc-softmmu,i386-softmmu

Then saw this error message: 

error: pathspec 'ui/keycodemapdb' did not match any file(s) known to git.

Running 'make' I saw this error message:

make: *** No rule to make target `ui/input-keymap-atset1-to-qcode.c', needed by `Makefile'.  Stop.
make: *** Waiting for unfinished jobs....

Running the 'make clean' command produces this error message:

make[1]: *** No rule to make target `ui/input-keymap-atset1-to-qcode.c', needed by `Makefile'.  Stop.
make: *** [clean] Error 1

Perhaps a missing patch?

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [Qemu-devel] [PATCH v3 00/12] Convert over to use keycodemapdb
@ 2017-08-14 12:49 Daniel P. Berrange
  2017-08-14 13:05 ` no-reply
                   ` (2 more replies)
  0 siblings, 3 replies; 16+ messages in thread
From: Daniel P. Berrange @ 2017-08-14 12:49 UTC (permalink / raw)
  To: qemu-devel; +Cc: Gerd Hoffmann, Eric Blake, Daniel P. Berrange

An update of:

  v1: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02047.html
  v2: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02471.html

The keycodemap project[1] provides a database mapping between
many different keysym/keycode/scancode sets, along with a
tool to generate mapping/lookup tables in various programming
languages. It is already used by GTK-VNC, SPICE-GTK and
libvirt.

This series enables its use in QEMU, thus fixing a great
many bugs/ommissions in the 15+ key mapping tables people
have manually written for QEMU.

The keycodemapdb code is designed to be used as a git
sub-module, it is not an external dependancy you need
installed before use.

This series converts all the front ends and all the input
devices which are using the new InputEvent framework. A
handful of devices still use the legacy kbd handler

  $ git grep -l add_kbd_event_handler hw
  hw/arm/musicpal.c
  hw/arm/nseries.c
  hw/arm/palm.c
  hw/arm/spitz.c
  hw/input/pxa2xx_keypad.c
  hw/input/stellaris_input.c

and could be usefully converted too.

I've not done much realworld testing of this yet. I did
however write code that compared the mapping tables before
and after conversion to identify what mapping changes have
resulted in each frontend/backend.  What I still need to
go back and validate is the Print/Sysrq handling, because
that is special everywhere and I'm not entirely sure I've
done that correctly yet. The GTK frontend should now work
correctly when run on X11 servers on Win32 and OS-X, as
well as when run on native Win32/OS-X display backends.

[1] https://gitlab.com/keycodemap/keycodemapdb/

Changed in v3:

 - Ensure docker builds pull in keycodemapdb submodule (patchew)
 - Add compat with py26 for RHEL-6 in keycodemapdb tools (patchew)
 - Initialize submodule in configure script (patchew)

Changed in v2:

 - Change filename pattern to 'ui/input-keymap-$SRC-to-$DST.c'
   and map names 'qemu_input_map_$SRC_to_$DST'  (Eric)
 - Fix typos (Eric)
 - Drop changes to InputKeyEvent struct (Eric)
 - Fix VPATH build (patchew)
 - Fix code style errors (patchew)

Daniel P. Berrange (12):
  ui: add keycodemapdb repository as a GIT submodule
  ui: convert common input code to keycodemapdb
  ui: convert key events to QKeyCodes immediately
  ui: don't export qemu_input_event_new_key
  input: convert virtio-input-hid device to keycodemapdb
  input: convert ps2 device to keycodemapdb
  input: convert the adb device to keycodemapdb
  char: convert the escc device to keycodemapdb
  ui: convert cocoa frontend to keycodemapdb
  ui: convert the SDL2 frontend to keycodemapdb
  ui: convert GTK and SDL1 frontends to keycodemapdb
  display: convert XenInput keyboard to keycodemapdb

 .gitignore                    |   2 +
 .gitmodules                   |   3 +
 configure                     |   2 +
 hw/char/escc.c                | 126 +------------
 hw/display/xenfb.c            | 133 ++++----------
 hw/input/adb.c                | 124 +------------
 hw/input/ps2.c                | 406 +-----------------------------------------
 hw/input/virtio-input-hid.c   | 136 +-------------
 include/hw/input/adb-keys.h   | 141 ---------------
 include/ui/input.h            |  57 +++++-
 tests/docker/Makefile.include |   1 +
 tests/docker/run              |   4 +-
 ui/Makefile.objs              |  41 ++++-
 ui/cocoa.m                    | 129 +-------------
 ui/gtk.c                      | 205 ++++++++++++---------
 ui/input-keymap.c             | 341 ++++-------------------------------
 ui/input.c                    |   8 +-
 ui/keycodemapdb               |   1 +
 ui/sdl.c                      | 105 ++++-------
 ui/sdl2-input.c               |  16 +-
 ui/sdl2-keymap.h              | 267 ---------------------------
 ui/trace-events               |   9 +-
 ui/x_keymap.c                 | 250 ++++++++++----------------
 ui/x_keymap.h                 |   8 +-
 24 files changed, 467 insertions(+), 2048 deletions(-)
 delete mode 100644 include/hw/input/adb-keys.h
 create mode 160000 ui/keycodemapdb
 delete mode 100644 ui/sdl2-keymap.h

-- 
2.13.3

^ permalink raw reply	[flat|nested] 16+ messages in thread
end of thread, other threads:[~2017-08-15 14:44 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <mailman.1778.1502715001.21954.qemu-devel@nongnu.org>
2017-08-14 13:39 ` [Qemu-devel] [PATCH v3 00/12] Convert over to use keycodemapdb Programmingkid
2017-08-14 14:00   ` Daniel P. Berrange
2017-08-14 17:20     ` Programmingkid
2017-08-14 18:20       ` Eric Blake
2017-08-14 18:49         ` Programmingkid
2017-08-14 19:07           ` Eric Blake
2017-08-14 20:30   ` Philippe Mathieu-Daudé
2017-08-14 18:46 Programmingkid
2017-08-15  8:38 ` Daniel P. Berrange
2017-08-15 13:49   ` Programmingkid
2017-08-15 13:49     ` Daniel P. Berrange
2017-08-15 14:44       ` Programmingkid
  -- strict thread matches above, loose matches on Subject: below --
2017-08-14 12:49 Daniel P. Berrange
2017-08-14 13:05 ` no-reply
2017-08-14 13:06 ` no-reply
2017-08-14 13:06 ` no-reply

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.