All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: v9fs-developer@lists.sourceforge.net, netdev@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Eric Van Hensbergen <ericvh@gmail.com>,
	Latchesar Ionkov <lucho@ionkov.net>,
	Ron Minnich <rminnich@sandia.gov>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/5] net/9p: Improve 19 size determinations
Date: Tue, 15 Aug 2017 15:21:53 +0100	[thread overview]
Message-ID: <20170815142152.GA5426@ZenIV.linux.org.uk> (raw)
In-Reply-To: <f9eeedc4-5d3d-6622-79f0-11174ea81c49@users.sourceforge.net>

On Tue, Aug 15, 2017 at 02:00:06PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 15 Aug 2017 09:36:20 +0200
> 
> Replace the specification of data structures by variable references
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer according to the Linux coding style convention.

Garbage.  This makes it so much harder to find where the objects of given
type are created.  It's _not_ safer and any patches of that sort around
VFS will be shitcanned.  What to do with net/9p patches is up to net/9p
maintainers, but I would strongly recommend the same treatment.

WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@ZenIV.linux.org.uk>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: v9fs-developer@lists.sourceforge.net, netdev@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Eric Van Hensbergen <ericvh@gmail.com>,
	Latchesar Ionkov <lucho@ionkov.net>,
	Ron Minnich <rminnich@sandia.gov>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/5] net/9p: Improve 19 size determinations
Date: Tue, 15 Aug 2017 14:21:53 +0000	[thread overview]
Message-ID: <20170815142152.GA5426@ZenIV.linux.org.uk> (raw)
In-Reply-To: <f9eeedc4-5d3d-6622-79f0-11174ea81c49@users.sourceforge.net>

On Tue, Aug 15, 2017 at 02:00:06PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 15 Aug 2017 09:36:20 +0200
> 
> Replace the specification of data structures by variable references
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer according to the Linux coding style convention.

Garbage.  This makes it so much harder to find where the objects of given
type are created.  It's _not_ safer and any patches of that sort around
VFS will be shitcanned.  What to do with net/9p patches is up to net/9p
maintainers, but I would strongly recommend the same treatment.

  reply	other threads:[~2017-08-15 14:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-15 11:56 [PATCH 0/5] net/9p: Fine-tuning for some function implementations SF Markus Elfring
2017-08-15 11:56 ` SF Markus Elfring
2017-08-15 11:58 ` [PATCH 1/5] net/9p: Delete an error message for a failed memory allocation in five functions SF Markus Elfring
2017-08-15 11:58   ` SF Markus Elfring
2017-08-15 12:00 ` [PATCH 2/5] net/9p: Improve 19 size determinations SF Markus Elfring
2017-08-15 12:00   ` SF Markus Elfring
2017-08-15 14:21   ` Al Viro [this message]
2017-08-15 14:21     ` Al Viro
2017-08-15 12:01 ` [PATCH 3/5] net/9p: Add a jump target in p9_client_walk() SF Markus Elfring
2017-08-15 12:01   ` SF Markus Elfring
2017-08-15 12:02 ` [PATCH 4/5] net/9p: Adjust a jump target in p9_client_attach() SF Markus Elfring
2017-08-15 12:02   ` SF Markus Elfring
2017-08-15 12:03 ` [PATCH 5/5] net/9p: Delete an unnecessary variable initialisation " SF Markus Elfring
2017-08-15 12:03   ` SF Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170815142152.GA5426@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=davem@davemloft.net \
    --cc=elfring@users.sourceforge.net \
    --cc=ericvh@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lucho@ionkov.net \
    --cc=netdev@vger.kernel.org \
    --cc=rminnich@sandia.gov \
    --cc=v9fs-developer@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.