[PATCH 0/2] i2c: {sh_mobile,rcar}: Trivial fixes of smatch warnings

[PATCH 0/2] i2c: {sh_mobile,rcar}: Trivial fixes of smatch warnings

[Eugeniu Rosca]

Hello Wolfram,

These simple fixes make smatch happy.
Thanks for taking them into account.

Best regards,
Eugeniu.

Eugeniu Rosca (2):
  i2c: rcar: avoid unused return
  i2c: sh_mobile: avoid unused return

 drivers/i2c/busses/i2c-rcar.c      | 5 ++---
 drivers/i2c/busses/i2c-sh_mobile.c | 4 ++--
 2 files changed, 4 insertions(+), 5 deletions(-)

-- 
2.14.1

[PATCH 1/2] i2c: rcar: avoid unused return

[Eugeniu Rosca]

Fix smatch warning:
drivers/i2c/busses/i2c-rcar.c:628 \
  rcar_i2c_request_dma_chan() warn: unused return: ret = PTR_ERR()

Fixes: 73e8b0528346 ("i2c: rcar: add DMA support")
Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
---
 drivers/i2c/busses/i2c-rcar.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c
index 93c1a54981df..15d764afec3b 100644
--- a/drivers/i2c/busses/i2c-rcar.c
+++ b/drivers/i2c/busses/i2c-rcar.c
@@ -625,9 +625,8 @@ static struct dma_chan *rcar_i2c_request_dma_chan(struct device *dev,
 
 	chan = dma_request_chan(dev, chan_name);
 	if (IS_ERR(chan)) {
-		ret = PTR_ERR(chan);
-		dev_dbg(dev, "request_channel failed for %s (%d)\n",
-			chan_name, ret);
+		dev_dbg(dev, "request_channel failed for %s (%ld)\n",
+			chan_name, PTR_ERR(chan));
 		return chan;
 	}
 
-- 
2.14.1

[PATCH 2/2] i2c: sh_mobile: avoid unused return

[Eugeniu Rosca]

Fix smatch warning:
drivers/i2c/busses/i2c-sh_mobile.c:564 \
  sh_mobile_i2c_request_dma_chan() warn: unused return: ret = PTR_ERR()

Fixes: fe07adec730d ("i2c: sh_mobile: fix uninitialized var when debug is enabled")
Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
---
 drivers/i2c/busses/i2c-sh_mobile.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-sh_mobile.c b/drivers/i2c/busses/i2c-sh_mobile.c
index 2e097d97d258..6f2aaeb7c4fa 100644
--- a/drivers/i2c/busses/i2c-sh_mobile.c
+++ b/drivers/i2c/busses/i2c-sh_mobile.c
@@ -561,8 +561,8 @@ static struct dma_chan *sh_mobile_i2c_request_dma_chan(struct device *dev,
 
 	chan = dma_request_slave_channel_reason(dev, chan_name);
 	if (IS_ERR(chan)) {
-		ret = PTR_ERR(chan);
-		dev_dbg(dev, "request_channel failed for %s (%d)\n", chan_name, ret);
+		dev_dbg(dev, "request_channel failed for %s (%ld)\n", chan_name,
+			PTR_ERR(chan));
 		return chan;
 	}
 
-- 
2.14.1

Re: [PATCH 0/2] i2c: {sh_mobile,rcar}: Trivial fixes of smatch warnings

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 375 bytes --]

Hi Eugeniu,

> These simple fixes make smatch happy.

Ah, thanks! I use smatch, too, but always compile with DEBUG, so this
went unnoticed.

> Thanks for taking them into account.

Sure, I just dropped the fixes tags. Thanks for supplying those, but
fixing smatch warnings is not enough reason to go back to stable
releases unless it fixes a real bug.

Regards,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH 1/2] i2c: rcar: avoid unused return

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 344 bytes --]

On Tue, Aug 15, 2017 at 10:36:23PM +0200, Eugeniu Rosca wrote:
> Fix smatch warning:
> drivers/i2c/busses/i2c-rcar.c:628 \
>   rcar_i2c_request_dma_chan() warn: unused return: ret = PTR_ERR()
> 
> Fixes: 73e8b0528346 ("i2c: rcar: add DMA support")
> Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>

Applied to for-next, thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH 2/2] i2c: sh_mobile: avoid unused return

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 387 bytes --]

On Tue, Aug 15, 2017 at 10:36:24PM +0200, Eugeniu Rosca wrote:
> Fix smatch warning:
> drivers/i2c/busses/i2c-sh_mobile.c:564 \
>   sh_mobile_i2c_request_dma_chan() warn: unused return: ret = PTR_ERR()
> 
> Fixes: fe07adec730d ("i2c: sh_mobile: fix uninitialized var when debug is enabled")
> Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>

Applied to for-next, thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH 0/2] i2c: {sh_mobile,rcar}: Trivial fixes of smatch warnings

[Eugeniu Rosca]

On Thu, Aug 17, 2017 at 05:50:20PM +0200, Wolfram Sang wrote:
> Hi Eugeniu,
> 
> > These simple fixes make smatch happy.
> 
> Ah, thanks! I use smatch, too, but always compile with DEBUG, so this
> went unnoticed.
> 
> > Thanks for taking them into account.
> 
> Sure, I just dropped the fixes tags. Thanks for supplying those, but
> fixing smatch warnings is not enough reason to go back to stable
> releases unless it fixes a real bug.

Hi Wolfram,

Feedback is very appreciated.
Including "Fixes:" line is just a habit. Feel free to drop it.

Many thanks,
Eugeniu.

> 
> Regards,
> 
>    Wolfram
>