All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@kernel.org>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Vlastimil Babka <vbabka@suse.cz>,
	Mel Gorman <mgorman@techsingularity.net>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 2/2] mm, compaction: persistently skip hugetlbfs pageblocks
Date: Fri, 18 Aug 2017 10:49:12 +0200	[thread overview]
Message-ID: <20170818084912.GA18513@dhcp22.suse.cz> (raw)
In-Reply-To: <alpine.DEB.2.10.1708151639130.106658@chino.kir.corp.google.com>

I am getting 
mm/compaction.c: In function 'isolate_freepages_block':
mm/compaction.c:469:4: error: implicit declaration of function 'pageblock_skip_persistent' [-Werror=implicit-function-declaration]
    if (pageblock_skip_persistent(page, order)) {
    ^
mm/compaction.c:470:5: error: implicit declaration of function 'set_pageblock_skip' [-Werror=implicit-function-declaration]
     set_pageblock_skip(page);

when compaction is disabled because isolate_freepages_block is defined
also when CONFIG_COMPACTION=n. I haven't checked how to fix this
properly yet.
-- 
Michal Hocko
SUSE Labs

WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Vlastimil Babka <vbabka@suse.cz>,
	Mel Gorman <mgorman@techsingularity.net>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 2/2] mm, compaction: persistently skip hugetlbfs pageblocks
Date: Fri, 18 Aug 2017 10:49:12 +0200	[thread overview]
Message-ID: <20170818084912.GA18513@dhcp22.suse.cz> (raw)
In-Reply-To: <alpine.DEB.2.10.1708151639130.106658@chino.kir.corp.google.com>

I am getting 
mm/compaction.c: In function 'isolate_freepages_block':
mm/compaction.c:469:4: error: implicit declaration of function 'pageblock_skip_persistent' [-Werror=implicit-function-declaration]
    if (pageblock_skip_persistent(page, order)) {
    ^
mm/compaction.c:470:5: error: implicit declaration of function 'set_pageblock_skip' [-Werror=implicit-function-declaration]
     set_pageblock_skip(page);

when compaction is disabled because isolate_freepages_block is defined
also when CONFIG_COMPACTION=n. I haven't checked how to fix this
properly yet.
-- 
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-08-18  8:49 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-15 23:39 [patch 1/2] mm, compaction: kcompactd should not ignore pageblock skip David Rientjes
2017-08-15 23:39 ` David Rientjes
2017-08-15 23:39 ` [patch 2/2] mm, compaction: persistently skip hugetlbfs pageblocks David Rientjes
2017-08-15 23:39   ` David Rientjes
2017-08-18  8:49   ` Michal Hocko [this message]
2017-08-18  8:49     ` Michal Hocko
2017-08-21  0:36     ` [patch -mm] mm, compaction: persistently skip hugetlbfs pageblocks fix David Rientjes
2017-08-21  0:36       ` David Rientjes
2017-08-21  6:37       ` Michal Hocko
2017-08-21  6:37         ` Michal Hocko
2017-08-23  8:41   ` [patch 2/2] mm, compaction: persistently skip hugetlbfs pageblocks Vlastimil Babka
2017-08-23  8:41     ` Vlastimil Babka
2017-09-01 12:32     ` Vlastimil Babka
2017-09-01 12:32       ` Vlastimil Babka
2017-09-11  1:13       ` David Rientjes
2017-09-11  1:13         ` David Rientjes
2017-09-11  1:12     ` David Rientjes
2017-09-11  1:12       ` David Rientjes
2017-09-11  6:50       ` Vlastimil Babka
2017-09-11  6:50         ` Vlastimil Babka
2017-09-11 21:11         ` David Rientjes
2017-09-11 21:11           ` David Rientjes
2017-08-23  8:23 ` [patch 1/2] mm, compaction: kcompactd should not ignore pageblock skip Vlastimil Babka
2017-08-23  8:23   ` Vlastimil Babka
2017-09-11  1:07   ` David Rientjes
2017-09-11  1:07     ` David Rientjes
2017-09-11  6:34     ` Vlastimil Babka
2017-09-11  6:34       ` Vlastimil Babka
2017-09-11 21:13       ` David Rientjes
2017-09-11 21:13         ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170818084912.GA18513@dhcp22.suse.cz \
    --to=mhocko@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=rientjes@google.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.