All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amador Pahim <apahim@redhat.com>
To: qemu-devel@nongnu.org
Cc: stefanha@gmail.com, famz@redhat.com, berrange@redhat.com,
	ehabkost@redhat.com, mreitz@redhat.com, kwolf@redhat.com,
	armbru@redhat.com, crosa@redhat.com, ldoktor@redhat.com,
	Amador Pahim <apahim@redhat.com>
Subject: [Qemu-devel] [PATCH v7 00/11] scripts/qemu.py fixes and cleanups
Date: Fri, 18 Aug 2017 19:05:15 +0200	[thread overview]
Message-ID: <20170818170526.13496-1-apahim@redhat.com> (raw)

Changes v1->v2:
 - Style fixes to make checkpatch.pl happy.
 - Rebased.
Changes v2->v3:
 - Fix typo in patch 3 ("qemu.py: make 'args' public") commit message.
Changes v3->v4:
 - Squash the 2 first commits since they are co-dependant.
 - Cleanup launch() and shutdown().
 - Reorder the commits, putting the rename of self._args first.
 - Rebased.
Changes v4->v5:
 - Break the cleanup commit into logical changes and include in the
   commit messages the rationale for making them.
Changes v5->v6:
 - Remove the commit to rename self._args.
 - Fix is_running() return before first call to maunch().
 - Use python logging system.
 - Include the full command line on negative exit code error message.
 - Use os.path.null instead of /dev/null.
 - Improve the control over the created/deleted files. 
Changes v6->v7:
 - Split commits in self-contained/atomic changes.
 - Addressed the comments from previous version, basically improving the
   logging messages and the control over created files. See individual
   commit messages for details.

Amador Pahim (11):
  qemu.py: fix is_running() return before first launch()
  qemu.py: avoid writing to stdout/stderr
  qemu.py: use os.path.null instead of /dev/null
  qemu.py: use poll() instead of 'returncode'
  qemu.py: cleanup redundant calls in launch()
  qemu.py: improve message on negative exit code
  qemu.py: include debug information on launch error
  qemu.py: make sure we only remove files we create
  qemu.py: launch vm only if it's not running
  qemu.py: don't launch again before shutdown()
  qemu.py: refactor launch()

 scripts/qemu.py | 141 ++++++++++++++++++++++++++++++++++++++++++--------------
 1 file changed, 106 insertions(+), 35 deletions(-)

-- 
2.13.5

             reply	other threads:[~2017-08-18 17:12 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-18 17:05 Amador Pahim [this message]
2017-08-18 17:05 ` [Qemu-devel] [PATCH v7 01/11] qemu.py: fix is_running() return before first launch() Amador Pahim
2017-08-18 17:05 ` [Qemu-devel] [PATCH v7 02/11] qemu.py: avoid writing to stdout/stderr Amador Pahim
2017-08-22 10:24   ` Fam Zheng
2017-08-22 11:11     ` Amador Pahim
2017-08-22 11:56       ` Fam Zheng
2017-08-22 12:38         ` Amador Pahim
2017-08-18 17:05 ` [Qemu-devel] [PATCH v7 03/11] qemu.py: use os.path.null instead of /dev/null Amador Pahim
2017-08-22 10:24   ` Fam Zheng
2017-08-18 17:05 ` [Qemu-devel] [PATCH v7 04/11] qemu.py: use poll() instead of 'returncode' Amador Pahim
2017-08-30 21:10   ` Eduardo Habkost
2017-08-18 17:05 ` [Qemu-devel] [PATCH v7 05/11] qemu.py: cleanup redundant calls in launch() Amador Pahim
2017-08-18 17:05 ` [Qemu-devel] [PATCH v7 06/11] qemu.py: improve message on negative exit code Amador Pahim
2017-08-18 17:05 ` [Qemu-devel] [PATCH v7 07/11] qemu.py: include debug information on launch error Amador Pahim
2017-08-30 15:55   ` Cleber Rosa
2017-08-31  1:28     ` Fam Zheng
2017-08-31  9:47   ` Lukáš Doktor
2017-08-18 17:05 ` [Qemu-devel] [PATCH v7 08/11] qemu.py: make sure we only remove files we create Amador Pahim
2017-08-18 17:05 ` [Qemu-devel] [PATCH v7 09/11] qemu.py: launch vm only if it's not running Amador Pahim
2017-08-22 10:37   ` Fam Zheng
2017-08-18 17:05 ` [Qemu-devel] [PATCH v7 10/11] qemu.py: don't launch again before shutdown() Amador Pahim
2017-08-18 17:05 ` [Qemu-devel] [PATCH v7 11/11] qemu.py: refactor launch() Amador Pahim
2017-08-31 23:36 ` [Qemu-devel] [PATCH v7 00/11] scripts/qemu.py fixes and cleanups Eduardo Habkost
2017-09-01  8:56   ` Amador Pahim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170818170526.13496-1-apahim@redhat.com \
    --to=apahim@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=crosa@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=ldoktor@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.