All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amador Pahim <apahim@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	"Lukáš Doktor" <ldoktor@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Stefan Hajnoczi" <stefanha@gmail.com>,
	qemu-devel@nongnu.org, "Max Reitz" <mreitz@redhat.com>,
	"Cleber Rosa" <crosa@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v7 02/11] qemu.py: avoid writing to stdout/stderr
Date: Tue, 22 Aug 2017 14:38:30 +0200	[thread overview]
Message-ID: <CALAZnb2wp1UgDvO2fFiXQM0_y-4JPTRoxr-osX5NM1Cd=TFBcg@mail.gmail.com> (raw)
In-Reply-To: <20170822115632.GE3210@lemon>

On Tue, Aug 22, 2017 at 1:56 PM, Fam Zheng <famz@redhat.com> wrote:
> On Tue, 08/22 13:11, Amador Pahim wrote:
>> I don't think that the 'keep the behavior' principle should overcome
>> what the messages actually are. The question is: are they warning
>> messages? The way I see, the messages I changed in this commit to use
>> the logging system are both debug messages.
>
> I think the signal message is a warning.

Ok, that's a good reason to change. I will change that one in the next version.
Thanks.

>
> Fam

  reply	other threads:[~2017-08-22 12:38 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-18 17:05 [Qemu-devel] [PATCH v7 00/11] scripts/qemu.py fixes and cleanups Amador Pahim
2017-08-18 17:05 ` [Qemu-devel] [PATCH v7 01/11] qemu.py: fix is_running() return before first launch() Amador Pahim
2017-08-18 17:05 ` [Qemu-devel] [PATCH v7 02/11] qemu.py: avoid writing to stdout/stderr Amador Pahim
2017-08-22 10:24   ` Fam Zheng
2017-08-22 11:11     ` Amador Pahim
2017-08-22 11:56       ` Fam Zheng
2017-08-22 12:38         ` Amador Pahim [this message]
2017-08-18 17:05 ` [Qemu-devel] [PATCH v7 03/11] qemu.py: use os.path.null instead of /dev/null Amador Pahim
2017-08-22 10:24   ` Fam Zheng
2017-08-18 17:05 ` [Qemu-devel] [PATCH v7 04/11] qemu.py: use poll() instead of 'returncode' Amador Pahim
2017-08-30 21:10   ` Eduardo Habkost
2017-08-18 17:05 ` [Qemu-devel] [PATCH v7 05/11] qemu.py: cleanup redundant calls in launch() Amador Pahim
2017-08-18 17:05 ` [Qemu-devel] [PATCH v7 06/11] qemu.py: improve message on negative exit code Amador Pahim
2017-08-18 17:05 ` [Qemu-devel] [PATCH v7 07/11] qemu.py: include debug information on launch error Amador Pahim
2017-08-30 15:55   ` Cleber Rosa
2017-08-31  1:28     ` Fam Zheng
2017-08-31  9:47   ` Lukáš Doktor
2017-08-18 17:05 ` [Qemu-devel] [PATCH v7 08/11] qemu.py: make sure we only remove files we create Amador Pahim
2017-08-18 17:05 ` [Qemu-devel] [PATCH v7 09/11] qemu.py: launch vm only if it's not running Amador Pahim
2017-08-22 10:37   ` Fam Zheng
2017-08-18 17:05 ` [Qemu-devel] [PATCH v7 10/11] qemu.py: don't launch again before shutdown() Amador Pahim
2017-08-18 17:05 ` [Qemu-devel] [PATCH v7 11/11] qemu.py: refactor launch() Amador Pahim
2017-08-31 23:36 ` [Qemu-devel] [PATCH v7 00/11] scripts/qemu.py fixes and cleanups Eduardo Habkost
2017-09-01  8:56   ` Amador Pahim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALAZnb2wp1UgDvO2fFiXQM0_y-4JPTRoxr-osX5NM1Cd=TFBcg@mail.gmail.com' \
    --to=apahim@redhat.com \
    --cc=armbru@redhat.com \
    --cc=crosa@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=ldoktor@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.