From: Christophe JAILLET <christophe.jaillet@wanadoo.fr> To: kishon@ti.com, vivek.gautam@codeaurora.org, stephen.boyd@linaro.org, jh80.chung@samsung.com Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET <christophe.jaillet@wanadoo.fr> Subject: [PATCH v2] phy: qcom-usb-hsic: Fix error handling Date: Sun, 20 Aug 2017 12:16:23 +0200 [thread overview] Message-ID: <20170820101623.26757-1-christophe.jaillet@wanadoo.fr> (raw) According to error handling in this function, it is likely that going to 'err_ulpi' was expected here. Fixes: 605b8652f7f0 ("phy: Add support for Qualcomm's USB HSIC phy") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Reviewed-by: Stephen Boyd <stephen.boyd@linaro.org> --- v2: rebase after commit 0b56e9a7e835 which has moved from drivers/phy/phy-qcom-usb-hsic.c to drivers/phy/qualcomm/phy-qcom-usb-hsic.c Reviewed-by tag can be found at https://lkml.org/lkml/2017/2/20/48 --- drivers/phy/qualcomm/phy-qcom-usb-hsic.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-usb-hsic.c b/drivers/phy/qualcomm/phy-qcom-usb-hsic.c index c110563a73cb..00926df4bc5b 100644 --- a/drivers/phy/qualcomm/phy-qcom-usb-hsic.c +++ b/drivers/phy/qualcomm/phy-qcom-usb-hsic.c @@ -57,8 +57,10 @@ static int qcom_usb_hsic_phy_power_on(struct phy *phy) /* Configure pins for HSIC functionality */ pins_default = pinctrl_lookup_state(uphy->pctl, PINCTRL_STATE_DEFAULT); - if (IS_ERR(pins_default)) - return PTR_ERR(pins_default); + if (IS_ERR(pins_default)) { + ret = PTR_ERR(pins_default); + goto err_ulpi; + } ret = pinctrl_select_state(uphy->pctl, pins_default); if (ret) -- 2.11.0
WARNING: multiple messages have this Message-ID (diff)
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr> To: kishon@ti.com, vivek.gautam@codeaurora.org, stephen.boyd@linaro.org, jh80.chung@samsung.com Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET <christophe.jaillet@wanadoo.fr> Subject: [PATCH v2] phy: qcom-usb-hsic: Fix error handling Date: Sun, 20 Aug 2017 10:16:23 +0000 [thread overview] Message-ID: <20170820101623.26757-1-christophe.jaillet@wanadoo.fr> (raw) According to error handling in this function, it is likely that going to 'err_ulpi' was expected here. Fixes: 605b8652f7f0 ("phy: Add support for Qualcomm's USB HSIC phy") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Reviewed-by: Stephen Boyd <stephen.boyd@linaro.org> --- v2: rebase after commit 0b56e9a7e835 which has moved from drivers/phy/phy-qcom-usb-hsic.c to drivers/phy/qualcomm/phy-qcom-usb-hsic.c Reviewed-by tag can be found at https://lkml.org/lkml/2017/2/20/48 --- drivers/phy/qualcomm/phy-qcom-usb-hsic.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-usb-hsic.c b/drivers/phy/qualcomm/phy-qcom-usb-hsic.c index c110563a73cb..00926df4bc5b 100644 --- a/drivers/phy/qualcomm/phy-qcom-usb-hsic.c +++ b/drivers/phy/qualcomm/phy-qcom-usb-hsic.c @@ -57,8 +57,10 @@ static int qcom_usb_hsic_phy_power_on(struct phy *phy) /* Configure pins for HSIC functionality */ pins_default = pinctrl_lookup_state(uphy->pctl, PINCTRL_STATE_DEFAULT); - if (IS_ERR(pins_default)) - return PTR_ERR(pins_default); + if (IS_ERR(pins_default)) { + ret = PTR_ERR(pins_default); + goto err_ulpi; + } ret = pinctrl_select_state(uphy->pctl, pins_default); if (ret) -- 2.11.0
next reply other threads:[~2017-08-20 10:16 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-08-20 10:16 Christophe JAILLET [this message] 2017-08-20 10:16 ` [PATCH v2] phy: qcom-usb-hsic: Fix error handling Christophe JAILLET
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170820101623.26757-1-christophe.jaillet@wanadoo.fr \ --to=christophe.jaillet@wanadoo.fr \ --cc=jh80.chung@samsung.com \ --cc=kernel-janitors@vger.kernel.org \ --cc=kishon@ti.com \ --cc=linux-kernel@vger.kernel.org \ --cc=stephen.boyd@linaro.org \ --cc=vivek.gautam@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.