From: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> To: linux-serial@vger.kernel.org Cc: linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jiri Slaby <jslaby@suse.com>, Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> Subject: [PATCH v3] earlycon: initialise baud field of earlycon device structure Date: Mon, 21 Aug 2017 19:22:13 +0300 [thread overview] Message-ID: <20170821162213.27102-1-Eugeniy.Paltsev@synopsys.com> (raw) For now baud field of earlycon structure device is't initialised at all in of_setup_earlycon (in oppositе to register_earlycon). So when I use stdout-path to point earlycon device (like stdout-path = &serial or stdout-path = "serial:115200n8") baud field of earlycon device structure remains uninitialised and earlycon initialization is not performed correctly as of_setup_earlycon is used. When pass all arguments via bootargs (like bootargs = "earlycon=uart8250,mmio32,0xf0005000,115200n8") initialization is performed correctly as register_earlycon is used. So initialise baud field of earlycon device structure by value of "current-speed" property from device tree or from options (if they exist) when we use of_setup_earlycon Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> --- Changes v2 -> v3: * Use simple_strtoul instead of kstrtoul as with kstrtoul we can't parse options string which includes arguments except baudrate (like "115200n8") Changes v1 -> v2: * Use standart property name "current-speed" instead of custom "baud" NOTE: I don't add parsing of the other standard options here because we don't have any place to store them. When we parce and set options of the 'real' uart device (using uart_parse_options + uart_set_options) we populate ktermios structure an pass it to port->ops->set_termios callback of uart_port structure. So it is processing by uart driver itself. But we don't register such callbacks for earlycon. So we are only able to parse baud value, which can be stored in baud field of earlycon_device structure. drivers/tty/serial/earlycon.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/tty/serial/earlycon.c b/drivers/tty/serial/earlycon.c index c365154..82e813b 100644 --- a/drivers/tty/serial/earlycon.c +++ b/drivers/tty/serial/earlycon.c @@ -282,7 +282,12 @@ int __init of_setup_earlycon(const struct earlycon_id *match, } } + val = of_get_flat_dt_prop(node, "current-speed", NULL); + if (val) + early_console_dev.baud = be32_to_cpu(*val); + if (options) { + early_console_dev.baud = simple_strtoul(options, NULL, 0); strlcpy(early_console_dev.options, options, sizeof(early_console_dev.options)); } -- 2.9.3
WARNING: multiple messages have this Message-ID (diff)
From: Eugeniy.Paltsev@synopsys.com (Eugeniy Paltsev) To: linux-snps-arc@lists.infradead.org Subject: [PATCH v3] earlycon: initialise baud field of earlycon device structure Date: Mon, 21 Aug 2017 19:22:13 +0300 [thread overview] Message-ID: <20170821162213.27102-1-Eugeniy.Paltsev@synopsys.com> (raw) For now baud field of earlycon structure device is't initialised at all in of_setup_earlycon (in opposit? to register_earlycon). So when I use stdout-path to point earlycon device (like stdout-path = &serial or stdout-path = "serial:115200n8") baud field of earlycon device structure remains uninitialised and earlycon initialization is not performed correctly as of_setup_earlycon is used. When pass all arguments via bootargs (like bootargs = "earlycon=uart8250,mmio32,0xf0005000,115200n8") initialization is performed correctly as register_earlycon is used. So initialise baud field of earlycon device structure by value of "current-speed" property from device tree or from options (if they exist) when we use of_setup_earlycon Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev at synopsys.com> --- Changes v2 -> v3: * Use simple_strtoul instead of kstrtoul as with kstrtoul we can't parse options string which includes arguments except baudrate (like "115200n8") Changes v1 -> v2: * Use standart property name "current-speed" instead of custom "baud" NOTE: I don't add parsing of the other standard options here because we don't have any place to store them. When we parce and set options of the 'real' uart device (using uart_parse_options + uart_set_options) we populate ktermios structure an pass it to port->ops->set_termios callback of uart_port structure. So it is processing by uart driver itself. But we don't register such callbacks for earlycon. So we are only able to parse baud value, which can be stored in baud field of earlycon_device structure. drivers/tty/serial/earlycon.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/tty/serial/earlycon.c b/drivers/tty/serial/earlycon.c index c365154..82e813b 100644 --- a/drivers/tty/serial/earlycon.c +++ b/drivers/tty/serial/earlycon.c @@ -282,7 +282,12 @@ int __init of_setup_earlycon(const struct earlycon_id *match, } } + val = of_get_flat_dt_prop(node, "current-speed", NULL); + if (val) + early_console_dev.baud = be32_to_cpu(*val); + if (options) { + early_console_dev.baud = simple_strtoul(options, NULL, 0); strlcpy(early_console_dev.options, options, sizeof(early_console_dev.options)); } -- 2.9.3
next reply other threads:[~2017-08-21 16:22 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-08-21 16:22 Eugeniy Paltsev [this message] 2017-08-21 16:22 ` [PATCH v3] earlycon: initialise baud field of earlycon device structure Eugeniy Paltsev 2017-08-31 13:33 ` Eugeniy Paltsev 2017-08-31 13:33 ` Eugeniy Paltsev 2017-08-31 13:33 ` Eugeniy Paltsev
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170821162213.27102-1-Eugeniy.Paltsev@synopsys.com \ --to=eugeniy.paltsev@synopsys.com \ --cc=gregkh@linuxfoundation.org \ --cc=jslaby@suse.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=linux-snps-arc@lists.infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.