[PATCH] ste_dma40: make stedma40_chan_cfg const

[PATCH] ste_dma40: make stedma40_chan_cfg const

[Bhumika Goyal]

Make these const as they are only used during a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
 drivers/dma/ste_dma40.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
index c3052fb..f4fab41 100644
--- a/drivers/dma/ste_dma40.c
+++ b/drivers/dma/ste_dma40.c
@@ -79,7 +79,7 @@
 };
 
 /* Default configuration for physcial memcpy */
-static struct stedma40_chan_cfg dma40_memcpy_conf_phy = {
+static const struct stedma40_chan_cfg dma40_memcpy_conf_phy = {
 	.mode = STEDMA40_MODE_PHYSICAL,
 	.dir = DMA_MEM_TO_MEM,
 
@@ -93,7 +93,7 @@
 };
 
 /* Default configuration for logical memcpy */
-static struct stedma40_chan_cfg dma40_memcpy_conf_log = {
+static const struct stedma40_chan_cfg dma40_memcpy_conf_log = {
 	.mode = STEDMA40_MODE_LOGICAL,
 	.dir = DMA_MEM_TO_MEM,
 
-- 
1.9.1

[PATCH] ste_dma40: make stedma40_chan_cfg const

[Bhumika Goyal]

Make these const as they are only used during a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
 drivers/dma/ste_dma40.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
index c3052fb..f4fab41 100644
--- a/drivers/dma/ste_dma40.c
+++ b/drivers/dma/ste_dma40.c
@@ -79,7 +79,7 @@
 };
 
 /* Default configuration for physcial memcpy */
-static struct stedma40_chan_cfg dma40_memcpy_conf_phy = {
+static const struct stedma40_chan_cfg dma40_memcpy_conf_phy = {
 	.mode = STEDMA40_MODE_PHYSICAL,
 	.dir = DMA_MEM_TO_MEM,
 
@@ -93,7 +93,7 @@
 };
 
 /* Default configuration for logical memcpy */
-static struct stedma40_chan_cfg dma40_memcpy_conf_log = {
+static const struct stedma40_chan_cfg dma40_memcpy_conf_log = {
 	.mode = STEDMA40_MODE_LOGICAL,
 	.dir = DMA_MEM_TO_MEM,
 
-- 
1.9.1

Re: [PATCH] ste_dma40: make stedma40_chan_cfg const

[Linus Walleij]

On Sun, Aug 13, 2017 at 3:23 PM, Bhumika Goyal <bhumirks@gmail.com> wrote:

> Make these const as they are only used during a copy operation.
> Done using Coccinelle.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

[PATCH] ste_dma40: make stedma40_chan_cfg const

[Linus Walleij]

On Sun, Aug 13, 2017 at 3:23 PM, Bhumika Goyal <bhumirks@gmail.com> wrote:

> Make these const as they are only used during a copy operation.
> Done using Coccinelle.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

Re: [PATCH] ste_dma40: make stedma40_chan_cfg const

[Vinod Koul]

On Sun, Aug 13, 2017 at 06:53:04PM +0530, Bhumika Goyal wrote:
> Make these const as they are only used during a copy operation.
> Done using Coccinelle.

Pls make sure you use the right subsystem tags, hint, you cna check git log
on that subsystem/file to find the right ones

Applied after fixing the tags, thanks

-- 
~Vinod

[PATCH] ste_dma40: make stedma40_chan_cfg const

[Vinod Koul]

On Sun, Aug 13, 2017 at 06:53:04PM +0530, Bhumika Goyal wrote:
> Make these const as they are only used during a copy operation.
> Done using Coccinelle.

Pls make sure you use the right subsystem tags, hint, you cna check git log
on that subsystem/file to find the right ones

Applied after fixing the tags, thanks

-- 
~Vinod

Re: [PATCH] ste_dma40: make stedma40_chan_cfg const

[Bhumika Goyal]

On Mon, Aug 21, 2017 at 9:57 PM, Vinod Koul <vinod.koul@intel.com> wrote:
> On Sun, Aug 13, 2017 at 06:53:04PM +0530, Bhumika Goyal wrote:
>> Make these const as they are only used during a copy operation.
>> Done using Coccinelle.
>
> Pls make sure you use the right subsystem tags, hint, you cna check git log
> on that subsystem/file to find the right ones
>

Thanks for the note. I will be more careful next time.

Thanks,
Bhumika

> Applied after fixing the tags, thanks
>
> --
> ~Vinod

[PATCH] ste_dma40: make stedma40_chan_cfg const

[Bhumika Goyal]

On Mon, Aug 21, 2017 at 9:57 PM, Vinod Koul <vinod.koul@intel.com> wrote:
> On Sun, Aug 13, 2017 at 06:53:04PM +0530, Bhumika Goyal wrote:
>> Make these const as they are only used during a copy operation.
>> Done using Coccinelle.
>
> Pls make sure you use the right subsystem tags, hint, you cna check git log
> on that subsystem/file to find the right ones
>

Thanks for the note. I will be more careful next time.

Thanks,
Bhumika

> Applied after fixing the tags, thanks
>
> --
> ~Vinod