All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Burton <paul.burton@imgtec.com>
To: <linux-mips@linux-mips.org>, Ralf Baechle <ralf@linux-mips.org>,
	<trivial@kernel.org>
Cc: Paul Burton <paul.burton@imgtec.com>
Subject: [PATCH 02/11] MIPS: generic: Include asm/time.h for get_c0_*_int()
Date: Wed, 23 Aug 2017 11:17:45 -0700	[thread overview]
Message-ID: <20170823181754.24044-3-paul.burton@imgtec.com> (raw)
In-Reply-To: <20170823181754.24044-1-paul.burton@imgtec.com>

arch/mips/generic/irq.c provides implementations of the
get_c0_compare_int() & get_c0_perfcount_int() functions, but doesn't
include the asm/time.h header which declares them. This leads to
warnings from sparse:

  arch/mips/generic/irq.c:36:5: warning: symbol 'get_c0_perfcount_int'
    was not declared. Should it be static?
  arch/mips/generic/irq.c:52:14: warning: symbol 'get_c0_compare_int'
    was not declared. Should it be static?

Fix this by including asm/time.h to get the declarations of
get_c0_compare_int() & get_c0_perfcount_int().

Signed-off-by: Paul Burton <paul.burton@imgtec.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
---

 arch/mips/generic/irq.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/mips/generic/irq.c b/arch/mips/generic/irq.c
index 14064bdd91dd..efe359ce2576 100644
--- a/arch/mips/generic/irq.c
+++ b/arch/mips/generic/irq.c
@@ -16,6 +16,7 @@
 #include <linux/types.h>
 
 #include <asm/irq.h>
+#include <asm/time.h>
 
 int get_c0_fdc_int(void)
 {
-- 
2.14.1

WARNING: multiple messages have this Message-ID (diff)
From: Paul Burton <paul.burton@imgtec.com>
To: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>,
	trivial@kernel.org
Cc: Paul Burton <paul.burton@imgtec.com>
Subject: [PATCH 02/11] MIPS: generic: Include asm/time.h for get_c0_*_int()
Date: Wed, 23 Aug 2017 11:17:45 -0700	[thread overview]
Message-ID: <20170823181754.24044-3-paul.burton@imgtec.com> (raw)
Message-ID: <20170823181745.nqa_4Vf5na_e7BU_VWd6K1B6wKZb728c55XKIeivgh8@z> (raw)
In-Reply-To: <20170823181754.24044-1-paul.burton@imgtec.com>

arch/mips/generic/irq.c provides implementations of the
get_c0_compare_int() & get_c0_perfcount_int() functions, but doesn't
include the asm/time.h header which declares them. This leads to
warnings from sparse:

  arch/mips/generic/irq.c:36:5: warning: symbol 'get_c0_perfcount_int'
    was not declared. Should it be static?
  arch/mips/generic/irq.c:52:14: warning: symbol 'get_c0_compare_int'
    was not declared. Should it be static?

Fix this by including asm/time.h to get the declarations of
get_c0_compare_int() & get_c0_perfcount_int().

Signed-off-by: Paul Burton <paul.burton@imgtec.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
---

 arch/mips/generic/irq.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/mips/generic/irq.c b/arch/mips/generic/irq.c
index 14064bdd91dd..efe359ce2576 100644
--- a/arch/mips/generic/irq.c
+++ b/arch/mips/generic/irq.c
@@ -16,6 +16,7 @@
 #include <linux/types.h>
 
 #include <asm/irq.h>
+#include <asm/time.h>
 
 int get_c0_fdc_int(void)
 {
-- 
2.14.1

  parent reply	other threads:[~2017-08-23 18:19 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-23 18:17 [PATCH 00/11] MIPS: Fix various sparse warnings Paul Burton
2017-08-23 18:17 ` Paul Burton
2017-08-23 18:17 ` [PATCH 01/11] MIPS: generic: Include asm/bootinfo.h for plat_fdt_relocated() Paul Burton
2017-08-23 18:17   ` Paul Burton
2017-08-23 18:17 ` Paul Burton [this message]
2017-08-23 18:17   ` [PATCH 02/11] MIPS: generic: Include asm/time.h for get_c0_*_int() Paul Burton
2017-08-23 18:17 ` [PATCH 03/11] MIPS: Include asm/setup.h for cpu_cache_init() Paul Burton
2017-08-23 18:17   ` Paul Burton
2017-08-23 18:17 ` [PATCH 04/11] MIPS: Include linux/cpu.h for arch_cpu_idle() Paul Burton
2017-08-23 18:17   ` Paul Burton
2017-08-23 18:17 ` [PATCH 05/11] MIPS: Include asm/delay.h for __{,n,u}delay() Paul Burton
2017-08-23 18:17   ` Paul Burton
2017-08-23 18:17 ` [PATCH 06/11] MIPS: Include elf-randomize.h for arch_mmap_rnd() & arch_randomize_brk() Paul Burton
2017-08-23 18:17   ` Paul Burton
2017-08-23 18:17 ` [PATCH 07/11] MIPS: Include linux/initrd.h for free_initrd_mem() Paul Burton
2017-08-23 18:17   ` Paul Burton
2017-08-23 18:17 ` [PATCH 08/11] MIPS: math-emu: Correct user fault_addr type Paul Burton
2017-08-23 18:17   ` Paul Burton
2017-08-23 18:17 ` [PATCH 09/11] MIPS: Remove __invalidate_kernel_vmap_range Paul Burton
2017-08-23 18:17   ` Paul Burton
2017-08-23 18:17 ` [PATCH 10/11] MIPS: Remove plat_timer_setup() Paul Burton
2017-08-23 18:17   ` Paul Burton
2017-08-23 18:17 ` [PATCH 11/11] MIPS: Declare various variables & functions static Paul Burton
2017-08-23 18:17   ` Paul Burton
2017-08-29 10:07   ` Marcin Nowakowski
2017-08-29 10:07     ` Marcin Nowakowski
     [not found]   ` <787b1a5b-2e77-41cc-235f-6dfd882b225a@imgtec.com>
2017-08-29 16:44     ` Paul Burton
2017-08-29 16:44       ` Paul Burton
2017-08-29 16:46       ` Ralf Baechle
2017-08-25 21:20 ` [PATCH 00/11] MIPS: Fix various sparse warnings Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170823181754.24044-3-paul.burton@imgtec.com \
    --to=paul.burton@imgtec.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.