All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/dp: Don't invalidate intel_dp_detect result
@ 2017-08-23 22:40 Puthikorn Voravootivat
  2017-08-23 22:57 ` ✓ Fi.CI.BAT: success for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Puthikorn Voravootivat @ 2017-08-23 22:40 UTC (permalink / raw)
  To: intel-gfx
  Cc: Puthikorn Voravootivat, Jim Bride, Dhinakaran Pandiyan, Rodrigo Vivi

If the full detect is already done, we shouldn't need to do it
again.

This fixes the screen blinking issue that happen when calling
DRM_IOCTL_MODE_GETCONNECTOR while PSR is active. The blinking
is caused by full dp detect in intel_dp_long_pulse().

Signed-off-by: Puthikorn Voravootivat <puthik@chromium.org>
---
 drivers/gpu/drm/i915/intel_dp.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index d3e5fdf0d2fa..152e7016d5f2 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -4834,8 +4834,6 @@ intel_dp_detect(struct drm_connector *connector,
 	if (!intel_dp->detect_done)
 		status = intel_dp_long_pulse(intel_dp->attached_connector);
 
-	intel_dp->detect_done = false;
-
 	return status;
 }
 
-- 
2.14.1.342.g6490525c54-goog

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/dp: Don't invalidate intel_dp_detect result
  2017-08-23 22:40 [PATCH] drm/i915/dp: Don't invalidate intel_dp_detect result Puthikorn Voravootivat
@ 2017-08-23 22:57 ` Patchwork
  2017-08-23 23:00 ` [PATCH] " Rodrigo Vivi
  2017-08-24  1:09 ` Manasi Navare
  2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2017-08-23 22:57 UTC (permalink / raw)
  To: Puthikorn Voravootivat; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/dp: Don't invalidate intel_dp_detect result
URL   : https://patchwork.freedesktop.org/series/29247/
State : success

== Summary ==

Series 29247v1 drm/i915/dp: Don't invalidate intel_dp_detect result
https://patchwork.freedesktop.org/api/1.0/series/29247/revisions/1/mbox/

Test kms_flip:
        Subgroup basic-flip-vs-modeset:
                skip       -> PASS       (fi-skl-x1585l) fdo#101781
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-b:
                pass       -> DMESG-WARN (fi-byt-n2820) fdo#101705
        Subgroup suspend-read-crc-pipe-c:
                fail       -> PASS       (fi-skl-6700k) fdo#100367

fdo#101781 https://bugs.freedesktop.org/show_bug.cgi?id=101781
fdo#101705 https://bugs.freedesktop.org/show_bug.cgi?id=101705
fdo#100367 https://bugs.freedesktop.org/show_bug.cgi?id=100367

fi-bdw-5557u     total:279  pass:268  dwarn:0   dfail:0   fail:0   skip:11  time:456s
fi-bdw-gvtdvm    total:279  pass:265  dwarn:0   dfail:0   fail:0   skip:14  time:438s
fi-blb-e6850     total:279  pass:224  dwarn:1   dfail:0   fail:0   skip:54  time:365s
fi-bsw-n3050     total:279  pass:243  dwarn:0   dfail:0   fail:0   skip:36  time:559s
fi-bwr-2160      total:279  pass:184  dwarn:0   dfail:0   fail:0   skip:95  time:253s
fi-bxt-j4205     total:279  pass:260  dwarn:0   dfail:0   fail:0   skip:19  time:526s
fi-byt-j1900     total:279  pass:254  dwarn:1   dfail:0   fail:0   skip:24  time:526s
fi-byt-n2820     total:279  pass:250  dwarn:1   dfail:0   fail:0   skip:28  time:513s
fi-elk-e7500     total:279  pass:230  dwarn:0   dfail:0   fail:0   skip:49  time:435s
fi-glk-2a        total:279  pass:260  dwarn:0   dfail:0   fail:0   skip:19  time:611s
fi-hsw-4770      total:279  pass:263  dwarn:0   dfail:0   fail:0   skip:16  time:447s
fi-hsw-4770r     total:279  pass:263  dwarn:0   dfail:0   fail:0   skip:16  time:419s
fi-ilk-650       total:279  pass:229  dwarn:0   dfail:0   fail:0   skip:50  time:418s
fi-ivb-3520m     total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:499s
fi-ivb-3770      total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:475s
fi-kbl-7500u     total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:478s
fi-kbl-7560u     total:279  pass:269  dwarn:0   dfail:0   fail:0   skip:10  time:598s
fi-kbl-r         total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:591s
fi-pnv-d510      total:279  pass:223  dwarn:1   dfail:0   fail:0   skip:55  time:527s
fi-skl-6260u     total:279  pass:269  dwarn:0   dfail:0   fail:0   skip:10  time:468s
fi-skl-6700k     total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:485s
fi-skl-6770hq    total:279  pass:269  dwarn:0   dfail:0   fail:0   skip:10  time:484s
fi-skl-gvtdvm    total:279  pass:266  dwarn:0   dfail:0   fail:0   skip:13  time:439s
fi-skl-x1585l    total:279  pass:269  dwarn:0   dfail:0   fail:0   skip:10  time:501s
fi-snb-2520m     total:279  pass:251  dwarn:0   dfail:0   fail:0   skip:28  time:547s
fi-snb-2600      total:279  pass:250  dwarn:0   dfail:0   fail:0   skip:29  time:410s

3adc9e3cacefe82619fc56ec78a0ca3a67a4b00c drm-tip: 2017y-08m-23d-21h-35m-35s UTC integration manifest
8066b1a7436d drm/i915/dp: Don't invalidate intel_dp_detect result

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5481/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/dp: Don't invalidate intel_dp_detect result
  2017-08-23 22:40 [PATCH] drm/i915/dp: Don't invalidate intel_dp_detect result Puthikorn Voravootivat
  2017-08-23 22:57 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-08-23 23:00 ` Rodrigo Vivi
  2017-08-23 23:32   ` Puthikorn Voravootivat
  2017-08-24  1:09 ` Manasi Navare
  2 siblings, 1 reply; 6+ messages in thread
From: Rodrigo Vivi @ 2017-08-23 23:00 UTC (permalink / raw)
  To: Puthikorn Voravootivat, shubhangi.shrivastava,
	Sivakumar Thulasimani, nathan.d.ciobanu, Manasi Navare,
	Jani Nikula
  Cc: intel-gfx, Jim Bride, Dhinakaran Pandiyan, Rodrigo Vivi

On Wed, Aug 23, 2017 at 3:40 PM, Puthikorn Voravootivat
<puthik@chromium.org> wrote:
> If the full detect is already done, we shouldn't need to do it
> again.
>
> This fixes the screen blinking issue that happen when calling
> DRM_IOCTL_MODE_GETCONNECTOR while PSR is active. The blinking
> is caused by full dp detect in intel_dp_long_pulse().
>
> Signed-off-by: Puthikorn Voravootivat <puthik@chromium.org>
> ---
>  drivers/gpu/drm/i915/intel_dp.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index d3e5fdf0d2fa..152e7016d5f2 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -4834,8 +4834,6 @@ intel_dp_detect(struct drm_connector *connector,
>         if (!intel_dp->detect_done)
>                 status = intel_dp_long_pulse(intel_dp->attached_connector);
>
> -       intel_dp->detect_done = false;
> -

something tells me that this will break other existent cases...
one case I imagine is changing the DP panel... maybe the MST case as well..

what about instead of removing this "detect_done=false" like we move
to another place like whenever conector is disconected?

looking to original commit:
commit 7d23e3c37bb3fc6952dc84007ee60cb533fd2d5c
Author: Shubhangi Shrivastava <shubhangi.shrivastava@intel.com>

let's cc few people here to see if they have something to say...



>         return status;
>  }
>
> --
> 2.14.1.342.g6490525c54-goog
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/dp: Don't invalidate intel_dp_detect result
  2017-08-23 23:00 ` [PATCH] " Rodrigo Vivi
@ 2017-08-23 23:32   ` Puthikorn Voravootivat
  2017-08-23 23:39     ` Rodrigo Vivi
  0 siblings, 1 reply; 6+ messages in thread
From: Puthikorn Voravootivat @ 2017-08-23 23:32 UTC (permalink / raw)
  To: Rodrigo Vivi
  Cc: Jim Bride, Jani Nikula, intel-gfx, nathan.d.ciobanu,
	Dhinakaran Pandiyan, Rodrigo Vivi, Puthikorn Voravootivat,
	shubhangi.shrivastava

> what about instead of removing this "detect_done=false" like we move
> to another place like whenever conector is disconected?

Look like that is already done in
https://patchwork.freedesktop.org/patch/113363/

On Wed, Aug 23, 2017 at 4:00 PM, Rodrigo Vivi <rodrigo.vivi@gmail.com> wrote:
> On Wed, Aug 23, 2017 at 3:40 PM, Puthikorn Voravootivat
> <puthik@chromium.org> wrote:
>> If the full detect is already done, we shouldn't need to do it
>> again.
>>
>> This fixes the screen blinking issue that happen when calling
>> DRM_IOCTL_MODE_GETCONNECTOR while PSR is active. The blinking
>> is caused by full dp detect in intel_dp_long_pulse().
>>
>> Signed-off-by: Puthikorn Voravootivat <puthik@chromium.org>
>> ---
>>  drivers/gpu/drm/i915/intel_dp.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
>> index d3e5fdf0d2fa..152e7016d5f2 100644
>> --- a/drivers/gpu/drm/i915/intel_dp.c
>> +++ b/drivers/gpu/drm/i915/intel_dp.c
>> @@ -4834,8 +4834,6 @@ intel_dp_detect(struct drm_connector *connector,
>>         if (!intel_dp->detect_done)
>>                 status = intel_dp_long_pulse(intel_dp->attached_connector);
>>
>> -       intel_dp->detect_done = false;
>> -
>
> something tells me that this will break other existent cases...
> one case I imagine is changing the DP panel... maybe the MST case as well..
>
> what about instead of removing this "detect_done=false" like we move
> to another place like whenever conector is disconected?
>
> looking to original commit:
> commit 7d23e3c37bb3fc6952dc84007ee60cb533fd2d5c
> Author: Shubhangi Shrivastava <shubhangi.shrivastava@intel.com>
>
> let's cc few people here to see if they have something to say...
>
>
>
>>         return status;
>>  }
>>
>> --
>> 2.14.1.342.g6490525c54-goog
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
>
>
> --
> Rodrigo Vivi
> Blog: http://blog.vivi.eng.br
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/dp: Don't invalidate intel_dp_detect result
  2017-08-23 23:32   ` Puthikorn Voravootivat
@ 2017-08-23 23:39     ` Rodrigo Vivi
  0 siblings, 0 replies; 6+ messages in thread
From: Rodrigo Vivi @ 2017-08-23 23:39 UTC (permalink / raw)
  To: Puthikorn Voravootivat, Ville Syrjälä
  Cc: Jim Bride, Jani Nikula, intel-gfx, nathan.d.ciobanu,
	Dhinakaran Pandiyan, Rodrigo Vivi, shubhangi.shrivastava

On Wed, Aug 23, 2017 at 4:32 PM, Puthikorn Voravootivat
<puthik@chromium.org> wrote:
>> what about instead of removing this "detect_done=false" like we move
>> to another place like whenever conector is disconected?
>
> Look like that is already done in
> https://patchwork.freedesktop.org/patch/113363/

hmm indeed that seems to address my first thoughts...
but this also shows we need to cc ville as well here...

>
> On Wed, Aug 23, 2017 at 4:00 PM, Rodrigo Vivi <rodrigo.vivi@gmail.com> wrote:
>> On Wed, Aug 23, 2017 at 3:40 PM, Puthikorn Voravootivat
>> <puthik@chromium.org> wrote:
>>> If the full detect is already done, we shouldn't need to do it
>>> again.
>>>
>>> This fixes the screen blinking issue that happen when calling
>>> DRM_IOCTL_MODE_GETCONNECTOR while PSR is active. The blinking
>>> is caused by full dp detect in intel_dp_long_pulse().
>>>
>>> Signed-off-by: Puthikorn Voravootivat <puthik@chromium.org>
>>> ---
>>>  drivers/gpu/drm/i915/intel_dp.c | 2 --
>>>  1 file changed, 2 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
>>> index d3e5fdf0d2fa..152e7016d5f2 100644
>>> --- a/drivers/gpu/drm/i915/intel_dp.c
>>> +++ b/drivers/gpu/drm/i915/intel_dp.c
>>> @@ -4834,8 +4834,6 @@ intel_dp_detect(struct drm_connector *connector,
>>>         if (!intel_dp->detect_done)
>>>                 status = intel_dp_long_pulse(intel_dp->attached_connector);
>>>
>>> -       intel_dp->detect_done = false;
>>> -
>>
>> something tells me that this will break other existent cases...
>> one case I imagine is changing the DP panel... maybe the MST case as well..
>>
>> what about instead of removing this "detect_done=false" like we move
>> to another place like whenever conector is disconected?
>>
>> looking to original commit:
>> commit 7d23e3c37bb3fc6952dc84007ee60cb533fd2d5c
>> Author: Shubhangi Shrivastava <shubhangi.shrivastava@intel.com>
>>
>> let's cc few people here to see if they have something to say...
>>
>>
>>
>>>         return status;
>>>  }
>>>
>>> --
>>> 2.14.1.342.g6490525c54-goog
>>>
>>> _______________________________________________
>>> Intel-gfx mailing list
>>> Intel-gfx@lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>>
>>
>>
>> --
>> Rodrigo Vivi
>> Blog: http://blog.vivi.eng.br



-- 
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/dp: Don't invalidate intel_dp_detect result
  2017-08-23 22:40 [PATCH] drm/i915/dp: Don't invalidate intel_dp_detect result Puthikorn Voravootivat
  2017-08-23 22:57 ` ✓ Fi.CI.BAT: success for " Patchwork
  2017-08-23 23:00 ` [PATCH] " Rodrigo Vivi
@ 2017-08-24  1:09 ` Manasi Navare
  2 siblings, 0 replies; 6+ messages in thread
From: Manasi Navare @ 2017-08-24  1:09 UTC (permalink / raw)
  To: Puthikorn Voravootivat
  Cc: intel-gfx, Jim Bride, Dhinakaran Pandiyan, Rodrigo Vivi

On Wed, Aug 23, 2017 at 03:40:28PM -0700, Puthikorn Voravootivat wrote:
> If the full detect is already done, we shouldn't need to do it
> again.
> 
> This fixes the screen blinking issue that happen when calling
> DRM_IOCTL_MODE_GETCONNECTOR while PSR is active. The blinking
> is caused by full dp detect in intel_dp_long_pulse().
>

Thanks for the patch. Yes I completely agree with this, the
main purpose of this flag was to avoid calling long pulse
handler multiple times when it was being called from multiple places.
Now we do not need this flag since it does a full detect every time
get connector IOCTL is called since it calls intel_dp_detect().

This patch needs to remove the detect_done from all the other places
where its being set and from intel_dp struct as well.
I had already submitted a patch for this a while ago:
https://patchwork.freedesktop.org/patch/137592/
Please take a look. However if you read the M-L archive, you will
find the comments and it never got accepted. Some of the arguments
were that since EDID might have changed, we need to always do
a full detect each time GET_CONNECTOR IOCTL is called.

Regards
Manasi
 
> Signed-off-by: Puthikorn Voravootivat <puthik@chromium.org>
> ---
>  drivers/gpu/drm/i915/intel_dp.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index d3e5fdf0d2fa..152e7016d5f2 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -4834,8 +4834,6 @@ intel_dp_detect(struct drm_connector *connector,
>  	if (!intel_dp->detect_done)
>  		status = intel_dp_long_pulse(intel_dp->attached_connector);
>  
> -	intel_dp->detect_done = false;
> -
>  	return status;
>  }
>  
> -- 
> 2.14.1.342.g6490525c54-goog
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-08-24  1:01 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-23 22:40 [PATCH] drm/i915/dp: Don't invalidate intel_dp_detect result Puthikorn Voravootivat
2017-08-23 22:57 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-08-23 23:00 ` [PATCH] " Rodrigo Vivi
2017-08-23 23:32   ` Puthikorn Voravootivat
2017-08-23 23:39     ` Rodrigo Vivi
2017-08-24  1:09 ` Manasi Navare

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.