* [PATCH] cdc_ncm: flag the ublox TOBY-L4 as wwan
@ 2017-08-25 12:59 Aleksander Morgado
2017-08-25 13:22 ` Greg KH
2017-08-25 13:39 ` [PATCH v2] cdc_ncm: flag the u-blox " Aleksander Morgado
0 siblings, 2 replies; 5+ messages in thread
From: Aleksander Morgado @ 2017-08-25 12:59 UTC (permalink / raw)
To: oliver, davem
Cc: stefano.godeas, marco.demarco, linux-usb, netdev, linux-kernel,
Aleksander Morgado
Signed-off-by: Aleksander Morgado <aleksander@aleksander.es>
---
drivers/net/usb/cdc_ncm.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
index 811b18215cae..47cab1bde065 100644
--- a/drivers/net/usb/cdc_ncm.c
+++ b/drivers/net/usb/cdc_ncm.c
@@ -1758,6 +1758,13 @@ static const struct usb_device_id cdc_devs[] = {
.driver_info = (unsigned long)&wwan_noarp_info,
},
+ /* u-blox TOBY-L4 */
+ { USB_DEVICE_AND_INTERFACE_INFO(0x1546, 0x1010,
+ USB_CLASS_COMM,
+ USB_CDC_SUBCLASS_NCM, USB_CDC_PROTO_NONE),
+ .driver_info = (unsigned long)&wwan_info,
+ },
+
/* Generic CDC-NCM devices */
{ USB_INTERFACE_INFO(USB_CLASS_COMM,
USB_CDC_SUBCLASS_NCM, USB_CDC_PROTO_NONE),
--
2.14.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] cdc_ncm: flag the ublox TOBY-L4 as wwan
2017-08-25 12:59 [PATCH] cdc_ncm: flag the ublox TOBY-L4 as wwan Aleksander Morgado
@ 2017-08-25 13:22 ` Greg KH
2017-08-25 13:30 ` Aleksander Morgado
2017-08-25 13:39 ` [PATCH v2] cdc_ncm: flag the u-blox " Aleksander Morgado
1 sibling, 1 reply; 5+ messages in thread
From: Greg KH @ 2017-08-25 13:22 UTC (permalink / raw)
To: Aleksander Morgado
Cc: oliver, davem, stefano.godeas, marco.demarco, linux-usb, netdev,
linux-kernel
On Fri, Aug 25, 2017 at 02:59:46PM +0200, Aleksander Morgado wrote:
> Signed-off-by: Aleksander Morgado <aleksander@aleksander.es>
> ---
> drivers/net/usb/cdc_ncm.c | 7 +++++++
> 1 file changed, 7 insertions(+)
Personally, I require patches to have changelog texts in them...
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] cdc_ncm: flag the ublox TOBY-L4 as wwan
2017-08-25 13:22 ` Greg KH
@ 2017-08-25 13:30 ` Aleksander Morgado
0 siblings, 0 replies; 5+ messages in thread
From: Aleksander Morgado @ 2017-08-25 13:30 UTC (permalink / raw)
To: Greg KH
Cc: Oliver Neukum, David S. Miller, Stefano Godeas, Marco De Marco,
linux-usb, netdev, linux-kernel
On Fri, Aug 25, 2017 at 3:22 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Fri, Aug 25, 2017 at 02:59:46PM +0200, Aleksander Morgado wrote:
>> Signed-off-by: Aleksander Morgado <aleksander@aleksander.es>
>> ---
>> drivers/net/usb/cdc_ncm.c | 7 +++++++
>> 1 file changed, 7 insertions(+)
>
> Personally, I require patches to have changelog texts in them...
Sure, will push a v2 with more info.
--
Aleksander
https://aleksander.es
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] cdc_ncm: flag the u-blox TOBY-L4 as wwan
2017-08-25 12:59 [PATCH] cdc_ncm: flag the ublox TOBY-L4 as wwan Aleksander Morgado
2017-08-25 13:22 ` Greg KH
@ 2017-08-25 13:39 ` Aleksander Morgado
2017-08-28 18:25 ` David Miller
1 sibling, 1 reply; 5+ messages in thread
From: Aleksander Morgado @ 2017-08-25 13:39 UTC (permalink / raw)
To: oliver, davem
Cc: stefano.godeas, marco.demarco, linux-usb, netdev, linux-kernel,
gregkh, Aleksander Morgado
The u-blox TOBY-L4 is a LTE Advanced (Cat 6) module with HSPA+ and 2G
fallback.
Unlike the TOBY-L2, this module has one single USB layout and exposes
several TTYs for control and a NCM interface for data. Connecting this
module may be done just by activating the desired PDP context with
'AT+CGACT=1,<cid>' and then running DHCP on the NCM interface.
Signed-off-by: Aleksander Morgado <aleksander@aleksander.es>
---
drivers/net/usb/cdc_ncm.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
index 811b18215cae..47cab1bde065 100644
--- a/drivers/net/usb/cdc_ncm.c
+++ b/drivers/net/usb/cdc_ncm.c
@@ -1758,6 +1758,13 @@ static const struct usb_device_id cdc_devs[] = {
.driver_info = (unsigned long)&wwan_noarp_info,
},
+ /* u-blox TOBY-L4 */
+ { USB_DEVICE_AND_INTERFACE_INFO(0x1546, 0x1010,
+ USB_CLASS_COMM,
+ USB_CDC_SUBCLASS_NCM, USB_CDC_PROTO_NONE),
+ .driver_info = (unsigned long)&wwan_info,
+ },
+
/* Generic CDC-NCM devices */
{ USB_INTERFACE_INFO(USB_CLASS_COMM,
USB_CDC_SUBCLASS_NCM, USB_CDC_PROTO_NONE),
--
2.14.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] cdc_ncm: flag the u-blox TOBY-L4 as wwan
2017-08-25 13:39 ` [PATCH v2] cdc_ncm: flag the u-blox " Aleksander Morgado
@ 2017-08-28 18:25 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2017-08-28 18:25 UTC (permalink / raw)
To: aleksander
Cc: oliver, stefano.godeas, marco.demarco, linux-usb, netdev,
linux-kernel, gregkh
From: Aleksander Morgado <aleksander@aleksander.es>
Date: Fri, 25 Aug 2017 15:39:16 +0200
> The u-blox TOBY-L4 is a LTE Advanced (Cat 6) module with HSPA+ and 2G
> fallback.
>
> Unlike the TOBY-L2, this module has one single USB layout and exposes
> several TTYs for control and a NCM interface for data. Connecting this
> module may be done just by activating the desired PDP context with
> 'AT+CGACT=1,<cid>' and then running DHCP on the NCM interface.
>
> Signed-off-by: Aleksander Morgado <aleksander@aleksander.es>
Applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-08-28 18:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-25 12:59 [PATCH] cdc_ncm: flag the ublox TOBY-L4 as wwan Aleksander Morgado
2017-08-25 13:22 ` Greg KH
2017-08-25 13:30 ` Aleksander Morgado
2017-08-25 13:39 ` [PATCH v2] cdc_ncm: flag the u-blox " Aleksander Morgado
2017-08-28 18:25 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.