* [PATCH] sha1-lookup: remove sha1_entry_pos() from header file
@ 2017-08-25 7:36 Christian Couder
2017-08-25 14:03 ` Jeff King
0 siblings, 1 reply; 2+ messages in thread
From: Christian Couder @ 2017-08-25 7:36 UTC (permalink / raw)
To: git; +Cc: Junio C Hamano, Jeff King, Christian Couder
Since f1068efefe (sha1_file: drop experimental GIT_USE_LOOKUP search, 2017-08-09)
the definition of sha1_entry_pos() has been removed from "sha1-lookup.c", so
there is no need anymore for its declaration in "sha1-lookup.h".
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
sha1-lookup.h | 6 ------
1 file changed, 6 deletions(-)
diff --git a/sha1-lookup.h b/sha1-lookup.h
index 20af285681..cf5314f402 100644
--- a/sha1-lookup.h
+++ b/sha1-lookup.h
@@ -7,10 +7,4 @@ extern int sha1_pos(const unsigned char *sha1,
void *table,
size_t nr,
sha1_access_fn fn);
-
-extern int sha1_entry_pos(const void *table,
- size_t elem_size,
- size_t key_offset,
- unsigned lo, unsigned hi, unsigned nr,
- const unsigned char *key);
#endif
--
2.14.1.326.g3dc57ebfbd.dirty
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sha1-lookup: remove sha1_entry_pos() from header file
2017-08-25 7:36 [PATCH] sha1-lookup: remove sha1_entry_pos() from header file Christian Couder
@ 2017-08-25 14:03 ` Jeff King
0 siblings, 0 replies; 2+ messages in thread
From: Jeff King @ 2017-08-25 14:03 UTC (permalink / raw)
To: Christian Couder; +Cc: git, Junio C Hamano, Christian Couder
On Fri, Aug 25, 2017 at 09:36:13AM +0200, Christian Couder wrote:
> Since f1068efefe (sha1_file: drop experimental GIT_USE_LOOKUP search, 2017-08-09)
> the definition of sha1_entry_pos() has been removed from "sha1-lookup.c", so
> there is no need anymore for its declaration in "sha1-lookup.h".
Doh, thanks for catching.
Patch is obviously good.
-Peff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-25 14:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-25 7:36 [PATCH] sha1-lookup: remove sha1_entry_pos() from header file Christian Couder
2017-08-25 14:03 ` Jeff King
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.