* [PATCH] btrfs-progs: print the csum length in debug-tree
@ 2017-08-25 13:13 josef
2017-08-25 13:48 ` Nikolay Borisov
0 siblings, 1 reply; 4+ messages in thread
From: josef @ 2017-08-25 13:13 UTC (permalink / raw)
To: kernel-team, linux-btrfs; +Cc: Josef Bacik
From: Josef Bacik <jbacik@fb.com>
While looking at a log of a corrupted fs I needed to verify we were
missing csums for a given range. Make this easier by printing out how
many bytes a csum extent item represents when using btrfs_debug_tree.
Signed-off-by: Josef Bacik <jbacik@fb.com>
---
print-tree.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/print-tree.c b/print-tree.c
index 5927ed3..a124c96 100644
--- a/print-tree.c
+++ b/print-tree.c
@@ -1103,9 +1103,15 @@ void btrfs_print_leaf(struct btrfs_root *root, struct extent_buffer *eb)
case BTRFS_CSUM_ITEM_KEY:
printf("\t\tcsum item\n");
break;
- case BTRFS_EXTENT_CSUM_KEY:
- printf("\t\textent csum item\n");
+ case BTRFS_EXTENT_CSUM_KEY: {
+ u16 csum_size =
+ btrfs_super_csum_size(root->fs_info->super_copy);
+ u32 size = (item_size / csum_size) *
+ root->fs_info->sectorsize;
+ printf("\t\textent csum item bytes %lu\n",
+ (unsigned long)size);
break;
+ }
case BTRFS_EXTENT_DATA_KEY:
print_file_extent_item(eb, item, i, ptr);
break;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] btrfs-progs: print the csum length in debug-tree
2017-08-25 13:13 [PATCH] btrfs-progs: print the csum length in debug-tree josef
@ 2017-08-25 13:48 ` Nikolay Borisov
2017-08-25 14:06 ` Josef Bacik
2017-09-01 15:10 ` David Sterba
0 siblings, 2 replies; 4+ messages in thread
From: Nikolay Borisov @ 2017-08-25 13:48 UTC (permalink / raw)
To: josef, kernel-team, linux-btrfs; +Cc: Josef Bacik
On 25.08.2017 16:13, josef@toxicpanda.com wrote:
> From: Josef Bacik <jbacik@fb.com>
>
> While looking at a log of a corrupted fs I needed to verify we were
> missing csums for a given range. Make this easier by printing out how
> many bytes a csum extent item represents when using btrfs_debug_tree.
>
> Signed-off-by: Josef Bacik <jbacik@fb.com>
> ---
> print-tree.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/print-tree.c b/print-tree.c
> index 5927ed3..a124c96 100644
> --- a/print-tree.c
> +++ b/print-tree.c
> @@ -1103,9 +1103,15 @@ void btrfs_print_leaf(struct btrfs_root *root, struct extent_buffer *eb)
> case BTRFS_CSUM_ITEM_KEY:
> printf("\t\tcsum item\n");
> break;
> - case BTRFS_EXTENT_CSUM_KEY:
> - printf("\t\textent csum item\n");
> + case BTRFS_EXTENT_CSUM_KEY: {
> + u16 csum_size =
> + btrfs_super_csum_size(root->fs_info->super_copy);
> + u32 size = (item_size / csum_size) *
> + root->fs_info->sectorsize;
> + printf("\t\textent csum item bytes %lu\n",
> + (unsigned long)size);
Currently for a csum item we get:
item 0 key (EXTENT_CSUM EXTENT_CSUM 1103101952) itemoff 16279 itemsize 4
extent csum item
Why don't you go one step further and print the covered range -
it would be key.offset + size (the number you've calculated) And so you
can print something like:
item 0 key (EXTENT_CSUM EXTENT_CSUM 1103101952) itemoff 16279 itemsize 4
extent csum item 1103101952-1103106048
"extent csum item range %llu-%lly\n", key.offset, key.offset + size
> break;
> + }
> case BTRFS_EXTENT_DATA_KEY:
> print_file_extent_item(eb, item, i, ptr);
> break;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] btrfs-progs: print the csum length in debug-tree
2017-08-25 13:48 ` Nikolay Borisov
@ 2017-08-25 14:06 ` Josef Bacik
2017-09-01 15:10 ` David Sterba
1 sibling, 0 replies; 4+ messages in thread
From: Josef Bacik @ 2017-08-25 14:06 UTC (permalink / raw)
To: Nikolay Borisov; +Cc: josef, kernel-team, linux-btrfs, Josef Bacik
On Fri, Aug 25, 2017 at 04:48:43PM +0300, Nikolay Borisov wrote:
>
>
> On 25.08.2017 16:13, josef@toxicpanda.com wrote:
> > From: Josef Bacik <jbacik@fb.com>
> >
> > While looking at a log of a corrupted fs I needed to verify we were
> > missing csums for a given range. Make this easier by printing out how
> > many bytes a csum extent item represents when using btrfs_debug_tree.
> >
> > Signed-off-by: Josef Bacik <jbacik@fb.com>
> > ---
> > print-tree.c | 10 ++++++++--
> > 1 file changed, 8 insertions(+), 2 deletions(-)
> >
> > diff --git a/print-tree.c b/print-tree.c
> > index 5927ed3..a124c96 100644
> > --- a/print-tree.c
> > +++ b/print-tree.c
> > @@ -1103,9 +1103,15 @@ void btrfs_print_leaf(struct btrfs_root *root, struct extent_buffer *eb)
> > case BTRFS_CSUM_ITEM_KEY:
> > printf("\t\tcsum item\n");
> > break;
> > - case BTRFS_EXTENT_CSUM_KEY:
> > - printf("\t\textent csum item\n");
> > + case BTRFS_EXTENT_CSUM_KEY: {
> > + u16 csum_size =
> > + btrfs_super_csum_size(root->fs_info->super_copy);
> > + u32 size = (item_size / csum_size) *
> > + root->fs_info->sectorsize;
> > + printf("\t\textent csum item bytes %lu\n",
> > + (unsigned long)size);
>
> Currently for a csum item we get:
>
> item 0 key (EXTENT_CSUM EXTENT_CSUM 1103101952) itemoff 16279 itemsize 4
> extent csum item
>
>
> Why don't you go one step further and print the covered range -
> it would be key.offset + size (the number you've calculated) And so you
> can print something like:
>
> item 0 key (EXTENT_CSUM EXTENT_CSUM 1103101952) itemoff 16279 itemsize 4
> extent csum item 1103101952-1103106048
>
> "extent csum item range %llu-%lly\n", key.offset, key.offset + size
>
Because real engineers do that math in their head.
Josef
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] btrfs-progs: print the csum length in debug-tree
2017-08-25 13:48 ` Nikolay Borisov
2017-08-25 14:06 ` Josef Bacik
@ 2017-09-01 15:10 ` David Sterba
1 sibling, 0 replies; 4+ messages in thread
From: David Sterba @ 2017-09-01 15:10 UTC (permalink / raw)
To: Nikolay Borisov; +Cc: josef, kernel-team, linux-btrfs, Josef Bacik
On Fri, Aug 25, 2017 at 04:48:43PM +0300, Nikolay Borisov wrote:
>
>
> On 25.08.2017 16:13, josef@toxicpanda.com wrote:
> > From: Josef Bacik <jbacik@fb.com>
> >
> > While looking at a log of a corrupted fs I needed to verify we were
> > missing csums for a given range. Make this easier by printing out how
> > many bytes a csum extent item represents when using btrfs_debug_tree.
> >
> > Signed-off-by: Josef Bacik <jbacik@fb.com>
> > ---
> > print-tree.c | 10 ++++++++--
> > 1 file changed, 8 insertions(+), 2 deletions(-)
> >
> > diff --git a/print-tree.c b/print-tree.c
> > index 5927ed3..a124c96 100644
> > --- a/print-tree.c
> > +++ b/print-tree.c
> > @@ -1103,9 +1103,15 @@ void btrfs_print_leaf(struct btrfs_root *root, struct extent_buffer *eb)
> > case BTRFS_CSUM_ITEM_KEY:
> > printf("\t\tcsum item\n");
> > break;
> > - case BTRFS_EXTENT_CSUM_KEY:
> > - printf("\t\textent csum item\n");
> > + case BTRFS_EXTENT_CSUM_KEY: {
> > + u16 csum_size =
> > + btrfs_super_csum_size(root->fs_info->super_copy);
> > + u32 size = (item_size / csum_size) *
> > + root->fs_info->sectorsize;
> > + printf("\t\textent csum item bytes %lu\n",
> > + (unsigned long)size);
>
> Currently for a csum item we get:
>
> item 0 key (EXTENT_CSUM EXTENT_CSUM 1103101952) itemoff 16279 itemsize 4
> extent csum item
>
>
> Why don't you go one step further and print the covered range -
> it would be key.offset + size (the number you've calculated) And so you
> can print something like:
>
> item 0 key (EXTENT_CSUM EXTENT_CSUM 1103101952) itemoff 16279 itemsize 4
> extent csum item 1103101952-1103106048
>
> "extent csum item range %llu-%lly\n", key.offset, key.offset + size
I think the calculation is really simple to do, if one needs it.
The 'bytes' seem to refer to the range so I'll change that to length.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-09-01 15:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-25 13:13 [PATCH] btrfs-progs: print the csum length in debug-tree josef
2017-08-25 13:48 ` Nikolay Borisov
2017-08-25 14:06 ` Josef Bacik
2017-09-01 15:10 ` David Sterba
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.